Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Li, Xin3" <xin3.li@intel.com>
To:     Thomas Gleixner <tglx@linutronix.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>
CC:     "mingo@redhat.com" <mingo@redhat.com>,
        "bp@alien8.de" <bp@alien8.de>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "hpa@zytor.com" <hpa@zytor.com>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "Christopherson,, Sean" <seanjc@google.com>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "Shankar, Ravi V" <ravi.v.shankar@intel.com>,
        "jiangshanlai@gmail.com" <jiangshanlai@gmail.com>,
        "Kang, Shan" <shan.kang@intel.com>
Subject: RE: [PATCH v8 05/33] x86/traps: add external_interrupt() to dispatch
 external interrupts
Thread-Topic: [PATCH v8 05/33] x86/traps: add external_interrupt() to dispatch
 external interrupts
Thread-Index: AQHZa4hBNd3d+GJ9EUqzqD+DP4Ohj698clwAgBZ2AGA=
Date:   Mon, 19 Jun 2023 19:16:24 +0000
Message-ID: <SA1PR11MB67340ED76E3707707D1D61A3A85FA@SA1PR11MB6734.namprd11.prod.outlook.com>
References: <20230410081438.1750-1-xin3.li@intel.com>
 <20230410081438.1750-6-xin3.li@intel.com> <87ttvm6s2v.ffs@tglx>
In-Reply-To: <87ttvm6s2v.ffs@tglx>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?QjlLm8+Ghzuiqzquqvi3BlNDz6O+0bl3WcPNOQrRHyPQwf6Ko5pdwuOoEzsE?=
 =?us-ascii?Q?EDEL/zJ7sHxvABuJmwuj/pxdFuDphn/9m0Hg6yXDfk4HHU0ltIQaRMNATFdG?=
 =?us-ascii?Q?zjiKL/3/XMkx6zc+FrTGATMNi3NUusYlD3JPBT/7HXIJMzSecL34298xB2LW?=
 =?us-ascii?Q?kgKPS/ZGM5oSe23FVXf6ivMljXpAQhCid6oYvWmc5QRE42hOIbyJ/BdGNovg?=
 =?us-ascii?Q?K7fSPmbLPoVJFqhOdXkzINFIjBycyqf8SNxtVThL1ZayWrirQDpuh4JuUXVX?=
 =?us-ascii?Q?V1/Pvb7GsJ4F4RwJzrjZ2z0bVRsNzgy/oVa5vKhxSEIJFP579mvybZgfWGCA?=
 =?us-ascii?Q?R/AnNnkk2z/11UrOYgcblDxn3Em+zWeoH6WY9cj469qiou0sq+sSb8euybtQ?=
 =?us-ascii?Q?wdM7maX/+2VOyReOfN4bWfXyZa9JKKnVxzQeJpzlMSMRjv/C0uUVSYfSM1p6?=
 =?us-ascii?Q?V1lBFJrlHpLqAh/RusNIFUfeO3H4Ud5ysV5mAQMFvaE8YpTyyO/QtsURW2p/?=
 =?us-ascii?Q?WgHh06byfe6jdsTAqI9yXv2FWC0CQqFMpoV+9mUDm9jq2Go6hZlmbiIhYkHv?=
 =?us-ascii?Q?g05S/578dY3y8KUTLlWwWy7tj6TM3VCES2WJzjmkjrg5eVhRqMQrGmKypZj0?=
 =?us-ascii?Q?knVbVQTX/jRGKQGhf95Fc0rKQn+5NDwIl80Gx+sPIryWOZZMNY2YM97qYw1O?=
 =?us-ascii?Q?vzRCC7zWNRmoi+Az3350p0jrWcBaabTn97Lp3KU3vUMejteet4viAI5xapbH?=
 =?us-ascii?Q?oPWdcsVVnRWks8iWte1PSg96YUdVO6KUgl8S6M85FR1cFhLUbYSLBu9UNPNR?=
 =?us-ascii?Q?zcL7yzl1j9N+fEmeyyKrEflXTpHn87lMZVfYn9x2nw/uJWjBZ05kMl4eoW8u?=
 =?us-ascii?Q?+wHVPYoEI0/73mCmpERZT1I1HihH13CZ+WE22RMWWfrgwNeTKlkCzolTeOFs?=
 =?us-ascii?Q?FaELfkEJ4yUoejwCa38ZXez/zD+K3hmrnsHYxhaQjS3eR4/LktNTF+iIx7RT?=
 =?us-ascii?Q?Sq4DptQCKtLYKsf5Ebkx/WHxN8o5j77qpfMMHpv9bkp7efyd8ZLIAzDlU1JJ?=
 =?us-ascii?Q?3t1lUzjWu35oy/AMf8F6K6z3/pFWjA4CKPWkh16pF7yQzDsn0rfz0/dA+ksg?=
 =?us-ascii?Q?kGqxqyIYhOjxhZHVUrSWUFI1ds839pE2O/TE4FzE9XK2SGMICFacJggZTk+U?=
 =?us-ascii?Q?ndkRXps68SsPMTTwQ034Dw7rVKWdbpg5tO1PasztRMddmsScSt9Bab7gTg+c?=
 =?us-ascii?Q?+mvnWNE0sErsaMj7s6kThG0W89MOnryFwWjkgsMyKjVEuOyNfIXsQlXr6uIW?=
 =?us-ascii?Q?x+XzVKdzb5tpdHzgWQ7yacOEXRjj/do/VQIoUeTXLEalgVaOdX7Rzb/Fk0eG?=
 =?us-ascii?Q?knbFvxpZOHBjD5Du6lQEScjBkbumIlvcV22bI/RKUPad+Rsza6HCWytrK/Js?=
 =?us-ascii?Q?dRRsQCg6tyZxVH/2k0EsgnjJxZBxoDYVly0e3H0rlnRVqyiPgtvg5ZiFKAtp?=
 =?us-ascii?Q?FR03HTmaZOnm3CuvbmQcRcEtQkv6LIQitlUhSKdxx5Zh3RBQTqi5WwUFImGs?=
 =?us-ascii?Q?nkD/+NPIXDlnEPK+HE0=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6734.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b6b70df0-879e-488a-4051-08db70f9acaf
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jun 2023 19:16:24.9272
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: U42sMpq6Hg9U2Os9gO6tfEq6gkBRf0K2Oe07NPZx1czTYfSByxJ4Sj0q3TaggHeBeGJizg0gEvQvmAK6V+KMKg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6096
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > Add external_interrupt() to dispatch external interrupts to their handl=
ers.
> >
> > If an external interrupt is a system interrupt, dipatch it through
> > system_interrupt_handlers table, otherwise to
> > dispatch_common_interrupt().
>=20
> This naming convention sucks. external interrupts which can be system
> interrupts. Come on.

This name dispatch_common_interrupt() comes from arch/x86/kernel/irq.c:

/*
 * common_interrupt() handles all normal device IRQ's (the special SMP
 * cross-CPU interrupts have their own entry points).
 */
DEFINE_IDTENTRY_IRQ(common_interrupt)

Should we rename it to device_intertupt()?

Thanks!
  Xin