Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230530213259.1776512-1-robimarko@gmail.com> <CAPDyKForsVQ_inZG9+8mWdWM6-_T6O23AiwndLg33Yh7rPYTpA@mail.gmail.com>
 <CAPDyKFrOG=mCW3WBr=n081EBDkKobSK_w+b6AnVAhcp_8gC5nQ@mail.gmail.com>
In-Reply-To: <CAPDyKFrOG=mCW3WBr=n081EBDkKobSK_w+b6AnVAhcp_8gC5nQ@mail.gmail.com>
From:   Robert Marko <robimarko@gmail.com>
Date:   Mon, 19 Jun 2023 21:36:54 +0200
Message-ID: <CAOX2RU5s9EPuwZM0T08HKjpr1TPn=Yvs9xAoJT41+PPRWTMYNw@mail.gmail.com>
Subject: Re: [PATCH] mmc: core: disable TRIM on Micron MTFC4GACAJCN-1M
To:     Ulf Hansson <ulf.hansson@linaro.org>
Cc:     "Luca Porzio (lporzio)" <lporzio@micron.com>, windhl@126.com,
        avri.altman@wdc.com, linux-mmc@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, 19 Jun 2023 at 13:43, Ulf Hansson <ulf.hansson@linaro.org> wrote:
>
> On Fri, 9 Jun 2023 at 00:18, Ulf Hansson <ulf.hansson@linaro.org> wrote:
> >
> > + Luca (Bean was added by Avri in another thread)
> >
> > On Tue, 30 May 2023 at 23:33, Robert Marko <robimarko@gmail.com> wrote:
> > >
> > > It seems that Micron MTFC4GACAJCN-1M despite advertising TRIM support does
> > > not work when the core is trying to use REQ_OP_WRITE_ZEROES.
> > >
> > > We are seeing the following errors in OpenWrt under 6.1 on Qnap Qhora 301W
> > > that we did not previously have and tracked it down to REQ_OP_WRITE_ZEROES:
> > > [   18.085950] I/O error, dev loop0, sector 596 op 0x9:(WRITE_ZEROES) flags 0x800 phys_seg 0 prio class 2
> > >
> > > Disabling TRIM makes the error go away, so lets add a quirk for this eMMC
> > > to disable TRIM.
> >
> > Let's leave this another week or so, to allow Micron folkz to confirm
> > before applying.
> >
> > >
> > > Signed-off-by: Robert Marko <robimarko@gmail.com>
>
> Applied for next and by adding a stable tag, thanks!

Thanks, I have sent the patch for one of Kingstom eMMC as well that
seems to have TRIM broken
as well.

Regards,
Robert
>
>
> Kind regards
> Uffe
>
> >
> > > ---
> > >  drivers/mmc/core/quirks.h | 7 +++++++
> > >  1 file changed, 7 insertions(+)
> > >
> > > diff --git a/drivers/mmc/core/quirks.h b/drivers/mmc/core/quirks.h
> > > index 29b9497936df..77caa0c903f8 100644
> > > --- a/drivers/mmc/core/quirks.h
> > > +++ b/drivers/mmc/core/quirks.h
> > > @@ -100,6 +100,13 @@ static const struct mmc_fixup __maybe_unused mmc_blk_fixups[] = {
> > >         MMC_FIXUP("V10016", CID_MANFID_KINGSTON, CID_OEMID_ANY, add_quirk_mmc,
> > >                   MMC_QUIRK_TRIM_BROKEN),
> > >
> > > +       /*
> > > +        * Micron MTFC4GACAJCN-1M advertises TRIM but it does not seems to
> > > +        * support being used to offload WRITE_ZEROES.
> > > +        */
> > > +       MMC_FIXUP("Q2J54A", CID_MANFID_MICRON, 0x014e, add_quirk_mmc,
> > > +                 MMC_QUIRK_TRIM_BROKEN),
> > > +
> > >         /*
> > >          * Some SD cards reports discard support while they don't
> > >          */
> > > --
> > > 2.40.1
> > >