Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1fd76d67-0839-1b82-5b6a-d3fc75a240f8@ti.com>
Date:   Mon, 19 Jun 2023 14:49:40 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH net v1] Revert "net: phy: dp83867: perform soft reset and
 retain established link"
Content-Language: en-US
To:     Andrew Lunn <andrew@lunn.ch>,
        Francesco Dolcini <francesco@dolcini.it>,
        Siddharth Vadapalli <s-vadapalli@ti.com>
CC:     Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        <linux-kernel@vger.kernel.org>,
        Francesco Dolcini <francesco.dolcini@toradex.com>,
        Geet Modi <geet.modi@ti.com>, <netdev@vger.kernel.org>
References: <20230619154435.355485-1-francesco@dolcini.it>
 <5563611e-5354-42fc-b33f-b1b4945e71de@lunn.ch>
From:   "Bajjuri, Praneeth" <praneeth@ti.com>
In-Reply-To: <5563611e-5354-42fc-b33f-b1b4945e71de@lunn.ch>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 6/19/2023 11:30 AM, Andrew Lunn wrote:
> On Mon, Jun 19, 2023 at 05:44:35PM +0200, Francesco Dolcini wrote:
>> From: Francesco Dolcini <francesco.dolcini@toradex.com>
>>
>> This reverts commit da9ef50f545f86ffe6ff786174d26500c4db737a.
>>
>> This fixes a regression in which the link would come up, but no
>> communication was possible.
>>
>> The reverted commit was also removing a comment about
>> DP83867_PHYCR_FORCE_LINK_GOOD, this is not added back in this commits
>> since it seems that this is unrelated to the original code change.
>>
>> Cc: Praneeth Bajjuri <praneeth@ti.com>
>> Closes: https://lore.kernel.org/all/ZGuDJos8D7N0J6Z2@francesco-nb.int.toradex.com/
>> Fixes: da9ef50f545f ("net: phy: dp83867: perform soft reset and retain established link")
>> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> 
> There has been plenty of time given for somebody to investigate this
> regression, and nothing has happened. So i agree, lets revert it.
> 
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>

Agreed to revert.

Reviewed-by: Praneeth Bajjuri <praneeth@ti.com>


> 
>      Andrew