Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 19 Jun 2023 22:18:08 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc:     Woojung Huh <woojung.huh@microchip.com>,
        UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Robert Hancock <hancock@sedsystems.ca>, stable@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: dsa: microchip: ksz9477: follow errata
 sheet when applying fixups
Message-ID: <ZJC4AFiu0YMzVRBo@corigine.com>
References: <20230619081633.589703-1-linux@rasmusvillemoes.dk>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230619081633.589703-1-linux@rasmusvillemoes.dk>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?e8Aa13+g9UmhTb0cByKZJrO7+jBJW7p44PkD8uT3T5CvNZFkk5w+isfEpC5C?=
 =?us-ascii?Q?tkZNRZp+Z/dKkWbZyLguiUsCxvoa1lGLdp8DSjCoIj9mkWina67F+3Uxj99Z?=
 =?us-ascii?Q?FemUjSf47YEXa6vC7RrSvRw5LlYpXmLAa3ItUajVlXm4MpqoLmvZpq0/XB/5?=
 =?us-ascii?Q?uOrrpZspTzCWTZ2OyG7hLxxrK1jGo5FPQzMHalH1O+TQ4zW0RjK8gzpPD7BI?=
 =?us-ascii?Q?ZR1Mr7u7q9GeQ3TW8dy7h5++kdDGAZi44B/BNcLEhIDV+6VGZNFn0yyXeOa1?=
 =?us-ascii?Q?1ixqU216kGbrzdDnT3TSZVd2eWRqh1zZe7PZQl/8FqqRB1TZ6g7D8UVE28E7?=
 =?us-ascii?Q?hQbAUJVcfBE3hsEjXDw6WhTa0d4XBuVh48xLu/d+hh9N41Krjwq0RdxC9Ib8?=
 =?us-ascii?Q?tLHNMBKHIoHsfRPMfo4OFtZDG5TDr/YNXvqeniQNr2LWUbVs2hxhKU+7nSLH?=
 =?us-ascii?Q?IIUHITbA5RU0VfBBnLQvpiSMU/UlCFOnhzl2QNIpXvDVFP0qMSVatkUYQ8eb?=
 =?us-ascii?Q?KW2JYAEYSqGpQeKRZBgzoh8K8+0yKkxk/67VrLZMG3F4IIvpPIWyVCIdv/kG?=
 =?us-ascii?Q?CFvVdEqB6Jp/qZpaw/1nQeZWlFcYryjJlZKWsAKKEwiZNrVQ6YyU/e5IFsqx?=
 =?us-ascii?Q?ZiYBeUcuH5EmjcL9tdzTO6OhgfALRhbHPHi9D/CMqD0glDoN5bbG5RR/beQT?=
 =?us-ascii?Q?5lG21CRu+CX2MjxSXuIefU3kMNTASbJUKxcFhPl/xb3AVav5lWDUSBDtTh/O?=
 =?us-ascii?Q?5fEMoT+PcxvTPY8/JfrmK/tfbRDuzAQ2AIrfhAXMeRHqIsLkPl0gET6K/+2N?=
 =?us-ascii?Q?2/tEgUTVE6i8sSpZZbOp5J55OzZ5oFS9g3sqIIkMU4ba7oUyak5qP2maUEml?=
 =?us-ascii?Q?hue+/lJr8XIWwHA2GigbAVm4GI+Z++D2OrlzLnla3XSUYBA4qNcut+M9Cbv9?=
 =?us-ascii?Q?UyeHpGa1jtH/nYE8NSISHfCkGL6omkCtRYlsJRlqwWEuw8+SB3MQa0Ov13UT?=
 =?us-ascii?Q?bGT3p+f2Huw+3FOJHUmpnKnTCLj7HGW0fNEv+GZ1sYbmAo81QIaSbzY5zh2F?=
 =?us-ascii?Q?RTpY2wLo4mMQ7MQv8hXm/PJArlCSpGLU9V92cP5FjNBdE0WORP3KPAsNe+bu?=
 =?us-ascii?Q?qoEWXdSPVDHJGWPEuj1MsOvayuwq1ef0nEIFYKXH6kOleX3d6zvnWZAe0IbT?=
 =?us-ascii?Q?hSHFfPpqMZhCO+AaiJwOmmYEt+yPyOJxEWA1kTvZBjmgKVNX0GIBo67o3JdA?=
 =?us-ascii?Q?qeNM/qxOlDNChHnc9kn1LfXN9xBHEAxPv2y0amp7z5Ih9zLYKlXy4qOZM8TO?=
 =?us-ascii?Q?5okd1hFUI4RUhyBmsOwr6SdMF65fZ8hSwGnxlYz4yYKX3IPGOpHFSxRlMdQL?=
 =?us-ascii?Q?j3VRHYoptvJWNDN9nraphlccgcxPBG+lYsnruKnGGfB+bKhXwVrgSXzi8mU4?=
 =?us-ascii?Q?wWUtQ6fJ2qCc7FDXMmQSfO2DSeR/bcYPHe0HA6VaAK/j4E7gEpshyPZdveNY?=
 =?us-ascii?Q?ipCV6VVbDm+Ei9QScvwdgebLZsHjSMhwHzM5yb1NFyxOgHdt5Gd7ekl5ZNwC?=
 =?us-ascii?Q?VmqQ9t8JNJa73zoTS1MgtyMrN8ek6hUGm5tEJQtwSFcj8V5eEgQqecqvEvI/?=
 =?us-ascii?Q?582asbx+Zy/mTbOBriruyxQuNkHoMnDkLXmJ/rDAJTjdk100gbydyHMKTH2B?=
 =?us-ascii?Q?7VY7QQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aef21cb9-6710-46aa-bc39-08db71025082
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2023 20:18:15.9197
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5geHW/Y1LmHetEk3FbthIvjEhbT7zhMi083NawzSK+6qWO0mS2AtCx2UrgyzedgzK+GoqMLv+eeHQz3/D+2pkdx0eWKf+AD6WC3F/lHXKbA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR13MB3634
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jun 19, 2023 at 10:16:32AM +0200, Rasmus Villemoes wrote:
> The errata sheets for both ksz9477 and ksz9567 begin with
> 
>   IMPORTANT NOTE
> 
>   Multiple errata workarounds in this document call for changing PHY
>   registers for each PHY port. PHY registers 0x0 to 0x1F are in the
>   address range 0xN100 to 0xN13F, while indirect (MMD) PHY registers
>   are accessed via the PHY MMD Setup Register and the PHY MMD Data
>   Register.
> 
>   Before configuring the PHY MMD registers, it is necessary to set the
>   PHY to 100 Mbps speed with auto-negotiation disabled by writing to
>   register 0xN100-0xN101. After writing the MMD registers, and after
>   all errata workarounds that involve PHY register settings, write
>   register 0xN100-0xN101 again to enable and restart auto-negotiation.
> 
> Without that explicit auto-neg restart, we do sometimes have problems
> establishing link.
> 
> Rather than writing back the hardcoded 0x1340 value the errata sheet
> suggests (which likely just corresponds to the most common strap
> configuration), restore the original value, setting the
> PORT_AUTO_NEG_RESTART bit if PORT_AUTO_NEG_ENABLE is set.
> 
> Fixes: 1fc33199185d ("net: dsa: microchip: Add PHY errata workarounds")
> Cc: stable@vger.kernel.org
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> ---
> While I do believe this is a fix, I don't think it's post-rc7
> material, hence targeting net-next with cc stable.

Hi Rasmus,

unfortunately this does not seem to apply to net-next.
Please consider rebasing and reposting.
Please include Andrew's Reviewed-by tag unless there
are substantial changes (seems unlikely).

-- 
pw-bot: changes-requested