Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 19 Jun 2023 21:27:33 +0100
From:   Conor Dooley <conor@kernel.org>
To:     Kamlesh Gurudasani <kamlesh@ti.com>
Cc:     Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
        Tero Kristo <kristo@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Jayesh Choudhary <j-choudhary@ti.com>,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: crypto: ti,sa2ul: make power-domains
 conditional
Message-ID: <20230619-trailside-shaft-72b2d6bcf978@spud>
References: <20230614-sa3ul-v3-0-2eeb810327a1@ti.com>
 <20230614-sa3ul-v3-1-2eeb810327a1@ti.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="Oun5Qk13m+H67PfU"
Content-Disposition: inline
In-Reply-To: <20230614-sa3ul-v3-1-2eeb810327a1@ti.com>
Precedence: bulk


--Oun5Qk13m+H67PfU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jun 19, 2023 at 06:58:47PM +0530, Kamlesh Gurudasani wrote:
> Devices specific to compatible ti,am62-sa3ul don't have control over
> power of SA3UL from main domain.
>=20
> "power-domains" property in crypto node tries to access
> the SA3UL power, for which it gets NACK and hence, driver doesn't
> probe properly for those particular devices.
>=20
> Make "power-domains" property as false for devices with
> compatible ti,am62-sa3ul.
>=20
> Signed-off-by: Kamlesh Gurudasani <kamlesh@ti.com>
> ---
>  Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml | 14 ++++++++++++=
+-
>  1 file changed, 13 insertions(+), 1 deletion(-)
>=20
> diff --git a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml b/Doc=
umentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> index 77ec8bc70bf7..88c8ee8821d4 100644
> --- a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> +++ b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> @@ -66,10 +66,22 @@ patternProperties:
>  required:
>    - compatible
>    - reg
> -  - power-domains
>    - dmas
>    - dma-names
> =20
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          items:

The usual pattern here is s/items/contains/. With that,
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

> +            const: ti,am62-sa3ul
> +    then:
> +      properties:
> +        power-domains: false
> +    else:
> +      required:
> +        - power-domains
> +
>  additionalProperties: false
> =20
>  examples:
>=20
> --=20
> 2.34.1
>=20

--Oun5Qk13m+H67PfU
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZJC6NQAKCRB4tDGHoIJi
0iEYAQD+WDPPfLmPj3pgUhjB/6auvhq2AQ81Cdlt3SKWpv1BxAD+P2XRB9x4Pt8N
VMchyEEGi/oeMAYxt2ySl3ft6xKh5Aw=
=VLLt
-----END PGP SIGNATURE-----

--Oun5Qk13m+H67PfU--