Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp7093463rwd; Mon, 19 Jun 2023 18:18:04 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ75c406mDOgaqBy9xheEHA3QHUYnZsGKluoWBbfTbPJmDRzUrRmZF9NHe2FCubXCCguuKqL X-Received: by 2002:a17:90b:2292:b0:24c:5e6:7035 with SMTP id kx18-20020a17090b229200b0024c05e67035mr5800803pjb.30.1687223883647; Mon, 19 Jun 2023 18:18:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687223883; cv=none; d=google.com; s=arc-20160816; b=CL/dXxHC7poD55rvOqh3hRGB7spW4hbEwwqMOc9MH+uLNKlddYrhbma3OjRAdhBqjq AUQwNNMApwX3cy3yoP7cvNz15mVuZ2KGGkUMN9f4gGZ0xsTxo0SFgr24z1UoYJcufp+G OkNYY3VHBlfm5550DSCVRn/JCao9y8bfNx3iYEckjS27D/oLwO0PcqkAa/h2e5Du05Pn CyD98LdVJwOt8mfzd5Hiyjf5gl8UG1Jf58+yo+bRZyHghIe8kr9Pahei2lYUR6IJGyqJ vnW4R6P8wwiPQ/sU3eawG5jT0snbwbflwk+cizD4Ecp3OitvYRJMs/qyXsyKUa01u1/f aybQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:from:cc:content-transfer-encoding :mime-version:date:message-id:subject:references:in-reply-to :dkim-signature; bh=NRom180+ATZtgmyPRPdQxtGMIDvHG/58KwOF2Gsfd7g=; b=Kf2HCqfrhjKUYBM64ZlkWxE5HMUD00YZD1Zosem7FtsKfa349KcDnyaA+1MOvkdJZp 78F/sPzOXkkvF2mmXrH0dDhDq2fWu7Sn3P4QjCIQ1cIQXpinWb3m6sTCxY9b1qgVBPHW hWWBu3Pr1/qmXZbVssnA1ncRhHWPxDCOwgy+g8CpOi52ip18ArfEqazHojLTy20QSJdg tnhd11nZZMkZfCIcXaPID0UqpDTiPmAsjPd9pQVdGumW3Vv7z+8no7Mi+ot+r9As39st 1CXjWCH+RfZqp37jVjuqSO8gsXiAhXihjJoN6hIH32jal2SYCskPV3BRS4vTfWJGIlXJ fBZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@rivosinc-com.20221208.gappssmtp.com header.s=20221208 header.b=CkvcwqYH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d3-20020a17090ad3c300b0025359a570fesi824449pjw.19.2023.06.19.18.17.51; Mon, 19 Jun 2023 18:18:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@rivosinc-com.20221208.gappssmtp.com header.s=20221208 header.b=CkvcwqYH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229986AbjFTA50 (ORCPT + 99 others); Mon, 19 Jun 2023 20:57:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229900AbjFTA5T (ORCPT ); Mon, 19 Jun 2023 20:57:19 -0400 Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E316010C1 for ; Mon, 19 Jun 2023 17:57:17 -0700 (PDT) Received: by mail-pg1-x52d.google.com with SMTP id 41be03b00d2f7-54fac3b7725so1651699a12.3 for ; Mon, 19 Jun 2023 17:57:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20221208.gappssmtp.com; s=20221208; t=1687222637; x=1689814637; h=to:from:cc:content-transfer-encoding:mime-version:date:message-id :subject:references:in-reply-to:from:to:cc:subject:date:message-id :reply-to; bh=NRom180+ATZtgmyPRPdQxtGMIDvHG/58KwOF2Gsfd7g=; b=CkvcwqYH/SA5Ms6ONtC0mRosDGng6jZiToLgTHz1hGKxWc5yivcLEK01aCfLcq7eBG /uGkXUu9EKUbYdrrEXEjfdLXVKey/HRU1qwqGGpO09itGaTHSwKPbnGVgZsyWnLrX7t7 5C3nzr5IvmOdPNbR5BsavXGU7uGuSjI5p0tvmCH2a4jAjDpfGCpbWvYpo5yKiij/BoVf YJTK1uMPmMwUUUV1y5BO16kLKtwj7yTpqK5opPGqt5C0neAJ30tIccBv7l8cg21DXS0q cH0TbljYvq3NDHHMOLcJ/SQRa33SY8LyKxn31ExJwCDHVx8qLyRees1j+fqn+cFtL8ek ClPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687222637; x=1689814637; h=to:from:cc:content-transfer-encoding:mime-version:date:message-id :subject:references:in-reply-to:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NRom180+ATZtgmyPRPdQxtGMIDvHG/58KwOF2Gsfd7g=; b=knh01qnmqI65KJQF2Ig4yf93t0/wF4VhIntagGRgwHlF46pR2QZk+1aWI2d3CN34z7 1UljSa9v/Gp8yU/9uRVwFOnhoK+wyjRIHnAJQctGu9meLYrf04JTo0WT8b0K9spbnpQl QbVT7U4kSayMv1u5VGbBcmdr9M9q1PBBGem1/OaFVkxx5OQ6KS9quCH1yJjnUumiPxYm OSL4ZQcYQUlkzvq8qWJ8KfYAiBijzt+babFe6rs4SGis2uXepjWkyQRrsRqL8ZejZwCk 8XUvD3e6XAeWcqDw2z9UjfJYgZDZ7FC4rPGfB2TgfWADTJgpWvEGyTIUOXJtx1eRGpY9 V6sA== X-Gm-Message-State: AC+VfDwLaWmoyCw7PlwZ94G5yKqcbaI783e9PV197WnfCXNvcwajsheY yR+Kjnv18DVuKKNffzGJxBWh2A== X-Received: by 2002:a05:6a21:32a2:b0:11f:3553:5c8a with SMTP id yt34-20020a056a2132a200b0011f35535c8amr5409311pzb.12.1687222637386; Mon, 19 Jun 2023 17:57:17 -0700 (PDT) Received: from localhost ([135.180.227.0]) by smtp.gmail.com with ESMTPSA id u15-20020a170902e80f00b001b024ee5f6esm385131plg.81.2023.06.19.17.57.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jun 2023 17:57:17 -0700 (PDT) In-Reply-To: <20230522025020.285042-1-songshuaishuai@tinylab.org> References: <20230522025020.285042-1-songshuaishuai@tinylab.org> Subject: Re: [PATCH V2] riscv: hibernation: Remove duplicate call of suspend_restore_csrs Message-Id: <168721242544.30028.11015895389526975730.b4-ty@rivosinc.com> Date: Mon, 19 Jun 2023 15:07:05 -0700 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.13-dev-901c5 Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Conor Dooley From: Palmer Dabbelt To: Paul Walmsley , Palmer Dabbelt , aou@eecs.berkeley.edu, suagrfillet@gmail.com, mason.huo@starfivetech.com, leyfoon.tan@starfivetech.com, ajones@ventanamicro.com, jeeheng.sia@starfivetech.com, Song Shuai X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 22 May 2023 10:50:20 +0800, Song Shuai wrote: > The suspend_restore_csrs is called in both __hibernate_cpu_resume > and the `else` of subsequent swsusp_arch_suspend. > > Removing the first call makes both suspend_{save,restore}_csrs > left in swsusp_arch_suspend for clean code. > > > [...] Applied, thanks! [1/1] riscv: hibernation: Remove duplicate call of suspend_restore_csrs https://git.kernel.org/palmer/c/c6399b893043 Best regards, -- Palmer Dabbelt