Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 20 Jun 2023 10:42:57 +0800
From:   Chao Gao <chao.gao@intel.com>
To:     Yan Zhao <yan.y.zhao@intel.com>
CC:     <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <pbonzini@redhat.com>, <seanjc@google.com>, <kai.huang@intel.com>,
        <robert.hoo.linux@gmail.com>
Subject: Re: [PATCH v3 07/11] KVM: VMX: drop IPAT in memtype when CD=1 for
 KVM_X86_QUIRK_CD_NW_CLEARED
Message-ID: <ZJESMaG5Thb5LWtt@chao-email>
References: <20230616023101.7019-1-yan.y.zhao@intel.com>
 <20230616023815.7439-1-yan.y.zhao@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230616023815.7439-1-yan.y.zhao@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Rg99VO7qzo8O4ca8C9cZNSguIUkOa4e+hp4Q08oCFckyC03UgVde2CU4l2WD?=
 =?us-ascii?Q?JUiM+ula0TqyZKzK4JmdoLiTV4l3doQ5YLcwJCJV/p22UMnfPeka0AtlZHbu?=
 =?us-ascii?Q?New/i8CFIBq+nR+xO2VwlQlXg2ipohyl1W/S+mtdq2gVFiZlHskRM/ggS39G?=
 =?us-ascii?Q?6aGNpbnLn5HWX5CzFPSMaO3VgUJzumqR4T8/fm1waKWmr07su0YKyzlveWSA?=
 =?us-ascii?Q?NC/owl54aROT/Xih/kNRdE/EBvei4ScpEWjNqFyonUma/zkPh/i/9JijxXHq?=
 =?us-ascii?Q?Da32F2AVEEr68orq7HSbrkK/GrQ+UkFsO3o9krf287P/dDj06WZcyNojdGbz?=
 =?us-ascii?Q?WZf7+nsdIxDmn3PTEPoJWneMyaIltP2wq+c3/IKyASsFdES69l4DtPPQn2lm?=
 =?us-ascii?Q?BhQs042EIYuFrZEcJRjE1r8uoyKGPYjEwZPL/qcful540vF6s8UmRKQSWks0?=
 =?us-ascii?Q?8WF9cuetmB7MqdM+usHxWGQS5wEo2W9TpH1sVp/7CJNedqCYb9iFnr6aYXfJ?=
 =?us-ascii?Q?J+E/YmDZ5mQ83QdJdruIB5BBLgSZ94yGLCjI1Rcn3y+/4sb36f4Mu0fWjJME?=
 =?us-ascii?Q?EBab8kv8+Y7C1sM2lFgaIsZLXurgSnhw5Y87vPaLMSF+LWxqffwrk7yXO3Jw?=
 =?us-ascii?Q?DoTV26Z0DxrMEfmLLYBOrswXJGMUUFUxq7hFkwoT3KBtlEo0R1Wsan/4ioAr?=
 =?us-ascii?Q?5Wq4AZy1u1WlAUify6V+zIBeb6oiFXbYUsI3qzf7HvEbZ9qvSdOciJ3RHUhm?=
 =?us-ascii?Q?aHyLHAxIG8ND3gtvcJlGzTyJG4A4umlhPuiXKyJLfGd+LlMfsOP53CyWMhea?=
 =?us-ascii?Q?RyYywlmY7YHCRQ6Qdf/kJqrkkayE980+8j2KZc+3fu+kr2cF1Hr878uSrLWK?=
 =?us-ascii?Q?B5SdRzxUYO+PreUQuxUDJdYwjVdmhI2Xn+L9bnnyNgSHHtdKT8jEfA6RuN9X?=
 =?us-ascii?Q?cFCVI8gNgOCFUYtAVacdHFeQ0D9puQvNjJjGACF0aLEKmpZ4r5rORvYizuve?=
 =?us-ascii?Q?aQNzWQy+QeynPivZDV2P6et7ya6/ceDImKjzGSy9zW1G88SnNfQtz1/Q6Wmh?=
 =?us-ascii?Q?iPN8Mzr3kPMyC4iXqK7fIBMUBPy0ndyPtonsjHxyAto0jbVjJ47cxPPG3nH4?=
 =?us-ascii?Q?u9iR61tmkA3v67mrjUGz8lISYoGJcdVLRz9jt7K4hjSFWNh6SHgYJ70ye5l3?=
 =?us-ascii?Q?9xfWOl8TM9nBYaw1L1enffr1eZsiRFnGaX3UYnaZuMBTiieUOQ05Iu7tO1M0?=
 =?us-ascii?Q?j27a8XaZBBWUffWIeKaH3u53/y8vfVXMzSwUI9UlYcxGeiUsKMsQN4X4oLGX?=
 =?us-ascii?Q?2ej77Q3NYTPUXXaYj9Bhw7O6E72t52jr5bXy0uyYT3kGkbYcKPXLezvhqdCW?=
 =?us-ascii?Q?PnAVipYQ+P8/cB8u3p2/zcSBb9G2O6mwhw/laav7O+xfoSNvuMr9XljHb7/o?=
 =?us-ascii?Q?1eNTBxK+3Y9V+YOASwc2t/FANWQXkDP5inirNnoGNnimQ7H8abWWWFvcYI0Y?=
 =?us-ascii?Q?ARv1slfSnr5NNu+jIBoR81oxHfp2OHAyBCZM0YY44Ejg2LW5PJyUjx8QFYiO?=
 =?us-ascii?Q?P3O5z6OEcS0xLTpqCSfPh4R35u0INK8/gS3bcPOF?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a8d9974d-d008-42e5-1242-08db71381452
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB6780.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2023 02:43:07.8555
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: p7mdGYDl2bo/ka509HsSK6pM50himyYnGN7mxSVKmwmZipFv5Bp7sh6RN2BIHKBV5paoZk113FD2l6spEI7Jgw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6870
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 16, 2023 at 10:38:15AM +0800, Yan Zhao wrote:
>For KVM_X86_QUIRK_CD_NW_CLEARED, remove the ignore PAT bit in EPT memory
>types when cache is disabled and non-coherent DMA are present.
>
>With the quirk KVM_X86_QUIRK_CD_NW_CLEARED, WB + IPAT are returned as the
>EPT memory type when guest cache is disabled before this patch.
>Removing the IPAT bit in this patch will allow effective memory type to
>honor PAT values as well, which will make the effective memory type

Given guest sets CR0.CD, what's the point of honoring (guest) PAT? e.g.,
which guests can benefit from this change?

>stronger than WB as WB is the weakest memtype. However, this change is
>acceptable as it doesn't make the memory type weaker,

>consider without
>this quirk, the original memtype for cache disabled is UC + IPAT.

This change impacts only the case where the quirk is enabled. Maybe you
mean:

_with_ the quirk, the original memtype for cached disabled is _WB_ + IPAT.


>
>Suggested-by: Sean Christopherson <seanjc@google.com>
>Signed-off-by: Yan Zhao <yan.y.zhao@intel.com>
>---
> arch/x86/kvm/vmx/vmx.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
>diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
>index 0ecf4be2c6af..c1e93678cea4 100644
>--- a/arch/x86/kvm/vmx/vmx.c
>+++ b/arch/x86/kvm/vmx/vmx.c
>@@ -7548,8 +7548,6 @@ static int vmx_vm_init(struct kvm *kvm)
> 
> static u8 vmx_get_mt_mask(struct kvm_vcpu *vcpu, gfn_t gfn, bool is_mmio)
> {
>-	u8 cache;
>-
> 	/* We wanted to honor guest CD/MTRR/PAT, but doing so could result in
> 	 * memory aliases with conflicting memory types and sometimes MCEs.
> 	 * We have to be careful as to what are honored and when.
>@@ -7576,11 +7574,10 @@ static u8 vmx_get_mt_mask(struct kvm_vcpu *vcpu, gfn_t gfn, bool is_mmio)
> 
> 	if (kvm_read_cr0_bits(vcpu, X86_CR0_CD)) {
> 		if (kvm_check_has_quirk(vcpu->kvm, KVM_X86_QUIRK_CD_NW_CLEARED))
>-			cache = MTRR_TYPE_WRBACK;
>+			return MTRR_TYPE_WRBACK << VMX_EPT_MT_EPTE_SHIFT;

Shouldn't KVM honor guest MTRRs as well? i.e., as if CR0.CD isn't set.

> 		else
>-			cache = MTRR_TYPE_UNCACHABLE;
>-
>-		return (cache << VMX_EPT_MT_EPTE_SHIFT) | VMX_EPT_IPAT_BIT;
>+			return (MTRR_TYPE_UNCACHABLE << VMX_EPT_MT_EPTE_SHIFT) |
>+				VMX_EPT_IPAT_BIT;
> 	}
> 
> 	return kvm_mtrr_get_guest_memory_type(vcpu, gfn) << VMX_EPT_MT_EPTE_SHIFT;
>-- 
>2.17.1
>