Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6c527e97-c4a6-dc58-13fb-516f77e5e068@oppo.com>
Date:   Tue, 20 Jun 2023 10:42:52 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [f2fs-dev][PATCH] f2fs: not allowed to set file both cold and hot
To:     Chao Yu <chao@kernel.org>, jaegeuk@kernel.org
Cc:     linux-f2fs-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org
References: <20230613085250.3648491-1-heyunlei@oppo.com>
 <b8523d41-246b-b11e-f6e3-423e32cc597a@kernel.org>
Content-Language: en-US
From:   =?UTF-8?B?5L2V5LqR6JW+KFl1bmxlaSBoZSk=?= <heyunlei@oppo.com>
In-Reply-To: <b8523d41-246b-b11e-f6e3-423e32cc597a@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NCsvV0IxZWIzWXdjNnhORWkzSGloUW4xVC9sTE56N3daNWtWb0RjL0dkRXo5?=
 =?utf-8?B?eitFL3o1SnJzUy9jVWMzRzlhOWZXL1dOTVJBYTFkc2NRM1VickxKWmVxZXdF?=
 =?utf-8?B?cGc1cjlUMkFtTXU2ejdnc3o4YlRpMHB1TVAzc0drakRqM3krR3pLZWQ1SHF4?=
 =?utf-8?B?amF2SDhEclFkMWI4bi80MlA1S0JLdU5HMGxLdHFEV1RrWjVtZDlwYzc5ZDhS?=
 =?utf-8?B?eWhtNDNlS2tDb1U2cnZhcUNveUZLYlR0am5pOGdJMk5zNEhLRFJ1NXkwNTZY?=
 =?utf-8?B?RnZoNWxBUEpWdHo3NFF6RFZzK0x1N0JudVpKdUFKSytzdWJuak1WdkUvY21q?=
 =?utf-8?B?dmpFNWNtelowQkE1TUJRYkFRS2tXTHp1a3NIVDlOMU5qSlczeHgzWTNBOGFO?=
 =?utf-8?B?VU50bDlWRmU4L2pFSXB3YUM5ZGV2OEZGNUJSMm4xa1lLY3Q3UURMZWYxOVVE?=
 =?utf-8?B?U3RMOFBPd2R1TGNyRnFwS2gzckU2VXZ6VHJPOUl1Vng1UHJvZGpFcXhzVHJw?=
 =?utf-8?B?djBTVEZsWEE4OUgzNElzZUR2QldJdmNKYmVWRklkdVNEK1VEb3lrWHVuc3NV?=
 =?utf-8?B?cGRDb25vNWYvRFVsa1ZVUlpIb25pRjFKQ09DTnI0eTBBcWZqY2tGdFh2U2Z3?=
 =?utf-8?B?WjRjazd3ZlNET0xxUHNydUpISWcxTkRmMTF3U2VpWFh4RXVKWXpLQm9vNWRt?=
 =?utf-8?B?eHhTSThhK0tCQ3RlL3RIRldBWHpTL0JiRlYwcEo0c3JQdmdXK2FObU9paXRv?=
 =?utf-8?B?eUM2UDk4Vnc0NkdQSzlUbU1kN092MGE1VjZHNFdtWmdQTHozRDJ1WnVJTjJk?=
 =?utf-8?B?QUl2UlVaSjdQVGI3dlB0WG5naUVnMS9hcGU5Y2Q4YnFPc2RCMDNwejZ5c2tk?=
 =?utf-8?B?S2pJdmloR0FFRkEweXZoWVpFSjViVlRRanc0dWJOWmRvMktzMmhIT0hkT1kr?=
 =?utf-8?B?VXYzMldRaFhWNXBQUS9nVXpRWHJ0OEdJNnJHWWxkbkpJb3dHOHhWRm1EWnhj?=
 =?utf-8?B?bEZPUzd1Y0Nmaks5N255K0V0R0wxbkJCaE5ya3RKZDROK1JtU3ExdDRQR3Bu?=
 =?utf-8?B?NEl1Zlczb0t2VGVkays1TGUwUHB2SW1qRlZNOExHSTErdmppaDU3MCs5SUo2?=
 =?utf-8?B?Rjh6eWdodUhFWkFCbnFJUjZyb1B0WTZNbXFWOFZnNWx4ZklZUjByaWdPdjRI?=
 =?utf-8?B?ZDlQZ0s3bzl4VmlybHFKY0JrYzdoZlZRSTg0ME14aHFSYXBFWGMvMFBDTnpi?=
 =?utf-8?B?TEpqKzM5dis4S0JHZURpNUpGclA0V2NqbkpSSTA2RTdNS0g1ZStUSTlkb1JS?=
 =?utf-8?B?V0s0WVNIZnJmOS9QWVIwZWdsRHVNQmQ1UjVVWVZJY1Z0VnUyRmp1Ums5ZlZO?=
 =?utf-8?B?TUoxZ21NM2pqWmdOYjMzVWZvZHBad1B0emhGcGJoRFVodjFrcTB0RlpFakZH?=
 =?utf-8?B?aXMySkxiVW1ZcGlxOUdsVnQ3TzFPTUM3M1hRZFd5N0VHa2tmaWkrTy9od01J?=
 =?utf-8?B?bXA0NGxKbXhhTUdjRjI1UnhLTTZWRDh1UXl6VUk3UkdyS0dLS3dwQ3RqSCs2?=
 =?utf-8?B?RmNRbUpjc0dWTnlRd2crMkc0cGZPUmZJSGVJZnkxRzlUWEV4cnRPYmh0Zk5X?=
 =?utf-8?B?NTg0NDJKWElRTlIzbFlwMGF3bFIzV3Jma2VWbGxwK2FTMHk4WEdGZms5aG8z?=
 =?utf-8?B?cnhGSlVaVXk0UWJQUU9kdW00RkIyWXRaQVZiUUI0NDdvUG9VenUvZDlqYzVY?=
 =?utf-8?B?VnVPMnRGeGJmcWhEL3hZdDJKVXBQMzRlYTdUdEFaVS93ajBVTzI3bGdoV2NZ?=
 =?utf-8?B?M3d0Z2k5SkRuVDI4aHBPUGEwcjVuMUZMYkErdEVpR2xIczR0bnJ3a21kS3hJ?=
 =?utf-8?B?ZDZGM015cnBDbGluN2JHK25uWHJxbUptQmErUnpNUm82KzM1eDlicDRJUDhy?=
 =?utf-8?B?bk9ta1FuQ01FbzNMT2dKYXp1cndYbFp2TFFhMVAyT2wvcEsxWEYzZ3gvSGRF?=
 =?utf-8?B?ZFp1UDFXN01qajdjM3VCa3owWG9mWnhOY0lWejNSV3pSZGczNk1maHV5ak9T?=
 =?utf-8?B?MlZFdjFMMHRzajVvcVlhS2h5QjlUWmFjSjlKa1dkNEl1dnd6cU55eXZBSDRE?=
 =?utf-8?Q?p4s6OgjYgPywud4y665zDlqD5?=
X-OriginatorOrg: oppo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c399f8a6-4702-44d0-ebd5-08db71380ee8
X-MS-Exchange-CrossTenant-AuthSource: TY2PR02MB4479.apcprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2023 02:42:58.6909
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f1905eb1-c353-41c5-9516-62b4a54b5ee6
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tzyJiKJZnv005Rp4hSK3WC/1WLENzRVBCc/hjuGECn24FC3jqdRq3TUWCjhvMvmYfDOM3jWMzQ3NUtyZOcMuJw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR02MB4499
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2023/6/20 8:33, Chao Yu wrote:
> On 2023/6/13 16:52, Yunlei He wrote:
>> File set both cold and hot advise bit is confusion, so
>> return EINVAL to avoid this case.
>>
>> Signed-off-by: Yunlei He <heyunlei@oppo.com>
>> ---
>>   fs/f2fs/xattr.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/fs/f2fs/xattr.c b/fs/f2fs/xattr.c
>> index 213805d3592c..917f3ac9f1a1 100644
>> --- a/fs/f2fs/xattr.c
>> +++ b/fs/f2fs/xattr.c
>> @@ -127,6 +127,9 @@ static int f2fs_xattr_advise_set(const struct 
>> xattr_handler *handler,
>>                  return -EINVAL;
>>
>>          new_advise = new_advise & FADVISE_MODIFIABLE_BITS;
>> +       if ((new_advise & FADVISE_COLD_BIT) && (new_advise & 
>> FADVISE_HOT_BIT))
>> +               return -EINVAL;
>
> Yunlei,
>
> What about the below case:
>
> 1. f2fs_xattr_advise_set(FADVISE_COLD_BIT)
> 2. f2fs_xattr_advise_set(FADVISE_HOT_BIT)

Hi,  Chao,

     I test this case work well with this patch,  case below will return 
-EINVAL:

     f2fs_xattr_advise_set(FADVISE_COLD_BIT | FADVISE_HOT_BIT)

Thanks,

>
> Thanks,
>
>> +
>>          new_advise |= old_advise & ~FADVISE_MODIFIABLE_BITS;
>>
>>          F2FS_I(inode)->i_advise = new_advise;
>> --