Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <638b32ce-d2a8-2686-dda1-26abb0778bae@linux.alibaba.com>
Date:   Tue, 20 Jun 2023 11:43:29 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.11.2
Subject: Re: [PATCH] ACPI: APEI: mark some functions __init
To:     Miaohe Lin <linmiaohe@huawei.com>, rafael@kernel.org
Cc:     lenb@kernel.org, james.morse@arm.com, tony.luck@intel.com,
        bp@alien8.de, linux-acpi@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230617080708.2002287-1-linmiaohe@huawei.com>
Content-Language: en-US
From:   Shuai Xue <xueshuai@linux.alibaba.com>
In-Reply-To: <20230617080708.2002287-1-linmiaohe@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2023/6/17 16:07, Miaohe Lin wrote:
> hest_esrc_len() and apei_hest_parse() are only called inside __init
> section. So mark them __init too.

Hi, Miaohe,

should ghes_estatus_pool_init also be marked with __init?

Thanks.

Best Regards,
Shuai


> 
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
>  drivers/acpi/apei/hest.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/acpi/apei/hest.c b/drivers/acpi/apei/hest.c
> index 6aef1ee5e1bd..2d78e808ab8b 100644
> --- a/drivers/acpi/apei/hest.c
> +++ b/drivers/acpi/apei/hest.c
> @@ -55,7 +55,7 @@ static inline bool is_generic_error(struct acpi_hest_header *hest_hdr)
>  	       hest_hdr->type == ACPI_HEST_TYPE_GENERIC_ERROR_V2;
>  }
>  
> -static int hest_esrc_len(struct acpi_hest_header *hest_hdr)
> +static int __init hest_esrc_len(struct acpi_hest_header *hest_hdr)
>  {
>  	u16 hest_type = hest_hdr->type;
>  	int len;
> @@ -88,7 +88,7 @@ static int hest_esrc_len(struct acpi_hest_header *hest_hdr)
>  
>  typedef int (*apei_hest_func_t)(struct acpi_hest_header *hest_hdr, void *data);
>  
> -static int apei_hest_parse(apei_hest_func_t func, void *data)
> +static int __init apei_hest_parse(apei_hest_func_t func, void *data)
>  {
>  	struct acpi_hest_header *hest_hdr;
>  	int i, rc, len;