Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Wu, Wentong" <wentong.wu@intel.com>
To:     Mark Brown <broonie@kernel.org>, "Ye, Xiang" <xiang.ye@intel.com>
CC:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Matthias Kaehlcke <mka@chromium.org>,
        Lee Jones <lee@kernel.org>, Wolfram Sang <wsa@kernel.org>,
        Tyrone Ting <kfting@nuvoton.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Marc Zyngier <maz@kernel.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
        "Pandruvada, Srinivas" <srinivas.pandruvada@intel.com>,
        "heikki.krogerus@linux.intel.com" <heikki.krogerus@linux.intel.com>,
        "andriy.shevchenko@linux.intel.com" 
        <andriy.shevchenko@linux.intel.com>,
        "sakari.ailus@linux.intel.com" <sakari.ailus@linux.intel.com>,
        "Wang, Zhifeng" <zhifeng.wang@intel.com>,
        "Zhang, Lixu" <lixu.zhang@intel.com>
Subject: RE: [PATCH v8 6/6] spi: Add support for Intel LJCA USB SPI driver
Thread-Topic: [PATCH v8 6/6] spi: Add support for Intel LJCA USB SPI driver
Thread-Index: AQHZhDKg97ejfzr1I0O8sOr9dAI1ka9WCSqAgD1x13A=
Date:   Tue, 20 Jun 2023 06:47:11 +0000
Message-ID: <DM6PR11MB4316E9530309ACCEF55AD0D18D5CA@DM6PR11MB4316.namprd11.prod.outlook.com>
References: <20230511175844.185070-1-xiang.ye@intel.com>
 <20230511175844.185070-7-xiang.ye@intel.com>
 <ZF2+C0CqaBff2hl+@finisterre.sirena.org.uk>
In-Reply-To: <ZF2+C0CqaBff2hl+@finisterre.sirena.org.uk>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?EjwoCM1oMaOliPs6b9l45GGCneE5jHAO/ZOKgDcdGwqMPr0M5PicGdMntDPM?=
 =?us-ascii?Q?ULV3t3dCMkBeZbHFbqwKfX67y37wLS3OH/vptAJa0sU5Nl2MJzGk24Nzbnns?=
 =?us-ascii?Q?WyLhyGj8zKzd6QnYF1T8hq6seLR+kqbkpcJjl1QEEbfHZhCCj8rHOF6osmJj?=
 =?us-ascii?Q?ZqUwEU8E33gqvG7Urqzk9Jrq3Ed+zJfLgBtbYmAGrYOGXNipiGiL9lDUSY7X?=
 =?us-ascii?Q?ASObO7OjfrgK6HxHS+9OPBXWtlarVkZIX7CYYV5StLVugDzdoZymRnxDEyIo?=
 =?us-ascii?Q?luXyk7DgF4gJCT7EXGZ+sVheEXikglfP7eX8Oy+EDDEZ77sWtQTFBj69EqTW?=
 =?us-ascii?Q?VkUb0OLoaji+FlBi+gr7pdn6KXCYsD5x3rdAZfA4yLmcKXf/Wr2MbdWdhp1X?=
 =?us-ascii?Q?NIEw3cel9rabsAxQsRacjzaibgN4pqGACfq854+tY1lLo+FYwzinDg2g7lCH?=
 =?us-ascii?Q?QIXb0Y8eUfJSrUmWkyF6qD7YDj9e+Tmyox3rJVjJxAH++Dxi5W/acubCRflD?=
 =?us-ascii?Q?bnSZ+vIoK2ma+Ce9z+i7wmbAwuwPRvBPr2gFJOtfr2SCsJKYaC2NwGXsj94z?=
 =?us-ascii?Q?51BX0Ogf3C8Sen1HIwLxAbHTv47LDo45KFN5bCo20djUvIMDAwgsjcbc4MHN?=
 =?us-ascii?Q?+PgISZxjdAWJCogTGy/pu2UKrbpYPoA87Fze3meyDeChZK3or2Ss6e4llEvz?=
 =?us-ascii?Q?vE5rF68PmmqVHFqiYYv5aTHd+HU/6ECEIAr+dc82wRDiYIsNFHZ06Zk96CfY?=
 =?us-ascii?Q?HHdS15dTb88g7NV7/leGkA4g95opfLArUY3NUfqK40aRXK4Vmt5B6YBDfp9O?=
 =?us-ascii?Q?CQ1QXKUD4751EJfER4gDep/vjv6UGZ5932ohq/fBOqIOVkiNaQjCQXZwOd75?=
 =?us-ascii?Q?2jEerSQmYCv0DstCsGnvOsHvSaNxYizpalqyY4CTdlgYd3yvmSoQ+Eo6YMSg?=
 =?us-ascii?Q?mQSsfxbQgUSjqOoMrSBZn/W5AnAHFUFb0KwKWgckpC/60V9MjTj5pXpJ9yXa?=
 =?us-ascii?Q?hcNNjZspF8HfIfiuAEMV7Y8enYa/CBYITWBIca0qePi2WZ67OTUxaYMrDRIl?=
 =?us-ascii?Q?6djU/wXII5LNa50xv4elae28V/QDspTjEDPysaq4XbJxooTpqHmLYjfE8rCY?=
 =?us-ascii?Q?rCscEqKGGpBdjH9mVjH/QhrlKrTEw7uX9OIHUMFCh4dZgXarxvPYsIL1I8cU?=
 =?us-ascii?Q?nv+hiw6PB27dLT8DufFOAvqj698+aRsWiY4a5juJ8EKJPB0sI/eaVJqR51ow?=
 =?us-ascii?Q?Vchvrg612gsuYO6egFmcEAV4/yV8/BF4oT685otv0F+BWmFfZl9tYLp5y0Ge?=
 =?us-ascii?Q?V44gRAy8uEtJPBiuImesErEy9TX/7DWbwmgCHqD73vDQBkb4yblvdfyACfnV?=
 =?us-ascii?Q?w9Wi6KRZ03D5GFeJnU6gsqJAi5As2h55tuO8b2CxGxlT+8gK+i1kLG4c0Ou4?=
 =?us-ascii?Q?fzzDdMxDLu6AtpImDOtf/ow622CLK4HnybelpYrnXjyxyxAFlzqlEawOiMm+?=
 =?us-ascii?Q?FHTFynA3zN7wHjs+6KO/aisXlOMJhyeHumAjiI/EDTqjIRH4zn96Y8U934fm?=
 =?us-ascii?Q?Y6M5RHTJyeAzz+JoyRKspD3NrOXaZFG638LDxGPS?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4316.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 13f02b5b-04fe-4a6b-915c-08db715a2cae
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jun 2023 06:47:11.3639
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5X0adbBe6LeZEmxvmC8uipShB2U0c4beCYa7elVtGw8xE69ch5i+jbYgwzhB8DCHSvR1phLYr7TCNL35k9aQ/g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7887
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Brown,

Thanks for your review

> -----Original Message-----
> From: Mark Brown <broonie@kernel.org>
> Sent: Friday, May 12, 2023 12:18 PM
>=20
> On Fri, May 12, 2023 at 01:58:44AM +0800, Ye Xiang wrote:
>=20
> > +++ b/drivers/spi/spi-ljca.c
> > @@ -0,0 +1,290 @@
> > +// SPDX-License-Identifier: GPL-2.0-only
> > +/*
> > + * Intel La Jolla Cove Adapter USB-SPI driver
>=20
> Please make the entire comment a C++ one so things look more intentional.
>=20

I see lots of drivers are commenting like current one.=20
But sorry, you mean the entire comment start with /* and end with */ ? Than=
ks

BR,
Wentong

> > +struct spi_init_packet {
> > +	u8 index;
> > +	u8 speed;
> > +	u8 mode;
> > +} __packed;
> > +
> > +struct spi_xfer_packet {
>=20
> These should be namespaced, especially since they look likely to collide =
with
> other things.  Otherwise this looks fine.

Ack, these two structs will be like below in next version, thanks
struct ljca_spi_init_packet {
	u8 index;
	u8 index;
	u8 mode;
} __packed;

struct ljca_spi_xfer_packet {
	u8 indicator;
	s8 len;
	u8 data[];
} __packed;