Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cf6846ea-5bd0-0b41-b7e6-901c70701751@amd.com>
Date:   Tue, 20 Jun 2023 08:45:38 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH drm-next v5 03/14] drm: manager to keep track of GPUs VA
 mappings
Content-Language: en-US
To:     Danilo Krummrich <dakr@redhat.com>, airlied@gmail.com,
        daniel@ffwll.ch, tzimmermann@suse.de, mripard@kernel.org,
        corbet@lwn.net, bskeggs@redhat.com, Liam.Howlett@oracle.com,
        matthew.brost@intel.com, boris.brezillon@collabora.com,
        alexdeucher@gmail.com, ogabbay@kernel.org, bagasdotme@gmail.com,
        willy@infradead.org, jason@jlekstrand.net
Cc:     dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
        linux-doc@vger.kernel.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org,
        Donald Robson <donald.robson@imgtec.com>,
        Dave Airlie <airlied@redhat.com>
References: <20230620004217.4700-1-dakr@redhat.com>
 <20230620004217.4700-4-dakr@redhat.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20230620004217.4700-4-dakr@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YUxqdDl4U21EZmdQQ01GUW9LSHVaK0dCeUR0NkQrTnRuTHUvZXNZTVNtUTk1?=
 =?utf-8?B?Y0hFM0pjSms3WDhPYU5TdDR1TWx0NWJYaDRjdHN6SEZxNlh3Vlk2T1F3QXZT?=
 =?utf-8?B?Z0F5ZFJ4d0ZSNFlMcUMxS2V2S1VlYTNHSUlGN04zclFTQ28zZjFySG1DZ3dG?=
 =?utf-8?B?Rlp2dVZQVDJKWkJBVCtOdE1PVzBQTGNkSXB0d1I4b3I1c3k1Rys4UHJQM0Vq?=
 =?utf-8?B?ZzVZa3BrMWZlRVZQUDVuTmdDWDF5N2lta0JmMVh5bVFnYnhvaG1CMGlvVCtB?=
 =?utf-8?B?QmljQ3AxbVA2U3JaS1VlcDVGSk5ONzBySWttMGF3RVFQTlVLajl4Tkx5elRu?=
 =?utf-8?B?NDJZRi9mL1FmcGhzcDJLcmkyNkNoaElwR0I3R25oOFhCdEdZUWtCSnVJcEVt?=
 =?utf-8?B?YkNBNVlGQUR6SlVxaXNITnlIaFFUNGpmZlhDOXpBd2kyQUhod29hSzZ5Sitn?=
 =?utf-8?B?bnkzbWY5RE9wTTRPOE1tczRDZCtXQ0t3QnJlWHlqZFNZalBSZ1FsYkFmSGFF?=
 =?utf-8?B?ai9aeHNUZ1Y1b3Y0aTZoT01SY1FaVDBxMGE1ZjFQMTd4Z3VmaWVnYmxmb0VQ?=
 =?utf-8?B?ejYxdFdrYlFzZGIzYlBWYzM0NXJlUXJFVExzcURGb0orVjg5NGttZ3pqNDgy?=
 =?utf-8?B?RmtZRzlhMW9ZMEdIUU9HSTBSL0NaVDFRc3l5TTBoMGZkdUVzM3FRZGxKM3Mz?=
 =?utf-8?B?U0NHMHVyUjlOL29adDdVNFpUY2dvTndSOUNZUmVYQVVnajRDZUlMaXRuSDNj?=
 =?utf-8?B?eGJBWVhhcTFndm5nYXhETnhYTHAwbWRIUUJCNkVWTnlnZnZDN1JmdEZTd2Ir?=
 =?utf-8?B?aXE5L0VPSEYxQkpNTjlGU01IR3NCSk95c3V2ODBUTVcxcHRSQVhqN1FmNE41?=
 =?utf-8?B?V1pURWY3dnBRV2FvWjlXWS9xVC9UbWs3dmxjT05Wc1B2ODJZRXF2RHRkWGxt?=
 =?utf-8?B?Unlybnhhb2tUWHNWZ1pyMTZUdy9MMWlxTHUvdHJKeC9GR2l4UUNIRSt0c3lR?=
 =?utf-8?B?Z2JZTHFld3FGN05GbXFXUzhkRUR0eUk5Z2RVYnR6aFlERG9QWlVaSXF6TzlB?=
 =?utf-8?B?S2k0MTNiWlJ1YzAzcTJ5bm1xNCtQU3YwMkJNSk9Gb2R2VVVTWWM4RURKaisy?=
 =?utf-8?B?bnRVNGx0ZkxTdTRLak9tbitSdlpYNVpnTzJjKytOaTgyNE5scCtpeDJuaC9t?=
 =?utf-8?B?cTBNQ3ZVcFc1cUx6WFRNMzNtbllnRFNCYnJZbUlwdHlvRjNKNGgzc0Nla3Vz?=
 =?utf-8?B?TkxyYmVwU1d6Sk5ZU1YwaXRlWG5QUnJBQjVNcllMV0hwRlVsODJSMkpyQUg2?=
 =?utf-8?B?SDhxUEdmT0VjTDF0UWJ1akxFM2h3R2tPTVdOWllWVXRvY1ZYZTBqNzVwVHhw?=
 =?utf-8?B?V3pKRzAxcSttRDhQbDBja2ZtZ0xWb1o2NU8vL2NDU1ZPQTdUOFFvbHZrQUpW?=
 =?utf-8?B?WTlrZHZMekZ4QXRKTDRwU0tkaEpWejJJQWZHTm1rM1g0SFQ0Z0k0ZE5tcWFX?=
 =?utf-8?B?Tjd1Q3h1ZFRWMzVQU0MwUVhGRHVsanZzZ0hIUXRiVlR3NjljcVVXMi9wckIy?=
 =?utf-8?B?L2RvZ0lRNE43eXpRWkE4Vnk0eC81ZzBpaFh2U01PZ3NvY1NyRUZhSVVYOGpX?=
 =?utf-8?B?L01Rb1oxc1VGSWtHV3dTNWV3cVBmSTVVbkl6SDFscU5ld01EYzdXL1VTbExH?=
 =?utf-8?B?TmJFL1ZMeGl2bTA0bXJXSVNOYmNYVDhMdjlWY2RTYi9ITkVROUJUa053bkpP?=
 =?utf-8?B?c3JuZnYwTkRZT0cwUmdPaDVvVURYOVNOUk0walo5Vk9yd0JGcTArdHpxelR1?=
 =?utf-8?B?Z0c1NmlySlp2TkZqUHR1MnVNZzVQYWpWamw0MEhSYnRTd205TEgwMjdmZm14?=
 =?utf-8?B?STU1T29Jck5PVVR3Rlovb0ZkYlpmZnU3MVdRNDcxTUdRS3hreHplZnVUWjRN?=
 =?utf-8?B?N1A1eFBUMkVkeUltMVBQOHhhR0hnR25Geks3ZGkwUE5MK05PVWdYY1VwUjRa?=
 =?utf-8?B?THJLZjk4d1pnWnVrMFIzSFFsRXF3cGczY1NBcWYzWmw2OVA5SS9zbHIvd0VX?=
 =?utf-8?B?amtyak5HZW9JMUZQUVlJbHVZZlIwaExvSS9SdkhsRW4wU3FHNFAxNXVQSWti?=
 =?utf-8?Q?DzH2icqrkSULk4QA62OKneTIz?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8c58ac4e-1b54-4ef0-7e05-08db7159f96d
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2023 06:45:45.7074
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uOvcmq9iNz0c4Y0irlKS7+fnH4/R06Wj/qaJ6dNUPmcz5QhEUkJ53mqzRy6Gxdp4
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6692
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Danilo,

sorry for the delayed reply. I've trying to dig myself out of a hole at 
the moment.

Am 20.06.23 um 02:42 schrieb Danilo Krummrich:
> [SNIP]
> diff --git a/include/drm/drm_gem.h b/include/drm/drm_gem.h
> index bbc721870c13..5ec8148a30ee 100644
> --- a/include/drm/drm_gem.h
> +++ b/include/drm/drm_gem.h
> @@ -36,6 +36,8 @@
>   
>   #include <linux/kref.h>
>   #include <linux/dma-resv.h>
> +#include <linux/list.h>
> +#include <linux/mutex.h>
>   
>   #include <drm/drm_vma_manager.h>
>   
> @@ -379,6 +381,18 @@ struct drm_gem_object {
>   	 */
>   	struct dma_resv _resv;
>   
> +	/**
> +	 * @gpuva:
> +	 *
> +	 * Provides the list of GPU VAs attached to this GEM object.
> +	 *
> +	 * Drivers should lock list accesses with the GEMs &dma_resv lock
> +	 * (&drm_gem_object.resv).
> +	 */
> +	struct {
> +		struct list_head list;
> +	} gpuva;
> +
>   	/**
>   	 * @funcs:
>   	 *

I'm pretty sure that it's not a good idea to attach this directly to the 
GEM object.

As you wrote in the commit message it's highly driver specific what to 
map and where to map it.

Instead I suggest to have a separate structure for mappings in a VA 
space which driver can then add to their GEM objects or whatever they 
want to map into their VMs.

Regards,
Christian.