Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e6c68580df0bb8441bf5beabfa978bfe15e0a39d.camel@maquefel.me>
Subject: Re: [PATCH v1 29/43] dt-bindings: rtc: Add ST M48T86
From:   Nikita Shubin <nikita.shubin@maquefel.me>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Alexander Sverdlin <alexander.sverdlin@gmail.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Linus Walleij <linus.walleij@linaro.org>,
        Alessandro Zummo <a.zummo@towertech.it>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc:     Michael Peters <mpeters@embeddedTS.com>,
        Kris Bahnsen <kris@embeddedTS.com>, linux-rtc@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Tue, 20 Jun 2023 10:30:54 +0300
In-Reply-To: <a2b286a5-32c1-213d-49df-129f2d94d771@linaro.org>
References: <20230424123522.18302-1-nikita.shubin@maquefel.me>
         <20230601054549.10843-11-nikita.shubin@maquefel.me>
         <a2b286a5-32c1-213d-49df-129f2d94d771@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.3 
MIME-Version: 1.0
Precedence: bulk

Hello Krzysztof!

On Thu, 2023-06-01 at 10:18 +0200, Krzysztof Kozlowski wrote:
> On 01/06/2023 07:45, Nikita Shubin wrote:
> > Add YAML bindings for ST M48T86 / Dallas DS12887 RTC.
> >=20
> > Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>
> > ---
> >=20
> > Notes:
> > =C2=A0=C2=A0=C2=A0 v0 -> v1:
> > =C2=A0=C2=A0=C2=A0=20
> > =C2=A0=C2=A0=C2=A0 - s/dallas/st/
> > =C2=A0=C2=A0=C2=A0 - description for regs
> > =C2=A0=C2=A0=C2=A0 - s/additionalProperties/unevaluatedProperties/
> > =C2=A0=C2=A0=C2=A0 - add ref rtc.yaml
> > =C2=A0=C2=A0=C2=A0 - changed compatible to st,m48t86
> > =C2=A0=C2=A0=C2=A0 - dropped label in example
> > =C2=A0=C2=A0=C2=A0 - replaced Alessandro Alessandro to Alexandre Bellon=
i
> >=20
> > =C2=A0.../bindings/rtc/st,m48t86-rtc.yaml=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 38
> > +++++++++++++++++++
> > =C2=A01 file changed, 38 insertions(+)
> > =C2=A0create mode 100644
> > Documentation/devicetree/bindings/rtc/st,m48t86-rtc.yaml
> >=20
> > diff --git a/Documentation/devicetree/bindings/rtc/st,m48t86-
> > rtc.yaml b/Documentation/devicetree/bindings/rtc/st,m48t86-rtc.yaml
> > new file mode 100644
> > index 000000000000..eb8e6451d7c8
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/rtc/st,m48t86-rtc.yaml
>=20
> Filename based on compatible, so drop "rtc".
>=20
> > @@ -0,0 +1,38 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/rtc/st,m48t86-rtc.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: ST M48T86 / Dallas DS12887 RTC wirh SRAM
>=20
> typo: with
>=20
> > +
> > +maintainers:
> > +=C2=A0 - Alexandre Belloni <alexandre.belloni@bootlin.com>
> > +
> > +properties:
> > +=C2=A0 compatible:
> > +=C2=A0=C2=A0=C2=A0 enum:
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - st,m48t86
> > +
> > +=C2=A0 reg:
> > +=C2=A0=C2=A0=C2=A0 items:
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - description: index register
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - description: data register
> > +
> > +allOf:
> > +=C2=A0 - $ref: rtc.yaml
> > +
> > +unevaluatedProperties: false
> > +
> > +required:
> > +=C2=A0 - compatible
> > +=C2=A0 - reg
>=20
> required goes after properties:
>=20
> Keep the same order in all your patches.
>=20
> > +
> > +examples:
> > +=C2=A0 - |
> > +=C2=A0=C2=A0=C2=A0 rtc@10800000 {
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 compatible =3D "st,m48t86";
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 reg =3D <0x10800000 0x1>, <0x11700000 0=
x1>;
>=20
> One byte long? Not a word?

They are indeed one byte long:

https://elixir.bootlin.com/linux/v6.4-rc7/source/drivers/rtc/rtc-m48t86.c#L=
46

>=20
> > +=C2=A0=C2=A0=C2=A0 };
> > +
> > +...
>=20
> Best regards,
> Krzysztof
>=20