Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Li, Xin3" <xin3.li@intel.com>
To:     Peter Zijlstra <peterz@infradead.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "platform-driver-x86@vger.kernel.org" 
        <platform-driver-x86@vger.kernel.org>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
        "linux-perf-users@vger.kernel.org" <linux-perf-users@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "bp@alien8.de" <bp@alien8.de>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "hpa@zytor.com" <hpa@zytor.com>,
        "steve.wahl@hpe.com" <steve.wahl@hpe.com>,
        "mike.travis@hpe.com" <mike.travis@hpe.com>,
        "Sivanich, Dimitri" <dimitri.sivanich@hpe.com>,
        "Anderson, Russ" <russ.anderson@hpe.com>,
        "dvhart@infradead.org" <dvhart@infradead.org>,
        "andy@infradead.org" <andy@infradead.org>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
        "will@kernel.org" <will@kernel.org>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "kys@microsoft.com" <kys@microsoft.com>,
        "haiyangz@microsoft.com" <haiyangz@microsoft.com>,
        "wei.liu@kernel.org" <wei.liu@kernel.org>,
        "Cui, Dexuan" <decui@microsoft.com>,
        "dwmw2@infradead.org" <dwmw2@infradead.org>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
        "acme@kernel.org" <acme@kernel.org>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>,
        "alexander.shishkin@linux.intel.com" 
        <alexander.shishkin@linux.intel.com>,
        "jolsa@kernel.org" <jolsa@kernel.org>,
        "namhyung@kernel.org" <namhyung@kernel.org>,
        "irogers@google.com" <irogers@google.com>,
        "Hunter, Adrian" <adrian.hunter@intel.com>,
        "Christopherson,, Sean" <seanjc@google.com>,
        "jiangshanlai@gmail.com" <jiangshanlai@gmail.com>,
        "jgg@ziepe.ca" <jgg@ziepe.ca>,
        "yangtiezhu@loongson.cn" <yangtiezhu@loongson.cn>
Subject: RE: [PATCH 2/3] x86/vector: Replace IRQ_MOVE_CLEANUP_VECTOR with a
 timer callback
Thread-Topic: [PATCH 2/3] x86/vector: Replace IRQ_MOVE_CLEANUP_VECTOR with a
 timer callback
Thread-Index: AQHZowfgzs/ltzhQV02KS6H0RArmlq+TSWeAgAAE1kA=
Date:   Tue, 20 Jun 2023 07:47:27 +0000
Message-ID: <SA1PR11MB67340612B7984EADA4CF5461A85CA@SA1PR11MB6734.namprd11.prod.outlook.com>
References: <20230619231611.2230-1-xin3.li@intel.com>
 <20230619231611.2230-3-xin3.li@intel.com>
 <20230620072047.GS4253@hirez.programming.kicks-ass.net>
In-Reply-To: <20230620072047.GS4253@hirez.programming.kicks-ass.net>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vBlsi7c8Z8zaZntO6c9CzeG5P510qJtmFkMKRgVK1SZEG7kqcJ+Ch1zNqzRZ?=
 =?us-ascii?Q?Vbc4XIyJrKUXXjAuTy7jEqD+N3SNmCwnoLd2F6iK2lHaS6UfCUSueFvqPvfd?=
 =?us-ascii?Q?IMWLUhvVn1/iz9AekpTpoQxJBtfICEJNuVwG9YlyMI7NVyKzFoQK2caOH/p6?=
 =?us-ascii?Q?qBwE7+7VcVQW1cWPzgwyRgJs507ZwziwRqI/zBbBwNHmJKZXs9dTh5UnpSVv?=
 =?us-ascii?Q?CLbB2MqZ0tp/uKNhzHVvOohAHrCKlDagGi9TkfjVygBuX4DZHvHGoGUD3JhW?=
 =?us-ascii?Q?bkYJZGeEBGBKudt6IlRxhu76Bwdf5Uu5vcVUO2mOMcU9vfEc+0bM8wTlGty1?=
 =?us-ascii?Q?jtE4ntbtV2Wpxapt5lIFtwZVhSZ9Z9LJqPwjZI/pwtuz5uDTyaJBxH+fX3vt?=
 =?us-ascii?Q?NSS7X45fDoVtdBLS8ixbYXcU+DisxF+qSRBC2tm4f3lUFOrgoTCDWBoNiZyR?=
 =?us-ascii?Q?DYUFlQFYNyQOZfXf0qvCRBAZQUtK2nkWhfzwR9g/mcRClBsK8No1lyPB0EgL?=
 =?us-ascii?Q?7U4LxIrCGhh7e5xoU+zXRgJp0qKcc3G06WkTD/fNncVTHh7zE4wp6nDZlQpt?=
 =?us-ascii?Q?11o4tZ48rKosYyTRBMNqyJmIF0pkapiiRYAQLxM/oo/aAjT38pHfEhh2k9gO?=
 =?us-ascii?Q?fqy5q1f5Vwtvo2n+eDVah3uIRSZ3Q7cdG29L9YjCJVwm/g2Ki3JkhBQ7c8RD?=
 =?us-ascii?Q?Std/UwlmtiRiMNJ1dyarjA6ksLND9y+39zMJQfZRSm6NuqosYP/0yAX1b7m5?=
 =?us-ascii?Q?AUh9YhWr39OvpC72evzB0+W6+xfhDIfgusS8CY73mCtTLz2jF98YNkfug/Mn?=
 =?us-ascii?Q?9Ka496je0uocUzNAJhv/U9PFy4nDMaYSzXdK7e/lreQin0H+saNW3Y5l//+t?=
 =?us-ascii?Q?j5i6KplkAcRiC/+FxSDp/WPzLnTcvmNZOdx0DmHOdoZd2E2YbQ7ZLA4iDz+n?=
 =?us-ascii?Q?mZUNlGHbK5qtD3EWwWdavlPrZJwlZMQ1DICrmL2qUvJV+URlTjXo+CEz84pW?=
 =?us-ascii?Q?nH7IZpwOGx8Evm9DmkXYFuwHkfpuxi8mMGrmGA/lHDSRLjTPI5EdZjQvFYPg?=
 =?us-ascii?Q?iBsSJsxLP9k8ZBg4WhIvt4zTrjlsCj9ArjF9V0DDp/HGQtUOErMFgJo2ezzF?=
 =?us-ascii?Q?BGBxTR2ytyLpFq6dz7B+1EKkC8w8V+MqkyyHwzeJvwdmCaJSFq+YmGqTEIG1?=
 =?us-ascii?Q?b+pyfjtb5K8AIU18m0TqwJtz7MV8KHem4A93RRnj8v+bUVf1BmulSwyQbJVm?=
 =?us-ascii?Q?6sITa/jGqvT/iCbw1v2vbwnYaCg7LM1Cbrft7/Kkan7GzQmiO+YbdLkrWwLX?=
 =?us-ascii?Q?KIoTfPJDlruDvBaKlCvhRx8jthRlq7/1uvLCf4vyr/LcYz1WoYBkBzapaS4/?=
 =?us-ascii?Q?iac3PU07WJOZ6zZEVF0DAKihR+2bODAADcsLMPoaSr5ZpvAcgc4ptggYej1i?=
 =?us-ascii?Q?0qDaqgErisPJRFP3nNXLj1ZeZa9UEgXMx8CYOi92dWZIWXtpmDlOkOJ7VzQD?=
 =?us-ascii?Q?XqWBmnMx9DjwcI/J+H+Ux4AJG3VUQm4JuWFK8tIDCCj0IIKCvNShA6keaQno?=
 =?us-ascii?Q?fd5LZGQz0faAxavvQxI=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6734.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aae76458-ade4-4f68-8aa7-08db71629828
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jun 2023 07:47:27.5981
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Bl1Rc+yY6SuX62odDsvZNx5gsYgnhxQb+4zXBonOExCdOa5JPHwWdANLKfYkyg5GM0RhpOtpTm2WI5ILtF1WVg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5796
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > +/*
> > + * Called with vector_lock held
> > + */
>=20
> Instead of comments like that, I tend to add a lockdep_assert*() statemen=
t to the
> same effect. Which unlike comment actually validate the claim and since i=
t's code
> it tends to not go stale like comments do.

neat, will do!

> > +	bool rearm =3D false;
>=20
> 	lockdep_assert_held(&vector_lock);

My bad, didn't notice that quite a few functions in the file already do tha=
t.=20