Return-Path: <linux-kernel-owner+w=401wt.eu-S1763420AbXJRKiF@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1763420AbXJRKiF (ORCPT <rfc822;w@1wt.eu>);
	Thu, 18 Oct 2007 06:38:05 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756356AbXJRKht
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Thu, 18 Oct 2007 06:37:49 -0400
Received: from mtagate3.de.ibm.com ([195.212.29.152]:47542 "EHLO
	mtagate3.de.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756228AbXJRKhr (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 18 Oct 2007 06:37:47 -0400
Subject: Re: s390x: getting ipv6 bugs on mainline since 2.6.23-git3
From: Martin Schwidefsky <schwidefsky@de.ibm.com>
Reply-To: schwidefsky@de.ibm.com
To: Patrick McHardy <kaber@trash.net>
Cc: Andy Whitcroft <apw@shadowen.org>, linux390@de.ibm.com,
       linux-s390@vger.kernel.org, netdev@vger.kernel.org,
       linux-kernel@vger.kernel.org,
       Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
In-Reply-To: <47172AD5.2030009@trash.net>
References: <20071018093556.GT21136@shadowen.org>
	 <47172AD5.2030009@trash.net>
Content-Type: text/plain; charset=ISO-8859-1
Organization: IBM Corporation
Date: Thu, 18 Oct 2007 12:37:44 +0200
Message-Id: <1192703864.13572.3.camel@localhost>
Mime-Version: 1.0
X-Mailer: Evolution 2.12.0 
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2115
Lines: 60


On Thu, 2007-10-18 at 11:43 +0200, Patrick McHardy wrote:
> Andy Whitcroft wrote:
> > Seems we are getting some kind of bug out of our s390x partition (lnxabat1)
> > when booting latest mainline releases, specifically since 2.6.23-git3.
> > 
> > Kernel BUG at 0000000000000002 ?verbose debug info unavailable?
> > illegal operation: 0001 ?#1?
> Which network driver are you using? Please post the output of
> "ip link list <dev>".

This is a bug in the qeth driver. It has been introduced by this commit:

commit 3b04ddde02cf1b6f14f2697da5c20eca5715017f
Author: Stephen Hemminger <shemminger@linux-foundation.org>
Date:   Tue Oct 9 01:40:57 2007 -0700

    [NET]: Move hardware header operations out of netdevice.

    Since hardware header operations are part of the protocol class
    not the device instance, make them into a separate object and
    save memory.

    Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>

I've hacked up a fix for it. The real fix will be done by our networking
people.

-- 
blue skies,
  Martin.

"Reality continues to ruin my life." - Calvin.

---

 drivers/s390/net/qeth_main.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff -urpN linux-2.6/drivers/s390/net/qeth_main.c linux-2.6-patched/drivers/s390/net/qeth_main.c
--- linux-2.6/drivers/s390/net/qeth_main.c	2007-10-17 15:05:36.000000000 +0200
+++ linux-2.6-patched/drivers/s390/net/qeth_main.c	2007-10-17 15:05:46.000000000 +0200
@@ -6643,7 +6643,8 @@ qeth_netdev_init(struct net_device *dev)
 	dev->vlan_rx_kill_vid = qeth_vlan_rx_kill_vid;
 	dev->vlan_rx_add_vid = qeth_vlan_rx_add_vid;
 #endif
-	dev->header_ops = &qeth_null_ops;
+	if (qeth_get_netdev_flags(card) & IFF_NOARP)
+		dev->header_ops = &qeth_null_ops;
 
 #ifdef CONFIG_QETH_IPV6
 	/*IPv6 address autoconfiguration stuff*/


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/