Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 20 Jun 2023 09:26:57 +0100
From:   Conor Dooley <conor.dooley@microchip.com>
To:     Guo Samin <samin.guo@starfivetech.com>
CC:     Andrew Lunn <andrew@lunn.ch>, Conor Dooley <conor@kernel.org>,
        <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <netdev@vger.kernel.org>, Peter Geis <pgwipeout@gmail.com>,
        Frank <Frank.Sae@motor-comm.com>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        Yanhong Wang <yanhong.wang@starfivetech.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: net: motorcomm: Add pad driver
 strength cfg
Message-ID: <20230620-clicker-antivirus-99e24a06954e@wendy>
References: <20230526090502.29835-1-samin.guo@starfivetech.com>
 <20230526090502.29835-2-samin.guo@starfivetech.com>
 <20230526-glutinous-pristine-fed571235b80@spud>
 <1dbf113c-7592-68bd-6aaf-05ff1d8c538c@starfivetech.com>
 <15eb4ffe-ea12-9a2c-ae9d-c34860384b60@starfivetech.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="NvJVgXFV5BWCi8Zi"
Content-Disposition: inline
In-Reply-To: <15eb4ffe-ea12-9a2c-ae9d-c34860384b60@starfivetech.com>
Precedence: bulk

--NvJVgXFV5BWCi8Zi
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hey,

On Tue, Jun 20, 2023 at 11:09:52AM +0800, Guo Samin wrote:
> From: Guo Samin <samin.guo@starfivetech.com>
> > From: Conor Dooley <conor@kernel.org>
> >> On Fri, May 26, 2023 at 05:05:01PM +0800, Samin Guo wrote:
> >>> The motorcomm phy (YT8531) supports the ability to adjust the drive
> >>> strength of the rx_clk/rx_data, the value range of pad driver
> >>> strength is 0 to 7.

> >>> +  motorcomm,rx-clk-driver-strength:
> >>> +    description: drive strength of rx_clk pad.
> >>> +    $ref: /schemas/types.yaml#/definitions/uint32
> >>> +    enum: [ 0, 1, 2, 3, 4, 5, 6, 7 ]
> >>
> >> I think you should use minimum & maximum instead of these listed out
> >> enums.

> >  You have also had this comment since v1 & were reminded of it on
> >> v2 by Krzysztof: "What do the numbers mean? What are the units? mA?"

> > The good news is that we just got some data about units from Motorcomm.=
=20
> > Maybe I can post the data show of the unit later after I get the comple=
te data.

> Sorry, haven't updated in a while.

NW chief.

> I just got the detailed data of Driver Strength(DS) from Motorcomm , whic=
h applies to both rx_clk and rx_data.
>=20
> |----------------------|
> |     ds map table     |
> |----------------------|
> | DS(3b) | Current (mA)|
> |--------|-------------|
> |   000  |     1.20    |
> |   001  |     2.10    |
> |   010  |     2.70    |
> |   011  |     2.91    |
> |   100  |     3.11    |
> |   101  |     3.60    |
> |   110  |     3.97    |
> |   111  |     4.35    |
> |--------|-------------|
>=20
> Since these currents are not integer values and have no regularity,
> it is not very good to use in the drive/dts in my opinion.

Who says you have to use mA? What about uA?

> Therefore, I tend to continue to use DS(0-7) in dts/driver, and adding
> a description of the current value corresponding to DS in dt-bindings.=20

I think this goes against not putting register values into the dts &
that the accurate description of the hardware are the currents.

> Like This:
>=20
> +  motorcomm,rx-clk-driver-strength:
> +    description: drive strength of rx_clk pad.

You need "description: |" to preserve the formatting if you add tables,
but I don't think that this is a good idea. Put the values in here that
describe the hardware (IOW the currents) and then you don't need to have
this table.

> +      |----------------------|
> +      | rx_clk ds map table  |
> +      |----------------------|
> +      | DS(3b) | Current (mA)|
> +      |   000  |     1.20    |
> +      |   001  |     2.10    |
> +      |   010  |     2.70    |
> +      |   011  |     2.91    |
> +      |   100  |     3.11    |
> +      |   101  |     3.60    |
> +      |   110  |     3.97    |
> +      |   111  |     4.35    |
> +      |--------|-------------|
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    enum: [ 0, 1, 2, 3, 4, 5, 6, 7 ]
> +    default: 3
> +

> Or use minimum & maximum instead of these listed out enums

With the actual current values, enum rather than min + max.

Cheers,
Conor.

--NvJVgXFV5BWCi8Zi
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZJFi0QAKCRB4tDGHoIJi
0jkZAQD0AdtEo8r1ss1UMAX71qHvpw4XtFiP6Xp6aLVVVsyKfwEAzivJCNzTBl+1
IBDsXO2BNofaxXz2KLZ8JtK/8Lp0vww=
=+VHM
-----END PGP SIGNATURE-----

--NvJVgXFV5BWCi8Zi--