Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230615063333.4030395-1-perry.yuan@amd.com> <CAJZ5v0hMEuiv71RoEfyBJ_Z83AvMWXfEvt9kBU2SmZyXvKSx4w@mail.gmail.com>
 <6973890d-3366-0fdb-6306-77a763a979d5@amd.com>
In-Reply-To: <6973890d-3366-0fdb-6306-77a763a979d5@amd.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Tue, 20 Jun 2023 11:23:21 +0200
Message-ID: <CAJZ5v0hw7eCAE+5NVyc_D=qriK21kZ8aJFOD0G4MBr0qjMLfUA@mail.gmail.com>
Subject: Re: [PATCH v2 4/4] cpufreq: intel_pstate: Use the acpi_pm_profile_server()
 symbol
To:     Mario Limonciello <mario.limonciello@amd.com>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Perry Yuan <perry.yuan@amd.com>, rafael.j.wysocki@intel.com,
        viresh.kumar@linaro.org, Ray.Huang@amd.com, Deepak.Sharma@amd.com,
        Wyes.Karny@amd.com, gautham.shenoy@amd.com, Sunpeng.Li@amd.com,
        Xinmei.Huang@amd.com, Xiaojian.Du@amd.com, Li.Meng@amd.com,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Mon, Jun 19, 2023 at 4:53 AM Mario Limonciello
<mario.limonciello@amd.com> wrote:
>
> On 6/15/23 10:57, Rafael J. Wysocki wrote:
> > On Thu, Jun 15, 2023 at 8:35 AM Perry Yuan <perry.yuan@amd.com> wrote:
> >>
> >> From: Mario Limonciello <mario.limonciello@amd.com>
> >>
> >> Avoid duplication of functionality by using the generic symbol.
> >> This does have a functional change that intel-pstate will now
> >> match "SOHO server" as well.
> >
> > And why do you think that it is a good idea to change this behavior?
>
> The idea was to cover all possible server types. It seemed that it could
> be an oversight that it wasn't included initially.
>
> Is that not the case and it is "intentionally" not including "SOHO server"?

Yes, it is.