Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 20 Jun 2023 11:29:06 +0200
From:   Borislav Petkov <bp@alien8.de>
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     LKML <linux-kernel@vger.kernel.org>, x86@kernel.org,
        Mario Limonciello <mario.limonciello@amd.com>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Tony Battersby <tonyb@cybernetics.com>,
        Ashok Raj <ashok.raj@linux.intel.com>,
        Tony Luck <tony.luck@intel.com>,
        Arjan van de Veen <arjan@linux.intel.com>,
        Eric Biederman <ebiederm@xmission.com>,
        Ashok Raj <ashok.raj@intel.com>
Subject: Re: [patch v3 6/7] x86/smp: Split sending INIT IPI out into a helper
 function
Message-ID: <20230620092906.GXZJFxYpyR2Sf9PM84@fat_crate.local>
References: <20230615190036.898273129@linutronix.de>
 <20230615193330.551157083@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20230615193330.551157083@linutronix.de>
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Jun 15, 2023 at 10:33:58PM +0200, Thomas Gleixner wrote:
> Putting CPUs into INIT is a safer place during kexec() to park CPUs.
>=20
> Split the INIT assert/deassert sequence out so it can be reused.
>=20
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Reviewed-by: Ashok Raj <ashok.raj@intel.com>
> ---
> V2: Fix rebase screwup
> ---
>  arch/x86/kernel/smpboot.c |   49 ++++++++++++++++++-------------------=
---------
>  1 file changed, 20 insertions(+), 29 deletions(-)
>=20
> --- a/arch/x86/kernel/smpboot.c
> +++ b/arch/x86/kernel/smpboot.c
> @@ -853,47 +853,38 @@ wakeup_secondary_cpu_via_nmi(int apicid,
>  	return (send_status | accept_status);
>  }
> =20
> -static int
> -wakeup_secondary_cpu_via_init(int phys_apicid, unsigned long start_eip=
)
> +static void send_init_sequence(int phys_apicid)
>  {
> -	unsigned long send_status =3D 0, accept_status =3D 0;
> -	int maxlvt, num_starts, j;
> -
> -	maxlvt =3D lapic_get_maxlvt();
> +	int maxlvt =3D lapic_get_maxlvt();

Whoops:

arch/x86/kernel/smpboot.c: In function =E2=80=98send_init_sequence=E2=80=99=
:
arch/x86/kernel/smpboot.c:860:9: warning: ISO C90 forbids mixed declarati=
ons and code [-Wdeclaration-after-statement]
  860 |         int maxlvt =3D lapic_get_maxlvt();
      |         ^~~

--=20
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette