Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763206AbXJRK50 (ORCPT ); Thu, 18 Oct 2007 06:57:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756048AbXJRK5M (ORCPT ); Thu, 18 Oct 2007 06:57:12 -0400 Received: from brick.kernel.dk ([87.55.233.238]:4240 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756126AbXJRK5K (ORCPT ); Thu, 18 Oct 2007 06:57:10 -0400 Date: Thu, 18 Oct 2007 12:56:33 +0200 From: Jens Axboe To: Ingo Molnar Cc: Jeff Garzik , Linus Torvalds , linux-kernel@vger.kernel.org, Alan Cox Subject: Re: [bug] ata subsystem related crash with latest -git Message-ID: <20071018105633.GU5063@kernel.dk> References: <471720FE.4090004@garzik.org> <20071018091706.GO5063@kernel.dk> <4717281B.6070301@garzik.org> <20071018094128.GP5063@kernel.dk> <47172FB1.5020704@garzik.org> <20071018100959.GQ5063@kernel.dk> <20071018101348.GA29296@elte.hu> <20071018101650.GR5063@kernel.dk> <20071018101739.GS5063@kernel.dk> <20071018104910.GA9658@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071018104910.GA9658@elte.hu> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 819 Lines: 24 On Thu, Oct 18 2007, Ingo Molnar wrote: > > * Jens Axboe wrote: > > > > It would always be nice. For this case I don't think it's very > > > interesting, if we pursue the improved sg iteration setup. > > > > BTW, I think it's pretty clear that ata_sg_is_last() is broken. It's > > likely a one-off in the n_iter test. > > fixing that would be a -stable candidate, as a potential data corruptor > - or is it more benign? I think it's safe to say that it was sg chaining introduced breakage, so it should work fine in 2.6.23.x. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/