Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f068e601-52ec-2dbf-d117-4164863d58ab@linaro.org>
Date:   Tue, 20 Jun 2023 11:57:37 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH] dt-bindings: timer: add Ralink SoCs timer documentation
Content-Language: en-US
To:     Sergio Paracuellos <sergio.paracuellos@gmail.com>
Cc:     devicetree@vger.kernel.org, daniel.lezcano@linaro.org,
        tglx@linutronix.de, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, linux-kernel@vger.kernel.org
References: <20230620093409.1411399-1-sergio.paracuellos@gmail.com>
 <9b0d5439-24dd-2c32-f13a-110f758591fb@linaro.org>
 <CAMhs-H9L0GybDOdmx5_RCw-=PaO3DYUOZPswiRErRRg5Fi57tQ@mail.gmail.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <CAMhs-H9L0GybDOdmx5_RCw-=PaO3DYUOZPswiRErRRg5Fi57tQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 20/06/2023 11:51, Sergio Paracuellos wrote:
>>> +  reg:
>>> +    maxItems: 1
>>> +
>>> +  clocks:
>>> +    maxItems: 1
>>> +
>>> +  clock-names:
>>> +    const: timer
>>
>> Names matching the module name are not really helpful, so drop it,
>> unless any existing user needs it.
> 
> I am ok with dropping this. If you meant with an existing user
> something that is already mainlined in the kernel tree then I would

Yes.

> say there is no need for this 'clock-names'. I don't know about other
> places since these SoCs are pretty old and almost with nothing
> documented. I am doing the effort of trying to document all the stuff
> before porting some openWRT device tree files to the kernel (this
> timer driver is already included in 'arch/mips/ralink' so I am
> documenting already in-tree things). So I guess I should send v2
> removing this?

Yes, please.

Best regards,
Krzysztof