Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b945c89b-c3d2-089d-e592-9495cdf8feb3@starfivetech.com>
Date:   Tue, 20 Jun 2023 18:09:35 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH v2 0/5] Add support for external dphy
Content-Language: en-US
To:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Maxime Ripard <mripard@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>
CC:     <linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <changhuang.liang@starfivetech.com>
References: <20230523085626.3295-1-jack.zhu@starfivetech.com>
From:   Jack Zhu <jack.zhu@starfivetech.com>
In-Reply-To: <20230523085626.3295-1-jack.zhu@starfivetech.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2023/5/23 16:56, Jack Zhu wrote:
> This series adds support for external D-PHY and JH7110 SoC which has a Cadence
> MIPI-CSI2 RX controller. The driver is tested on VisionFive V2 board.
> 

Hi everyone,

For this new version of patch, could you please help to review and give your comments? 
Thanks a lot!

> PLEASE NOTE: this patch series was spun off from the v4 of another series that
> included CSI and ISP driver. You can check the comments for earlier version in
> the link below. I'm sorry that the first version link has been lost.
> 
> v4 link: https://lore.kernel.org/all/20230413035541.62129-1-jack.zhu@starfivetech.com/
> v3 link: https://lore.kernel.org/all/20230331121826.96973-1-jack.zhu@starfivetech.com/
> v2 link: https://lore.kernel.org/all/20230310120553.60586-1-jack.zhu@starfivetech.com/
> 
> Current review status:
>   - cdns,csi2rx.yaml:
>       Reviewed by: Krzysztof Kozlowski
>       Reviewed by: Laurent Pinchart
>   - cdns-csi2rx.c
>       Reviewed by: Laurent Pinchart
>   - MAINTAINERS
>       Reviewed by: Krzysztof Kozlowski
>       Reviewed by: Laurent Pinchart
> 
> Thanks to everyone who reviewed my work !
> 
> Changes in v2:
> - Matched reset names in bindings.
> 
> v1 link: https://lore.kernel.org/all/20230512102637.50917-1-jack.zhu@starfivetech.com/
> 
> Jack Zhu (5):
>   media: dt-bindings: cadence-csi2rx: Convert to DT schema
>   media: dt-bindings: cadence-csi2rx: Add resets property
>   media: cadence: Add operation on reset
>   media: cadence: Add support for external dphy
>   media: cadence: Add support for JH7110 SoC
> 
>  .../devicetree/bindings/media/cdns,csi2rx.txt | 100 ---------
>  .../bindings/media/cdns,csi2rx.yaml           | 201 ++++++++++++++++++
>  MAINTAINERS                                   |   1 +
>  drivers/media/platform/cadence/cdns-csi2rx.c  | 107 ++++++++--
>  4 files changed, 294 insertions(+), 115 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/media/cdns,csi2rx.txt
>  create mode 100644 Documentation/devicetree/bindings/media/cdns,csi2rx.yaml
>