Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230612030321.3097627-1-perry.yuan@amd.com>
In-Reply-To: <20230612030321.3097627-1-perry.yuan@amd.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Tue, 20 Jun 2023 12:19:35 +0200
Message-ID: <CAJZ5v0isvR-cKN7x7THEN_sbzdNYUMNXx9OVwgif_TQ0tYgvoA@mail.gmail.com>
Subject: Re: [PATCH v2] cpufreq: amd-pstate: Set default governor to schedutil
To:     Perry Yuan <perry.yuan@amd.com>
Cc:     rafael.j.wysocki@intel.com, viresh.kumar@linaro.org,
        Ray.Huang@amd.com, Mario.Limonciello@amd.com,
        Deepak.Sharma@amd.com, Wyes.Karny@amd.com, gautham.shenoy@amd.com,
        Sunpeng.Li@amd.com, Xinmei.Huang@amd.com, Xiaojian.Du@amd.com,
        Li.Meng@amd.com, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Mon, Jun 12, 2023 at 5:04 AM Perry Yuan <perry.yuan@amd.com> wrote:
>
> From: Mario Limonciello <mario.limonciello@amd.com>
>
> The Kconfig currently defaults the governor to schedutil on x86_64
> only when intel-pstate and SMP have been selected.
>
> If the kernel is built only with amd-pstate, the default governor
> should also be schedutil.
>
> Cc: Sun Peng (Leo) Li <sunpeng.li@amd.com>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> Reviewed-by: Leo Li <sunpeng.li@amd.com>
> Acked-by: Huang Rui <ray.huang@amd.com>
> Tested-by: Perry Yuan <Perry.Yuan@amd.com>
> ---
>  drivers/cpufreq/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
> index 2c839bd2b051..a1c51abddbc5 100644
> --- a/drivers/cpufreq/Kconfig
> +++ b/drivers/cpufreq/Kconfig
> @@ -38,7 +38,7 @@ choice
>         prompt "Default CPUFreq governor"
>         default CPU_FREQ_DEFAULT_GOV_USERSPACE if ARM_SA1110_CPUFREQ
>         default CPU_FREQ_DEFAULT_GOV_SCHEDUTIL if ARM64 || ARM
> -       default CPU_FREQ_DEFAULT_GOV_SCHEDUTIL if X86_INTEL_PSTATE && SMP
> +       default CPU_FREQ_DEFAULT_GOV_SCHEDUTIL if (X86_INTEL_PSTATE || X86_AMD_PSTATE) && SMP
>         default CPU_FREQ_DEFAULT_GOV_PERFORMANCE
>         help
>           This option sets which CPUFreq governor shall be loaded at
> --

Applied as 6.5 material, thanks!