Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp7624566rwd; Tue, 20 Jun 2023 04:07:12 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5Aoxw8JNLRUaq20Bxq5hwc8R1MuKPt21mEnpEkyVs+iMEIosE9PRTLEh7WIpBgFn3tTh8W X-Received: by 2002:a05:6a20:8e19:b0:121:3cdd:dd17 with SMTP id y25-20020a056a208e1900b001213cdddd17mr6376180pzj.6.1687259231852; Tue, 20 Jun 2023 04:07:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687259231; cv=none; d=google.com; s=arc-20160816; b=bJAMX9rrj3AmolTG4pzUb2G80PhAu+8E0tQKWZfeEbuBUU9iJoxuYRa/fgFp8FEZrn zBR/Ry6FmGidnl6vm6vWotQtF92GkpAr5UMWeu3OkPBUAFamWboVNVcMp5QdIkckC72Z 1D91WViHGMk5FWabvAItKofEL3rmVbIIMO0rGgp+owDh9W8SjufmvkC+8MDsj1aOh05e s5tV9+OdDV8m8IvzCF/nuQx1QQXXSuCsBR2vY3sNDeC3tzOWEkGE1pZhkfc4De4Ch1E1 Xf+zeSe0Zn6z4Sx21PHWSPXlWfU6KjMgZp+4yLsQmqi6eYIWc1mLVR3ZGU7+yA7T5nt7 N1vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=RbhGpsDAomrPFtOzOx10SN9nZPJqLIDxZxrdMydjsJM=; b=X2opVs3Qx/ixqls2ycesLx42xlwkSPfp9o1PEact/Xnn65D92P35jG9rLN9q8xT2Kk SuF/f7KnHq3HYX1T6ydbCyiAF0yUpr+GnlPsxo3pPq5krjyR9fBY6ihtmk0RHTRZV3lx uIUhbKLKVGhME0BoWwpYZm02f7kZelXdITMRa/NUik6u7rgbmxhmwwTSbn9KwEGxivmu 6Xw8ZsaAsqHlO6W2f50egdrJ7pt1vbWu9cp9n0nMUe/+qy6wvcCFkcmljSHOuO365xA+ Fp6gSp6wev9ktUDCckmK7UWc8wW81eAD5PhU6ULCq7HMi+j+Kx5+4MC76YNDEAXiDj3P Oi8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=b+eGa0lK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a202-20020a621ad3000000b0065d56d5e7a9si1468013pfa.123.2023.06.20.04.06.54; Tue, 20 Jun 2023 04:07:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=b+eGa0lK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232022AbjFTKgi (ORCPT + 99 others); Tue, 20 Jun 2023 06:36:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229519AbjFTKgf (ORCPT ); Tue, 20 Jun 2023 06:36:35 -0400 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37483CE for ; Tue, 20 Jun 2023 03:36:35 -0700 (PDT) Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-668723729c5so1533136b3a.3 for ; Tue, 20 Jun 2023 03:36:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1687257394; x=1689849394; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=RbhGpsDAomrPFtOzOx10SN9nZPJqLIDxZxrdMydjsJM=; b=b+eGa0lKSuFUzxgtRZSELw7suVQ1VHVWXY+MrktaA1eOIixFyVS5s4pVVDYG8ERWgP ctbRvH9jgxHBxGCIyQSI8CFjA5VOgPk+yp8udL7LSI5FhrLJ5RTEijHWbxvglOhcojCi fQIw7m4kwJUO7YmhnMpsts4aokpidZhpu4gEU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687257394; x=1689849394; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RbhGpsDAomrPFtOzOx10SN9nZPJqLIDxZxrdMydjsJM=; b=DP+fKDyS9MsVk901+Os0CgicpGIgkaM+/rgRx+RlYPseytBPsJZl4ysy/MUTjfQHAP erHZe19yt9hMMhe29hSkSgmGgRmoA2mcN72IGmo4wtO2RSdB4MSxCxQPJrLyq4qDh6Mq QPXUakIbbF811VexS6wDdgGggFbJ2QBKn4Zt3rdGC+W9Nlt98GBB8c0T3EoorxkIriam HVbg6TSagrDIN9HciPTZPbVDG8WBrx6/fHfwf3Wrdix1na+Vaml8jAWUL9kREQPhjr3q r2NGVXsBTnG6pvsTfn5doqbpAkUkiE+SOYNxr3TGJXq9LWODKkQsatNqD5aU+vEM++g7 Pzcg== X-Gm-Message-State: AC+VfDwaC5WFTonF1QVg8e3ZEa5ln3TQVOIQuIB+IzkbYCpnFa1VIldH bGSyAAzfCeLGq6qp4Frrvy2pVg== X-Received: by 2002:a05:6a00:1504:b0:668:9735:573c with SMTP id q4-20020a056a00150400b006689735573cmr1678585pfu.15.1687257394671; Tue, 20 Jun 2023 03:36:34 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:b84a:9c37:6b9:859b]) by smtp.gmail.com with ESMTPSA id c12-20020aa78e0c000000b0063f2a5a59d1sm1073475pfr.190.2023.06.20.03.36.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jun 2023 03:36:34 -0700 (PDT) Date: Tue, 20 Jun 2023 19:36:29 +0900 From: Sergey Senozhatsky To: Alexey Romanov Cc: minchan@kernel.org, senozhatsky@chromium.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel@sberdevices.ru Subject: Re: [PATCH v1 1/2] zsmalloc: add allocated objects counter for subpage Message-ID: <20230620103629.GA42985@google.com> References: <20230619143506.45253-1-avromanov@sberdevices.ru> <20230619143506.45253-2-avromanov@sberdevices.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230619143506.45253-2-avromanov@sberdevices.ru> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FSL_HELO_FAKE, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (23/06/19 17:35), Alexey Romanov wrote: > > We use a variable of type unsigned int to store the offset > of the first object at the subpage In turn, the offset cannot > exceed the size of PAGE_SIZE, which is usually 4096. Thus, > 12 bits are enough to store the offset. [..] > If the page size is 4Kb It's certainly not a given. PAGE_SIZE is architecture specific. PAGE_SIZE_16KB and PAGE_SIZE_64KB would be simple examples, but there are, apparently, architectures that even can have PAGE_SIZE_256KB.