Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e30082535f1d7e92692718f1d25a08508f04fe0a.camel@gmail.com>
Subject: Re: [PATCH v2 2/5] ext4: No need to check return value of
 block_commit_write()
From:   Bean Huo <huobean@gmail.com>
To:     Christoph Hellwig <hch@infradead.org>, Bean Huo <beanhuo@iokpp.de>
Cc:     viro@zeniv.linux.org.uk, brauner@kernel.org,
        akpm@linux-foundation.org, jack@suse.cz, jack@suse.com,
        tytso@mit.edu, adilger.kernel@dilger.ca, mark@fasheh.com,
        jlbec@evilplan.org, joseph.qi@linux.alibaba.com,
        linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com,
        beanhuo@micron.com
Date:   Tue, 20 Jun 2023 12:59:42 +0200
In-Reply-To: <ZJEvi8CJddmpeluC@infradead.org>
References: <20230619211827.707054-1-beanhuo@iokpp.de>
         <20230619211827.707054-3-beanhuo@iokpp.de> <ZJEvi8CJddmpeluC@infradead.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu1 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2023-06-19 at 21:48 -0700, Christoph Hellwig wrote:
> On Mon, Jun 19, 2023 at 11:18:24PM +0200, Bean Huo wrote:
> > From: Bean Huo <beanhuo@micron.com>
> >=20
> > Remove unnecessary check on the return value of
> > block_commit_write(),
> > because it always returns 0.
>=20
> Dropping the error check before the function signature is changes is
> really odd.=C2=A0 I'd suggest to merge this and the following patches int=
o
> a single one.

No problem, I will merge them together, thanks.

Kind regards,
Bean