Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762936AbXJRLhx (ORCPT ); Thu, 18 Oct 2007 07:37:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756300AbXJRLhm (ORCPT ); Thu, 18 Oct 2007 07:37:42 -0400 Received: from cerber.ds.pg.gda.pl ([153.19.208.18]:44830 "EHLO cerber.ds.pg.gda.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755974AbXJRLhl (ORCPT ); Thu, 18 Oct 2007 07:37:41 -0400 Date: Thu, 18 Oct 2007 12:37:33 +0100 (BST) From: "Maciej W. Rozycki" To: Jarek Poplawski cc: Andy Fleming , Andrew Morton , Jeff Garzik , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes In-Reply-To: <20071018063157.GA1694@ff.dom.local> Message-ID: References: <20071015125301.GC3015@ff.dom.local> <20071016062108.GB1000@ff.dom.local> <20071017085809.GA1658@ff.dom.local> <20071018063157.GA1694@ff.dom.local> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 700 Lines: 18 On Thu, 18 Oct 2007, Jarek Poplawski wrote: > After rethinking, it looks like this last cancel should be useless. > So, if phy_interrupt() schedules only if !PHY_HALTED and phy_change() > does enable_irq() with no exeptions, it seems phy_interrupt() even > without lock must see PHY_HALTED state before this free_irq() with > possible DEBUG_SHIRQ call, then maybe only this safety: > > WARN_ON(work_pending(&phydev->phy_queue)); Good point. Maciej - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/