Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Borislav Petkov <bp@alien8.de>
Cc:     LKML <linux-kernel@vger.kernel.org>, x86@kernel.org,
        Mario Limonciello <mario.limonciello@amd.com>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Tony Battersby <tonyb@cybernetics.com>,
        Ashok Raj <ashok.raj@linux.intel.com>,
        Tony Luck <tony.luck@intel.com>,
        Arjan van de Veen <arjan@linux.intel.com>,
        Eric Biederman <ebiederm@xmission.com>,
        Ashok Raj <ashok.raj@intel.com>
Subject: Re: [patch v3 6/7] x86/smp: Split sending INIT IPI out into a
 helper function
In-Reply-To: <20230620092906.GXZJFxYpyR2Sf9PM84@fat_crate.local>
References: <20230615190036.898273129@linutronix.de>
 <20230615193330.551157083@linutronix.de>
 <20230620092906.GXZJFxYpyR2Sf9PM84@fat_crate.local>
Date:   Tue, 20 Jun 2023 14:30:45 +0200
Message-ID: <878rce8gei.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Jun 20 2023 at 11:29, Borislav Petkov wrote:
> On Thu, Jun 15, 2023 at 10:33:58PM +0200, Thomas Gleixner wrote:
>>=20=20
>> -static int
>> -wakeup_secondary_cpu_via_init(int phys_apicid, unsigned long start_eip)
>> +static void send_init_sequence(int phys_apicid)
>>  {
>> -	unsigned long send_status =3D 0, accept_status =3D 0;
>> -	int maxlvt, num_starts, j;
>> -
>> -	maxlvt =3D lapic_get_maxlvt();
>> +	int maxlvt =3D lapic_get_maxlvt();
>
> Whoops:
>
> arch/x86/kernel/smpboot.c: In function =E2=80=98send_init_sequence=E2=80=
=99:
> arch/x86/kernel/smpboot.c:860:9: warning: ISO C90 forbids mixed declarati=
ons and code [-Wdeclaration-after-statement]
>   860 |         int maxlvt =3D lapic_get_maxlvt();
>       |         ^~~

How so? It's the first thing in the function, no?

And in the other hunk it's _before_ code too.

Conflict resolution artifact?

Thanks,

        tglx