Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 20 Jun 2023 20:58:01 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     "Karny, Wyes" <Wyes.Karny@amd.com>
Cc:     "rafael@kernel.org" <rafael@kernel.org>,
        "viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
        "trenn@suse.com" <trenn@suse.com>,
        "shuah@kernel.org" <shuah@kernel.org>,
        "Shenoy, Gautham Ranjal" <gautham.shenoy@amd.com>,
        "Limonciello, Mario" <Mario.Limonciello@amd.com>,
        "Yuan, Perry" <Perry.Yuan@amd.com>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/6] cpupower: Add EPP value change support
Message-ID: <ZJGiWegN+CctWQBV@amd.com>
References: <20230612113615.205353-1-wyes.karny@amd.com>
 <20230612113615.205353-5-wyes.karny@amd.com>
 <ZIwNuRQK/mLTzfM1@amd.com>
 <ZIwlcvKCOVRyjstF@BLR-5CG13462PL.amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZIwlcvKCOVRyjstF@BLR-5CG13462PL.amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?oZ+UO/jt1xPOD5/LnkFPOwcTIlwALfd1d703FNJZpqnk+2I6lMizN8/YF+zJ?=
 =?us-ascii?Q?LdhTT7ld2cp7Z7bBjeIng/hMBbg2sTEaELxR6CxS8NYhLiXJlhDzLebOUKfG?=
 =?us-ascii?Q?Bwt8dvjC30+5YAud8pes9btyR2FGrERmJhDjaGzdBxViNLObVMWKJfSRnLBG?=
 =?us-ascii?Q?VxEJjTrE2GOcAtVF1eGZNeeHhBhkb71mYAomVU7TIdpCSHNHD87g7R9Kc1Ui?=
 =?us-ascii?Q?Ec/0u64gXjj9lfrpkzq39d5e+GEtM2dRNZ1rzaXJttJQA38s5iXz+p65doB/?=
 =?us-ascii?Q?cSgC2D4+AzdgWc/IuRwAKzngvD1yg3rq0P1FORJFK7PyqFx8FZ4MF3REIV9q?=
 =?us-ascii?Q?GwAtvaJrV2rytk6I/ihus8ZhbNKBGwb/VB1+/fSvj9uQXTgyLgGtInd0s0a1?=
 =?us-ascii?Q?xyWfTisP7PnzVx7ivvssbMTFHW3HneBx82gITusYSdrcyV11X6eEVP4k6zmR?=
 =?us-ascii?Q?s1toRjuKfXLpW7rbsouor6Roz/XkZTwKvSHqPfYfOmIfEoRP/Q8A4l18nPR+?=
 =?us-ascii?Q?IC3o2F47g9yE7DtlVATO/OepwiVHrhyj6w1e7IFoUAvqrp2qgXkofmDs9gFJ?=
 =?us-ascii?Q?LRWlPtBABlq4OtfzaoQ0KUI2P4ThaWrYuVle1qv8/WdC6HsRycpFMp5tlrEs?=
 =?us-ascii?Q?e0eqIN8K/DHxL8Y49kSxZQrVKMFPCqez+c7qOgvF6GYV+Km/+pLbZHcUPDpX?=
 =?us-ascii?Q?YwSnEzeljYZ4LbwYWLw6FKj+a4EKkvqUVcoPczMA7phgAU/OjHOHvJ50qA9T?=
 =?us-ascii?Q?BOANfVHBxsvN/LytmNyohxqnHIb70eRNpMh3nKuCCswA/sWz7gvDrIpH8SlI?=
 =?us-ascii?Q?igZECkYRRpTtgOdJ8iUsUwzD/sh05CvZ/dszHGKUJgq7TpTUvldGMX5Uo2mQ?=
 =?us-ascii?Q?yIUw3ysrYIh6P2Fb0tlUooHl4Wd5K+ROh2ZhXxsWolG/HqRME6Yh643BuLhD?=
 =?us-ascii?Q?J1EoRyjsAKBAzdwxeQ0yiQ+gnYj5Fu/sI3n+hn8+nlIDjwzWT9jX2xGqH+y+?=
 =?us-ascii?Q?nj+8m1HerrYGLuuYbYxw+eDH/xH7yPgc8A/TsHgjtmgCK4VtO5ZNROig4Evw?=
 =?us-ascii?Q?WD4AkscIyg3/jDEtTdD8kR2Nf9W83iPc8KqKb62QTOBAlBCxz6BM3391qJoR?=
 =?us-ascii?Q?fx8mUyKhp3iKL7jtg80+5c5AE9nh7zWS7pnIbDDmCd2pn5GkJ7d+5RCvCOSW?=
 =?us-ascii?Q?zJXIuF5Zs3tPM600RLm6SW3P4XA4t/aotANhQjB9DRDsADxHYQdipvmdwBtM?=
 =?us-ascii?Q?soIhIgvTz+j3+bztO4oJ677vV7Glpwy3nKo8kpxOBIhhm1tx8iDYfvkhELFM?=
 =?us-ascii?Q?OMAxLmQs8RteC1fRXaJPzjK25LMVOaePDPlIjeXc/aibYHcrdLZm880sGnfE?=
 =?us-ascii?Q?XaCBeJG+7xJP06k2cM7lZ2uNbK+Fs8//qVlEbYEdwFTD6On0SRwaUU6/r7DU?=
 =?us-ascii?Q?4Go1rP+OUI6lAV3vInzB+MrX9DXUXs2xoiJaowbdVvhV27K4+niqGapf8zjT?=
 =?us-ascii?Q?Ff6fvYrydVvdTbR3g5kIXrHUra0s8cEr2E+WmQ7PWrOS2n2lduQAvz/8dzVO?=
 =?us-ascii?Q?DukQZ8MzlcSwQJxPxoQxHVmN3PDQbF/xL3VvB0Py?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f9e53cfd-1a5c-4dc5-de8a-08db718e08f9
X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2504.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2023 12:58:25.4263
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lYR6a5qtAoQ0sFauzcKOY9sTwHw9cbrYVwJKlM9r35HCcAmszsuDBaLaN+JAj7TzbbX813RBEX7wR889bHHFvQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4361
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 16, 2023 at 05:03:46PM +0800, Karny, Wyes wrote:
> Hi Ray,
> 
> On 16 Jun 15:22, Huang Rui wrote:
> > On Mon, Jun 12, 2023 at 07:36:13PM +0800, Karny, Wyes wrote:
> > > amd_pstate and intel_pstate active mode drivers support energy
> > > performance preference feature. Through this user can convey it's
> > > energy/performance preference to platform. Add this value change
> > > capability to cpupower.
> > > 
> > > To change the EPP value use below command:
> > > cpupower set --epp performance
> > > 
> > > Signed-off-by: Wyes Karny <wyes.karny@amd.com>
> > > ---
> > >  tools/power/cpupower/utils/cpupower-set.c    | 23 +++++++++++++++++++-
> > >  tools/power/cpupower/utils/helpers/helpers.h |  5 +++++
> > >  tools/power/cpupower/utils/helpers/misc.c    | 19 ++++++++++++++++
> > >  3 files changed, 46 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/tools/power/cpupower/utils/cpupower-set.c b/tools/power/cpupower/utils/cpupower-set.c
> > > index 180d5ba877e6..a789b123dbd4 100644
> > > --- a/tools/power/cpupower/utils/cpupower-set.c
> > > +++ b/tools/power/cpupower/utils/cpupower-set.c
> > > @@ -18,6 +18,7 @@
> > >  
> > >  static struct option set_opts[] = {
> > >  	{"perf-bias", required_argument, NULL, 'b'},
> > > +	{"epp", required_argument, NULL, 'e'},
> > 
> > How about re-using the "perf-bias", I think it should be the simliar
> > function with Intel's processor?
> 
> AFAIU 'perf-bias' is not same as 'epp'. Perf-bias sysfs file expects
> 0-15 integer value, whereas epp sysfs file expects one of the string
> form energy_performance_available_preferences file.

I am thinking whether we can have a unify energy performance preferences
input in cpupower for both intel and amd processors. But it seems not easy
to align with them because different hardware interfaces here.

Anyway, it's not a big problem. Path looks good for me.

Thanks,
Ray

> 
> Thanks,
> Wyes
> > 
> > Thanks,
> > Ray
> > 
> > >  	{ },
> > >  };
> > >  
> > > @@ -37,11 +38,13 @@ int cmd_set(int argc, char **argv)
> > >  	union {
> > >  		struct {
> > >  			int perf_bias:1;
> > > +			int epp:1;
> > >  		};
> > >  		int params;
> > >  	} params;
> > >  	int perf_bias = 0;
> > >  	int ret = 0;
> > > +	char epp[30];
> > >  
> > >  	ret = uname(&uts);
> > >  	if (!ret && (!strcmp(uts.machine, "ppc64le") ||
> > > @@ -55,7 +58,7 @@ int cmd_set(int argc, char **argv)
> > >  
> > >  	params.params = 0;
> > >  	/* parameter parsing */
> > > -	while ((ret = getopt_long(argc, argv, "b:",
> > > +	while ((ret = getopt_long(argc, argv, "b:e:",
> > >  						set_opts, NULL)) != -1) {
> > >  		switch (ret) {
> > >  		case 'b':
> > > @@ -69,6 +72,15 @@ int cmd_set(int argc, char **argv)
> > >  			}
> > >  			params.perf_bias = 1;
> > >  			break;
> > > +		case 'e':
> > > +			if (params.epp)
> > > +				print_wrong_arg_exit();
> > > +			if (sscanf(optarg, "%29s", epp) != 1) {
> > > +				print_wrong_arg_exit();
> > > +				return -EINVAL;
> > > +			}
> > > +			params.epp = 1;
> > > +			break;
> > >  		default:
> > >  			print_wrong_arg_exit();
> > >  		}
> > > @@ -102,6 +114,15 @@ int cmd_set(int argc, char **argv)
> > >  				break;
> > >  			}
> > >  		}
> > > +
> > > +		if (params.epp) {
> > > +			ret = cpupower_set_epp(cpu, epp);
> > > +			if (ret) {
> > > +				fprintf(stderr,
> > > +					"Error setting epp value on CPU %d\n", cpu);
> > > +				break;
> > > +			}
> > > +		}
> > >  	}
> > >  	return ret;
> > >  }
> > > diff --git a/tools/power/cpupower/utils/helpers/helpers.h b/tools/power/cpupower/utils/helpers/helpers.h
> > > index 96e4bede078b..5d998de2d291 100644
> > > --- a/tools/power/cpupower/utils/helpers/helpers.h
> > > +++ b/tools/power/cpupower/utils/helpers/helpers.h
> > > @@ -116,6 +116,8 @@ extern int cpupower_intel_set_perf_bias(unsigned int cpu, unsigned int val);
> > >  extern int cpupower_intel_get_perf_bias(unsigned int cpu);
> > >  extern unsigned long long msr_intel_get_turbo_ratio(unsigned int cpu);
> > >  
> > > +extern int cpupower_set_epp(unsigned int cpu, char *epp);
> > > +
> > >  /* Read/Write msr ****************************/
> > >  
> > >  /* PCI stuff ****************************/
> > > @@ -173,6 +175,9 @@ static inline int cpupower_intel_get_perf_bias(unsigned int cpu)
> > >  static inline unsigned long long msr_intel_get_turbo_ratio(unsigned int cpu)
> > >  { return 0; };
> > >  
> > > +static inline int cpupower_set_epp(unsigned int cpu, char *epp)
> > > +{ return -1; };
> > > +
> > >  /* Read/Write msr ****************************/
> > >  
> > >  static inline int cpufreq_has_boost_support(unsigned int cpu, int *support,
> > > diff --git a/tools/power/cpupower/utils/helpers/misc.c b/tools/power/cpupower/utils/helpers/misc.c
> > > index 21f653cd472c..63c3f26ef874 100644
> > > --- a/tools/power/cpupower/utils/helpers/misc.c
> > > +++ b/tools/power/cpupower/utils/helpers/misc.c
> > > @@ -87,6 +87,25 @@ int cpupower_intel_set_perf_bias(unsigned int cpu, unsigned int val)
> > >  	return 0;
> > >  }
> > >  
> > > +int cpupower_set_epp(unsigned int cpu, char *epp)
> > > +{
> > > +	char path[SYSFS_PATH_MAX];
> > > +	char linebuf[30] = {};
> > > +
> > > +	snprintf(path, sizeof(path),
> > > +		PATH_TO_CPU "cpu%u/cpufreq/energy_performance_preference", cpu);
> > > +
> > > +	if (!is_valid_path(path))
> > > +		return -1;
> > > +
> > > +	snprintf(linebuf, sizeof(linebuf), "%s", epp);
> > > +
> > > +	if (cpupower_write_sysfs(path, linebuf, 30) <= 0)
> > > +		return -1;
> > > +
> > > +	return 0;
> > > +}
> > > +
> > >  bool cpupower_amd_pstate_enabled(void)
> > >  {
> > >  	char *driver = cpufreq_get_driver(0);
> > > -- 
> > > 2.34.1
> > >