Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ac065d02-61a4-3b1f-241d-443ede70d3f2@oracle.com>
Date:   Tue, 20 Jun 2023 07:56:55 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v2 02/13] x86/kexec: refactor for kernel/Kconfig.kexec
Content-Language: en-US
To:     Baoquan He <bhe@redhat.com>
Cc:     linux@armlinux.org.uk, catalin.marinas@arm.com, will@kernel.org,
        chenhuacai@kernel.org, geert@linux-m68k.org,
        tsbogend@alpha.franken.de, James.Bottomley@hansenpartnership.com,
        deller@gmx.de, ysato@users.sourceforge.jp, dalias@libc.org,
        glaubitz@physik.fu-berlin.de, tglx@linutronix.de, mingo@redhat.com,
        bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-ia64@vger.kernel.org, loongarch@lists.linux.dev,
        linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
        linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
        linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
        linux-sh@vger.kernel.org, kernel@xen0n.name, mpe@ellerman.id.au,
        npiggin@gmail.com, christophe.leroy@csgroup.eu,
        paul.walmsley@sifive.com, palmer@dabbelt.com,
        aou@eecs.berkeley.edu, hca@linux.ibm.com, gor@linux.ibm.com,
        agordeev@linux.ibm.com, borntraeger@linux.ibm.com,
        svens@linux.ibm.com, hpa@zytor.com, keescook@chromium.org,
        paulmck@kernel.org, peterz@infradead.org, frederic@kernel.org,
        akpm@linux-foundation.org, ardb@kernel.org,
        samitolvanen@google.com, juerg.haefliger@canonical.com,
        arnd@arndb.de, rmk+kernel@armlinux.org.uk,
        linus.walleij@linaro.org, sebastian.reichel@collabora.com,
        rppt@kernel.org, kirill.shutemov@linux.intel.com,
        anshuman.khandual@arm.com, ziy@nvidia.com, masahiroy@kernel.org,
        ndesaulniers@google.com, mhiramat@kernel.org, ojeda@kernel.org,
        thunder.leizhen@huawei.com, xin3.li@intel.com, tj@kernel.org,
        gregkh@linuxfoundation.org, tsi@tuyoix.net, hbathini@linux.ibm.com,
        sourabhjain@linux.ibm.com, boris.ostrovsky@oracle.com,
        konrad.wilk@oracle.com
References: <20230619145801.1064716-1-eric.devolder@oracle.com>
 <20230619145801.1064716-3-eric.devolder@oracle.com>
 <ZJFhlsFN6DxnWsQE@MiWiFi-R3L-srv>
From:   Eric DeVolder <eric.devolder@oracle.com>
In-Reply-To: <ZJFhlsFN6DxnWsQE@MiWiFi-R3L-srv>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TWxXTnRTOEJ1UEZRUnF6eThhNWlKUzhHeUJtci9SZzVzL1AyTU1OVXFEaHJv?=
 =?utf-8?B?bVN3UjhhOVM3bU5DRU4xc284MEhXNWtFbGpwZk5YV1JsQjJRZ245ZkdML25h?=
 =?utf-8?B?c2hvbitvc3JjTEdWdzVhMmY2K2p1QmxVeVpieEZtVXVNaWZnNUhCNmkzV0Ri?=
 =?utf-8?B?SnZEN2gyS3JFUHQ0TUhGbkoxV1Exd2ZHSVFTRHljcmVLSFRoQXpIcGlDMk82?=
 =?utf-8?B?YkQ3WWNtRFQ1Si9mOGhBbXhxZjVuZmhFeEZEN0YySzJ3OEQwQXpvSkFPUjh2?=
 =?utf-8?B?NDl2a3NDR2h0d3ozbzY2QVZ1Q1cwZGVmZ3lMUXBLa0hTazk3U3lXdkRlNWsz?=
 =?utf-8?B?NllkREFGeTEwYUFTeUhKS0VlQnl4WHdFSm1lYldYTkxyeWF1aThtT01ldDha?=
 =?utf-8?B?UkROZE9wVjJGR1l1TTJYMktvcHMxcUtWWVIwTXdXNnZsWnFrUkdwTUFzaDd6?=
 =?utf-8?B?emFhZHhQWUM3Z0RGQW11Y1FrVWgranBvM2JpeEV2RjZWZ3NqS3JZdEZiWk55?=
 =?utf-8?B?ZjhrR1dBejc5Z2RsOXExS21wc1RUbm5rTzZjWUo2Ry9EMHpDdVZqd0pHZUVh?=
 =?utf-8?B?U1VXZ25RVnpLN2s3cmVXZ0JoTEpqODZJUitDWCtveG9GU2RidGMwVEloRVRw?=
 =?utf-8?B?SnROalc4c2thUFFZc1E5eHZrckFlKy9CSGQybjlUQnNZMU9VU3ZNMDhHd0tG?=
 =?utf-8?B?NllVWjVhTzMyM2wrOGZHZmFRSHF4YUduZ3ZDTlVMS2tqSUhyZ2pDeXpiWGlT?=
 =?utf-8?B?eitIQ21iU0pBa25oay9xUUJPQjNzSzQrT1VmaGF0TG5JZ1U4L0ovUDRqbXZL?=
 =?utf-8?B?RUY0ejFZTjFYZXVVaHQyWjdDQ0FCU2UwNDVFUG4yd0h2MGhqN3BFWEZIS3lX?=
 =?utf-8?B?Z0JHbnNuMzJqZUZxcndtdTQvUUlzVkZDWHVRZDR3dDQ2ZGxzRW5Va2hFZzhl?=
 =?utf-8?B?ZXB0Y2VQS2tJYVptaTBtbHo1YnUvMjArYVg1RkNxUk8wcC9ENHh1QmFUYmRU?=
 =?utf-8?B?NHFVdWtzcEt3VWVzZENqZU5KUXJibWEwVStSNGgrOHBQMjliTjh1NjZ6QnZF?=
 =?utf-8?B?N3FTeXRRSmt0UGIvaWxGQmtVYjlhaEtHdGRnVmZHTWVTK05hUUhyZk9qZjRx?=
 =?utf-8?B?bGVuMGNaQ0ZPanIzTHV5MkVVSEZudW9NaEhEbzZMSWI4alpVT1cvQ0ZiNmJ4?=
 =?utf-8?B?bEs5dkJUWTllWFh3bytpR2EzZnlWNHZobXFya2lVSklqKzI3SVgwRkpqOHRW?=
 =?utf-8?B?ZUdsMElSN0dwUzVNa0x2bWNpU05UU2s0bllMcjFiTm9qQUs1TUdEdzBnUXBV?=
 =?utf-8?B?ZDRJKzI3aWo3bklYbVB3blZkMFN3a1pJU1lodmNvWlJoTGlkMmlwSGZ1UXFC?=
 =?utf-8?B?UEVTSG9EVExmL1VBRVA3TEVWNzZrUXJwVVRNcjlMeEtucDhjb0NuckJLVXM2?=
 =?utf-8?B?bG9ycVJpUjU3a0lRemkvNU1NU0p5RUhoTFdXMStzbERHK2dzVEYvUEIvOTFp?=
 =?utf-8?B?RVBJWGhxV3FYbXpWNGpxZ3ZzaU1hZHZ4bDZqb0I1RmdIejdGQkpDdDVQaFBB?=
 =?utf-8?B?akFBMk44YXd5d1QyQ0t0dnVreFpwWFl1M3dTa1o0T2gyZzVhVVlxblA1N1Q1?=
 =?utf-8?B?YlBWWHhnOE1JdDlVUDZKSE82dVV2YkFwSzRMZnNVeUFVU1VnVHRldXM2NFBL?=
 =?utf-8?B?R1NOajgwYm92OEVhaE8yczAwbFlHTDk0VU1qWVNZMVRiRUUrMDB1MVlzeHVX?=
 =?utf-8?B?bmZpaE9TYmtHS2NjWmlBV2s3citEUmZPSkozVDFCUW1iQmxHN3YxN1ZxaDFZ?=
 =?utf-8?B?ZFdJVmR2aFNncVhzdVVEMS9oaU1GWTNBbHpMM1hydWtFUHpqM1Z0bStGekJU?=
 =?utf-8?B?VzE4c1A2NTg1OXk2Wm13ZDBYbk9WWU9BNjJWbTkxZmo5UGhTb1FTZnJKTjJW?=
 =?utf-8?B?MlBOUTErZkZqbDdhSi9NQTA3M29sdWN2M2xxVWN0ZnR3V2d5blpxSm5OajNN?=
 =?utf-8?B?eEVRSWNuV2wvV1FUOEdhM0ZieEFHakdRaWdvUUpBS3ZNbzFsV0c1NjVoZFFs?=
 =?utf-8?B?UGdSU0Rod1I3SXFDNmNvaitiSzJiRUF6UU13Q2o2Zk9jUW04TGZzUGRVM0pt?=
 =?utf-8?B?NG5DWHlIQjJrTFI2TWFYQnlINElsSmZpZ1UxVGlQRDJIendzRmdzdVJMMnNJ?=
 =?utf-8?B?c0E9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 2
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?R1BWWlZUenJYRzI2WHplOHZJNEMrcWZncG5iSzdocitGNUhVVERRQVZFU3F6?=
 =?utf-8?B?SFRGaVRlRmNvSVRwS1V5MVc2RythTVlaYU10aG4xaHJGdFZ1OG05bjhhalh1?=
 =?utf-8?B?d2pEWllDUnk3dVNJVzVuYTFYbzB2dVE3QXNaeWIzY1JoRjJ2Z2pHRndZdWx2?=
 =?utf-8?B?Nzc1T2JRZml4VHAwNVFWTStFMGdrYWVrOTFPL3h0OFR6bVZaSEpDVFRnSndi?=
 =?utf-8?B?WW5TMEZqUFg4aVpHUFlLK3ZFY2VoTkJuc1JMUXpsQ1VSYjZZcGtsTXJOMlVH?=
 =?utf-8?B?RXl4cDhnSFNZWU1ndnJGY0Nrakp3UXRpc2JFb1RQNVllWmJoOWl0MVRzRXBN?=
 =?utf-8?B?VGNRdFE4VVBaVm14aHF3T0R1bzh1aGNLUkZXeEtZSzQ4d3RieUdBVXVoL1Vm?=
 =?utf-8?B?M0lzL2UyNGNEamdKbXBWV3pITGJCcWxNNFlwK1kwbVllRHVWZUJHUEJxZVRt?=
 =?utf-8?B?RkJWOU11Mk5jM0dzaXJhSUlUeHlmaUZENU0xZUtTV2I1VTlDZUdaWDM1N0Ni?=
 =?utf-8?B?VE4zZFhTQkpVang5c05LQVo5SjlRMG5jOFBhOExMcGFXbnc3cklkbSt5bCtC?=
 =?utf-8?B?RU9pQ1QrMGZTRDlQRXVZN0VaRG1oM1hTaUwrZU1JK3FUc2kwR0FKemlqd3Mx?=
 =?utf-8?B?b1Y4LzdRb3d6dFB4NHZLc0JOK3RjRGRjYzI4Zlc3OWU1K1IwUXNhWWh1R1NR?=
 =?utf-8?B?TmFNR2RNV1dMQnRJQWdrTFlMMVpjTkNCSGFYeW9VcFgvOTdmckdVU0pMUXhR?=
 =?utf-8?B?OEpML1JlZFBEeTdVajk2eUtLbzU3cnpUdG9CV0JoTGFENHh2bDJoaHhoU1lW?=
 =?utf-8?B?N2REay8wK1JaTlRDYTJOcGdXb1lCcGYxM1FmYmlPbE8zeTNvWTRJbEFwUEdC?=
 =?utf-8?B?b2hOU1UrcG1rbmlIa3dwaXo1Q2hkdzJXUVNVdDhrcjRGZ0s2QlREQ0prQmNF?=
 =?utf-8?B?eVJjZ1pYK255bjV1V1V1eWFhQi9GNWNTTEIvSWJnQVp2TUo5TmZNQmlMYmM0?=
 =?utf-8?B?Ulg3R3YzY2FHR1U1enN5RmJDd0hxM1Q2TDAyTEMxZndJbzBNMklQY2d1eERK?=
 =?utf-8?B?RXV2c2s3bjRtVXRBdjJXVGcyWjR2dFJma3BodjhzTXN0a1JyZ2p4cENrbUlx?=
 =?utf-8?B?YWtlTlZISCtYME5OQndNU3U0aFA2WHY2SFFxaGpnY3ZpRHNaS3ZhMGJWa3pU?=
 =?utf-8?B?UmNXdnNPdjdWNitrVkdCMnRSZ2Jlb3F6OVNZNmpESHNEQXBJMExidzRXbFZn?=
 =?utf-8?B?RU1QWVc1dEtiRys2dFJUMi9FNUlKNE9xVE4wREpISEM3aUtZakpJWUlLMjZE?=
 =?utf-8?B?L0JLUndlMDdtUU5TN2ZMdURSTjFTQVBQQnRBZEkrUHNWVVhlakFUVmo3MkFQ?=
 =?utf-8?B?aXpYdkNUYTRhbll6RXk0UmsvU2kvUHhQRHA4eGg0L2V2ZXZzL3U4d2tLd3Y4?=
 =?utf-8?B?UjdTVXMvZ0VCNnJ4Sk9FckU5UFltVGtoYWpYQ05EWVFQbHN0dGEwSlZsUGlB?=
 =?utf-8?B?TFJFUUVWanNhUGd1dEVXb0JybG1zb29sQjJDeHF4WHVVMTRIR2RXUjAyOVE1?=
 =?utf-8?B?QkYzS1IzNWpHR21reGhlVFJMMDdFdEJZcVc0R0QzVFB3V1ZlZEtBWlFTa0l5?=
 =?utf-8?B?T0FUZHhKb1pkb3JLeUtNeVJ1Q29RVTNycUJ0SFk0Vy9jNUEwYS84VENCTHJF?=
 =?utf-8?B?b3I0U3NNckZGZnVjT3NReUJqUXJHNGw5RDFpZEVaU2dpZWgweHlzZC9UM2E2?=
 =?utf-8?B?dDhYczVLcHF1VnAxNGJUR0xJRGIrMEd4THJqQzl4ZXIyM21lRUFPREZqcHJP?=
 =?utf-8?B?VVZvWmlQc2ZKcXdMOGhhdysxWnZjdUloR3FKUjBGcFo5VU44N1E0bWRDa1NH?=
 =?utf-8?B?OG9ORXpDd2xnb3dGUXFCci9TVlg2M1FWUFZHeXMvQmphS0NEYTJWWDFnNVdv?=
 =?utf-8?B?V2JLaU93K3dxRUQ2ZzNBVVE3S3VJMnNuUG5xUmJnVXVEaXBKblhDelNxR3ZJ?=
 =?utf-8?B?OEdyNmNzMEd6N3ZRT2xiOVNOaFY1cUNmMmVhRXBRNStqSklsRVVtWG5DajNY?=
 =?utf-8?B?eEVNUGdrZmxWMExMM1pVb3QzcmM1T09LY0hKSWVyQkptcmZ0UXpZR1VMd1Qw?=
 =?utf-8?B?STgvSXg4OXkwamh6VjE2Y2ZwR29wNWtnVDVrKzJ3NG5iRDRzbzVsM09tZHhM?=
 =?utf-8?B?NldjdW5QY3UwT3V6em9CQ3U5RVVqb1VEUmFIbWF4WXF3Y21rQTM1d3BMVnRz?=
 =?utf-8?B?L1I3M2RIZkVmUDJ0K2lNeWp6N1RjQWh4SXl5T1gwNXVvWkVEUGZIb2JNdWZW?=
 =?utf-8?B?K1NGWUxKOEprM1ZLNVd6MEQ1QkU0SW9aZFZSTWhneEhXNE1wbVhNMkxxNHZk?=
 =?utf-8?Q?D4idI1NMG0nk1DJq0KW9tGiya1Fri91DcS7wsSS9wZCa9?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-1: SHj2eFh1eQqRtSlc7tt+kkLev04XEDOW6GqDwXrqhMHA3Yj/w+RzmIrPOUx002WJbjyNkkkjQUc8doFgNrjPdncRDrjvD+ACGMC3hSC3Eyy4pf9T96mDpWWqxBIg0kTEnubugxZsKz0pgi8YN8MPuQAIbu+Zn3hx/tbN8f+FCAsEiaQMHX+KKTv8qbkVqYKEqi/sspH3JcWdHMktUvcf7+wrXkiRs7uvw/rhZD6YB3y4EkWFe0wQtjDc3qY2vEkKVDc8kkY+U1Yvt/RfClhxE0AWjYjJ5BjH0TZKLR5ap9TbE1K1206uVLdzxCpUjjmbUTXuI+CAXTs5LFLCyBOLGebQzDcwZViWOGckyEOgu1PzyyWEqDNhaoNvfpbpIeNFrMl0sdjjolUgXBcQELToqnQmb3xs/aGJQCqmAC8Fk4Azl4VB3+7PnlNf7I9T40V8Z2eCmTkmHpu83g==
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c338f780-a942-4197-2b90-08db718dd87b
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4531.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2023 12:57:04.1614
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /SXPBjqWFjCas0MA7wYAQnCEIdYJ9QfhxIJ52Ar4WIjquyarrwz9GvdIvNDCyBlq7ZOknIedHrdhUTekH90Cx7sHL4vB7NrTZUbjCNIMh7Q=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB5677
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-06-20_09,2023-06-16_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 suspectscore=0
 adultscore=0 mlxscore=0 mlxlogscore=912 malwarescore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000
 definitions=main-2306200116
X-Proofpoint-GUID: uspd2sYxZpajd9hCmMWFZoSsWWXy1Usv
X-Proofpoint-ORIG-GUID: uspd2sYxZpajd9hCmMWFZoSsWWXy1Usv
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/20/23 03:21, Baoquan He wrote:
> Hi Eric,
> 
> On 06/19/23 at 10:57am, Eric DeVolder wrote:
> ......
>> +config ARCH_SUPPORTS_KEXEC
>> +	def_bool y
>>   
>> -config ARCH_HAS_KEXEC_PURGATORY
>> -	def_bool KEXEC_FILE
>> +config ARCH_SUPPORTS_KEXEC_FILE
>> +	def_bool X86_64 && CRYPTO && CRYPTO_SHA256
> ......
>> +config ARCH_SELECTS_KEXEC_FILE
>> +	def_bool y
>>   	depends on KEXEC_FILE
>> -	help
> 
> I am a little confused about this ARCH_SELECTS_XX adding. Wondering what
> limits us defining the ARCH_SUPPORTS_KEXEC_FILE like below? I have limited
> knowledge about Kconfig, please correct me if I am wrong. Thanks in
> advance.
> 
>   +config ARCH_SUPPORTS_KEXEC_FILE
>   +	def_bool y
>    	depends on KEXEC_FILE
>    	depends on X86_64 && CRYPTO && CRYPTO_SHA256
> 

For the ARCH_SUPPORTS_ options, I chose to list the dependencies on the def_bool line to show that 
it took all those conditions to result in True.
However, as you point out, using a def_bool y and then listing them as 'depends on' works as well.
Probably would have resulted in fewer changes to the Kconfig file.
Either way is ok (the 'depends on KEXEC_FILE' is erroneous in your example).
eric


>> -
>> -	  This option makes the kexec_file_load() syscall check for a valid
>> -	  signature of the kernel image.  The image can still be loaded without
>> -	  a valid signature unless you also enable KEXEC_SIG_FORCE, though if
>> -	  there's a signature that we can check, then it must be valid.
>> -
>> -	  In addition to this option, you need to enable signature
>> -	  verification for the corresponding kernel image type being
>> -	  loaded in order for this to work.
>> -
>