Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 20 Jun 2023 20:49:16 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     "Karny, Wyes" <Wyes.Karny@amd.com>
Cc:     "trenn@suse.com" <trenn@suse.com>,
        "shuah@kernel.org" <shuah@kernel.org>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "rafael@kernel.org" <rafael@kernel.org>,
        "Shenoy, Gautham Ranjal" <gautham.shenoy@amd.com>,
        "Limonciello, Mario" <Mario.Limonciello@amd.com>,
        "Yuan, Perry" <Perry.Yuan@amd.com>
Subject: Re: [PATCH v3 1/5] cpupower: Recognise amd-pstate active mode driver
Message-ID: <ZJGgTEdmsz/A1jco@amd.com>
References: <20230619190503.4061-1-wyes.karny@amd.com>
 <20230619190503.4061-2-wyes.karny@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230619190503.4061-2-wyes.karny@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?37f65gbKSfOQL3uHFC3MNgMCLrqIQeeBKFoA8MgF/nKMiERcMW+uRy+YJvFi?=
 =?us-ascii?Q?t9UgAhB3LNyK52WnRkf1HfHeVZfDUW5Z219ja/ltfptUg0C8sKD8B3iIY46V?=
 =?us-ascii?Q?JjeaPJ7auDjxVHaEhUBq8Y+hrj8FqIoKrnTFJijzKW8dmZdCrBVp8DqUA0SX?=
 =?us-ascii?Q?XSSgbtwzlxH6ZV621lCgQxRCDwoFTjoXl7YIvOFwewK1KrEEDRa88xyntZwM?=
 =?us-ascii?Q?BL1qnQdD40w3w5ZmGDM3nA78CrGpEW2dBDilabjvni+4UZVd9PrjJ9B0rchC?=
 =?us-ascii?Q?GhL/CPPeWfmlSzEI2DG0TwkbXeoCT8UQQ3saxlAoaKkxVWNMpt9eoUj+hGVq?=
 =?us-ascii?Q?issSGArRKoF7fxS111+N3H/RoKN4XcWgF6PWIdyMwYCVVYcfWpeudw21D2ZU?=
 =?us-ascii?Q?qox0nkB8ykQO6thsHA3UVGXx8pfWZ3y4SOYZos9LftRGhdxippoXxAx4Pj+7?=
 =?us-ascii?Q?17nl/0Oo9TClrEaRlgv5ek8wuTVKjhN6yq7R4OajT+RzGUdasRCluShmXneu?=
 =?us-ascii?Q?LIo+pE/7zdX1gHfaIALJTCF15viIQ0Iz/jVl031+77Un8KZBbz79r0hHi7n5?=
 =?us-ascii?Q?lSpaiGWiD70ejieOPHTIpqOX3Iu10X+ERcVngVHKpwqxerInI/xLrIB7aIwT?=
 =?us-ascii?Q?kTuBJvaqUZIE/AmjRNokLwIGc3xjEWvoowgbM3MiZyRZNu8y8KmSg/xXGmZ1?=
 =?us-ascii?Q?YQ3gaDSZIgKmU3OkQI6BgrD4dEIDZaClmnB+Njp3SuhSU5qA6LcRqobhD1/m?=
 =?us-ascii?Q?ce81rg1zo1GqFG/WyhhKX+0lhlWXIKd/nqrRftoI2Tzd3KuYBA/WjpRzzItC?=
 =?us-ascii?Q?GpvWvMZXW8otUsBgZfYbeNJ0Aho5/zmsS67dQv8BvldZMNMmUPC+9fcXe3Ud?=
 =?us-ascii?Q?wIeEIOS3pFrd7JNHxY+1zeK4RwErF8JVHeFH77/8suIm6BuKi/Q4xhRCoSVe?=
 =?us-ascii?Q?yftkcoOPf+EstTfdALPGodFNxG4zSj0wUW6N+t337M5HGrLZ8U379k9WqYmg?=
 =?us-ascii?Q?A18AyUtR42dM7jG7X/KNitL3TnbIP5Fa9FXIlutDczeJF0+8+QdD6E2WWQmB?=
 =?us-ascii?Q?UKHOmeZdUrxZme3A6dLMHPcGP3M/fB/xYggDsOhJmavCfHLI7E5I5uXhn1Kd?=
 =?us-ascii?Q?+UIVnaw5elomq4v9+0obgXHs7WgcFyjx/XX5I3K4g9KybVume1VGVW3IW64C?=
 =?us-ascii?Q?wV+2W3nwOfXTPUx7HddBUoJykbDkMRmB0w/FohH1XVgrIF9+6INacE2kUFGt?=
 =?us-ascii?Q?5Y906ExkZTb9PipZB+0x81+zwT1ULiIqVkIdhGXgyLTgaXkjY0Vp6BIPym1W?=
 =?us-ascii?Q?0d9xRBZ4/nldlcVOfXE+hGPcZisP0qYBUVtIrlPWd7pxpUeKSGdfE6h+JvB3?=
 =?us-ascii?Q?JVq0+8dy61UzHm1Z7k2TA2oIHt0eV0fxU/ul8FBQxq2R4/+Ur8MVu5P0RYOh?=
 =?us-ascii?Q?sGLCy0cmzoihOJXInS3s/Nk+aQr/08XB9gqrXl12NWSCQrGlrT0NdiNKw71l?=
 =?us-ascii?Q?r08PYvlI/xFsr8eLm/9kx5fzKezsjN+s4fc2BNgEmOuNOLtz6U1o/1qDBeBe?=
 =?us-ascii?Q?wojGUFAEOyCE9rW0qFuovoBwBPXStjazfTGL0Ar0?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 070427f3-4356-4aec-16b9-08db718ccf4c
X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2504.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2023 12:49:39.1437
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fVtCvM1cz4z3sBJDBaIQHTsyFspQVJrw+22F0WfvK1d8FX7udaiEZZZHOxk4Y2QkBdZcRETDBx0YE8P/d4fRgg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4956
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 20, 2023 at 03:04:59AM +0800, Karny, Wyes wrote:
> amd-pstate active mode driver name is "amd-pstate-epp". Use common
> prefix for string matching condition to recognise amd-pstate active mode
> driver.
> 
> Reviewed-by: Gautham R. Shenoy <gautham.shenoy@amd.com>
> Signed-off-by: Wyes Karny <wyes.karny@amd.com>

Acked-by: Huang Rui <ray.huang@amd.com>

> ---
>  tools/power/cpupower/utils/helpers/misc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/power/cpupower/utils/helpers/misc.c b/tools/power/cpupower/utils/helpers/misc.c
> index 9547b29254a7..0c56fc77f93b 100644
> --- a/tools/power/cpupower/utils/helpers/misc.c
> +++ b/tools/power/cpupower/utils/helpers/misc.c
> @@ -95,7 +95,7 @@ bool cpupower_amd_pstate_enabled(void)
>  	if (!driver)
>  		return ret;
>  
> -	if (!strcmp(driver, "amd-pstate"))
> +	if (!strncmp(driver, "amd", 3))
>  		ret = true;
>  
>  	cpufreq_put_driver(driver);
> -- 
> 2.34.1
>