Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 20 Jun 2023 20:59:00 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     "Karny, Wyes" <Wyes.Karny@amd.com>
Cc:     "trenn@suse.com" <trenn@suse.com>,
        "shuah@kernel.org" <shuah@kernel.org>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "rafael@kernel.org" <rafael@kernel.org>,
        "Shenoy, Gautham Ranjal" <gautham.shenoy@amd.com>,
        "Limonciello, Mario" <Mario.Limonciello@amd.com>,
        "Yuan, Perry" <Perry.Yuan@amd.com>
Subject: Re: [PATCH v3 2/5] cpupower: Add is_valid_path API
Message-ID: <ZJGilObVcAMhPNF4@amd.com>
References: <20230619190503.4061-1-wyes.karny@amd.com>
 <20230619190503.4061-3-wyes.karny@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230619190503.4061-3-wyes.karny@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jwqz0O2e6ew7JoEt8urQamPuoNHioDL38VuSL0wS0xx27Yvjnm434SwMC47F?=
 =?us-ascii?Q?G8e78gb6hVYYotsFSa2rkfG9+bFetHJF1nkVZo/tkmgpfQxvNXrg5NvCZEeu?=
 =?us-ascii?Q?du6HWyuLfdG0ZNAdoS/yGq+1uV7kpz2ZJ/i6UxiT07YxCGSVrKvTL/I/SQ86?=
 =?us-ascii?Q?l1AuRBUwS7qfiT0qGsvwU+FrE8SO05sEwyheHkCRrAhZoJ7gnbq5JiqmcviZ?=
 =?us-ascii?Q?jTjyQPkjyNsRXq2IK6qn/MBmpAvdXziciWrNneGV4IWzSEOzbCnF0nt7QVFX?=
 =?us-ascii?Q?8OouB1uo/f8r7iNj6ePDTF5RZa7APkTcbs61zYVtL7CR8ZeXR6NhCdlHeMi6?=
 =?us-ascii?Q?fCamLuiIcn+KqW8lBwi0T8hUt3/q4nNSW0frHKTLHuRvxZMGW8WUmCgFkKex?=
 =?us-ascii?Q?3kFx7O/aJmDeQIIqdCbQsPH0WouR2epnhfVTcjmZCkOh+97dNdT4eDj9s6kz?=
 =?us-ascii?Q?OsZM4vFxXBD2+gaA9JHQa7ZuayJY5oaaZ9hrpHThWA2MEpZfIK9qOUAF3Yg0?=
 =?us-ascii?Q?3ciCDyg/zB3aIqgGI/7akhofESxt6WE8yw+7Q4AFsxFHl0lF7kdLpn803ZY8?=
 =?us-ascii?Q?+H2xBx4OxuaPMN1Hts7OblmawFYVaIK/3Pa7eMXEQgi1hUGhKmMrgXMAvxzN?=
 =?us-ascii?Q?oRdN8RoTH0ydkbQawUc4lIvUG2dIOMm4FN+pjY3WPnHooGPHW9hI5SuwAkiI?=
 =?us-ascii?Q?AkFHHb77mGDG2E0I4MBTKeM4HVVFgND3fACpDQA7f8eaGCMZq7zAv453uEv/?=
 =?us-ascii?Q?OkpU1iHH1BVcBRvrfje6CYJ8OrkNLTjBKCZtdJGPGvlqhCrjhXH+FXjPngJr?=
 =?us-ascii?Q?mxRdU05WGu6lBTIqhJfKPS3fPzaa/xc2Yv6TbZ9QwX6Mrd/9ugKwo8fQNr9Q?=
 =?us-ascii?Q?LgObLGtqDvyhUzYmyqEGvzfXmh2t9siATMlKpaaTqfSVToHyqWOrGdu0fzoz?=
 =?us-ascii?Q?D3wanGnJaIsev2nOh/Ymp37YVjwgBbzZEGD/SkmveLLMJahSrp6ffV9Yhj7k?=
 =?us-ascii?Q?e/oz0D6ji4QllB52C83mo2SKrWZcailnxIU19h8DusoIfF0GmEWwGHp6Fuec?=
 =?us-ascii?Q?uA2Jusanas9SSOFeEqVbNaJQre6lKv31gNrM8hwKa6KXhDAYYsZcr4KtpF2z?=
 =?us-ascii?Q?9Ffi34V6bdTSZV5jrgOfIx0BQ7VaREbsa9gcVaJim4wDTz5AWAFBA+gbpg7O?=
 =?us-ascii?Q?CL87dIqirCi1t9iFA8yVzO69ljjo+pPQfPQi5LAmi5mjNI7Yd3TILycpJVvR?=
 =?us-ascii?Q?HBdDBf/KjdcGbotWXB3r1/5/8KccAJWIRMZYBZvhdyNT9uHQ+KmhIWT1nk3S?=
 =?us-ascii?Q?o+FLVojcogOlOo0FsS1i3OprA/iZraa9LtGKGPjoJ0gRUtuhUxeR8rAAkwKa?=
 =?us-ascii?Q?daV4UtpImRYg0gkyVxGcK3te7LH9N8QrjxK9Y/rN1rC9V1QW5OQ7pIhmN1cA?=
 =?us-ascii?Q?2T9qWR2nkmg4DRPtJBFIGQHqtPNSMO/EQSx4lxgsvsGEpF7lZ9jw55gib7yE?=
 =?us-ascii?Q?DlRNP+nYD7f8fZ95T+p6jSIGK80ynSoxI/bD13cmgxfJLU5dVF2BvZRcAfdr?=
 =?us-ascii?Q?/SaWNjHuGm164nEdZGHCnitas3ij5CGB4hCVIhZL?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a7fae876-3964-4ed6-ca6f-08db718e2afe
X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2504.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2023 12:59:22.5949
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yqsIkCucl+FkrCKSFu74wHNVWFcNIzC6TxuNZz4ZfXcfAhlIXVes0sckoUSRbrTVvbEh9Aixw2Mr7IBaQJjDNg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4939
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 20, 2023 at 03:05:00AM +0800, Karny, Wyes wrote:
> Add is_valid_path API to check whether the sysfs file is present or not.
> 
> Suggested-by: Gautham R. Shenoy <gautham.shenoy@amd.com>
> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> Signed-off-by: Wyes Karny <wyes.karny@amd.com>

Acked-by: Huang Rui <ray.huang@amd.com>

> ---
>  tools/power/cpupower/lib/cpupower.c        | 7 +++++++
>  tools/power/cpupower/lib/cpupower_intern.h | 1 +
>  2 files changed, 8 insertions(+)
> 
> diff --git a/tools/power/cpupower/lib/cpupower.c b/tools/power/cpupower/lib/cpupower.c
> index 3f7d0c0c5067..7a2ef691b20e 100644
> --- a/tools/power/cpupower/lib/cpupower.c
> +++ b/tools/power/cpupower/lib/cpupower.c
> @@ -14,6 +14,13 @@
>  #include "cpupower.h"
>  #include "cpupower_intern.h"
>  
> +int is_valid_path(const char *path)
> +{
> +	if (access(path, F_OK) == -1)
> +		return 0;
> +	return 1;
> +}
> +
>  unsigned int cpupower_read_sysfs(const char *path, char *buf, size_t buflen)
>  {
>  	ssize_t numread;
> diff --git a/tools/power/cpupower/lib/cpupower_intern.h b/tools/power/cpupower/lib/cpupower_intern.h
> index ac1112b956ec..5fdb8620d41b 100644
> --- a/tools/power/cpupower/lib/cpupower_intern.h
> +++ b/tools/power/cpupower/lib/cpupower_intern.h
> @@ -7,5 +7,6 @@
>  
>  #define SYSFS_PATH_MAX 255
>  
> +int is_valid_path(const char *path);
>  unsigned int cpupower_read_sysfs(const char *path, char *buf, size_t buflen);
>  unsigned int cpupower_write_sysfs(const char *path, char *buf, size_t buflen);
> -- 
> 2.34.1
>