Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <OSYP286MB03120BABB25900E113ED42B7BC5CA@OSYP286MB0312.JPNP286.PROD.OUTLOOK.COM>
In-Reply-To: <OSYP286MB03120BABB25900E113ED42B7BC5CA@OSYP286MB0312.JPNP286.PROD.OUTLOOK.COM>
From:   Sergio Paracuellos <sergio.paracuellos@gmail.com>
Date:   Tue, 20 Jun 2023 14:55:41 +0200
Message-ID: <CAMhs-H_OtDgJmBrcrN33goXDM19WJr1+Za+G9tibMZrO+9KL1A@mail.gmail.com>
Subject: Re: [PATCH] mips: ralink: introduce commonly used remap node function
To:     Shiji Yang <yangshiji66@outlook.com>
Cc:     linux-mips@vger.kernel.org, john@phrozen.org,
        tsbogend@alpha.franken.de, matthias.bgg@gmail.com,
        angelogioacchino.delregno@collabora.com,
        linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Jun 20, 2023 at 1:46=E2=80=AFPM Shiji Yang <yangshiji66@outlook.com=
> wrote:
>
> The ralink_of_remap() function is repeated several times on SoC specific
> source files. They have the same structure, but just differ in compatible
> strings. In order to make commonly use of these codes, this patch
> introduces a newly designed mtmips_of_remap_node() function to match and
> remap all supported system controller and memory controller nodes.
>
> Build and run tested on MT7620 and MT7628.
>
> Signed-off-by: Shiji Yang <yangshiji66@outlook.com>
> ---
>  arch/mips/ralink/common.h |  2 --
>  arch/mips/ralink/mt7620.c |  9 ---------
>  arch/mips/ralink/mt7621.c |  9 ---------
>  arch/mips/ralink/of.c     | 42 ++++++++++++++++++++++++++++++++-------
>  arch/mips/ralink/rt288x.c |  9 ---------
>  arch/mips/ralink/rt305x.c |  9 ---------
>  arch/mips/ralink/rt3883.c |  9 ---------
>  7 files changed, 35 insertions(+), 54 deletions(-)

Awesome! More deletions than additions in arch folders is always a
good thing :-).

Changes look good to me. Thanks for doing this!

Reviewed-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>

Best regards,
    Sergio Paracuellos