Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6b63301f-96b2-74b9-c156-3a34fb5ad346@meta.com>
Date:   Tue, 20 Jun 2023 07:53:28 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.12.0
Subject: Re: [PATCH bpf] bpf/btf: Accept function names that contain dots
Content-Language: en-US
To:     Nick Desaulniers <ndesaulniers@google.com>
Cc:     Florent Revest <revest@chromium.org>,
        Andrii Nakryiko <andrii.nakryiko@gmail.com>,
        bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
        llvm@lists.linux.dev, martin.lau@linux.dev, ast@kernel.org,
        daniel@iogearbox.net, andrii@kernel.org, song@kernel.org,
        yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org,
        sdf@google.com, haoluo@google.com, jolsa@kernel.org,
        nathan@kernel.org, trix@redhat.com, stable@vger.kernel.org
References: <20230615145607.3469985-1-revest@chromium.org>
 <CAEf4BzbjCt3tKJ40tg12rMjCLXrm7UoGuOdC62vGnpTTt8-buw@mail.gmail.com>
 <CABRcYmK=yXDumZj3tdW7341+sSV1zmZw1UpQkfSF6RFgnBQjew@mail.gmail.com>
 <c26de68d-4a56-03a0-2625-25c7e2997d45@meta.com>
 <CAKwvOdnehNwrDNV5LvBBwM=jqPJvL7vB9HwF0YU-X5=zbByrmg@mail.gmail.com>
From:   Yonghong Song <yhs@meta.com>
In-Reply-To: <CAKwvOdnehNwrDNV5LvBBwM=jqPJvL7vB9HwF0YU-X5=zbByrmg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UXBpbHVBK1N6WjdWbXNFVWY5MlM2ejBBZTFyWmJPQ2hBais3dmhuZytBTVNm?=
 =?utf-8?B?T05iakZEY0VvSjUzWEp3QlFQTnJTZ3pvL002cG9ib2dRUzhFVDBMTTFwR1BM?=
 =?utf-8?B?cnN5SXRBZ3hwZXllaGV5NytFY2paaEtqWUt6Qm5NTzI3Tm40MThvZEdyNVRO?=
 =?utf-8?B?cWpnUitjenZNU21GbWhVZXJ3SGNQbGhiRVo0SlZCUktVZXFTNk1oS3BrYTZE?=
 =?utf-8?B?SWp4ZUxIZWJoUCs4MUpSKzZKbHZlY1BMVXhLOFBKME5OTUFHZjN6ZW1LNWN3?=
 =?utf-8?B?S1ZqSjVQRWw0dGNaRWhvMFplNkJTOUV4UEsyYkdNaTBMYVp6WGl6QjNDaXY3?=
 =?utf-8?B?eWRBU1NnU0RUT2Y2TkZ2YVZKOUlzaVRueE9xcDl0bnljZHp4WTcvZHFrWi84?=
 =?utf-8?B?aTZ2cHR2TDJxSDBIT0JiWG80TXYrOU5GRFhMN3ZKZExoYVVqWEVTVGNGK3VH?=
 =?utf-8?B?WE9IWlRRM3o2NWp4Y3ViSGYveTlvMHg2Z204MDA0aTJFRGZuUmtucnJLT3h2?=
 =?utf-8?B?OGlOQkExYytZR1FYZkJOb0draThXaHRDMDMrei9sUUFQdHBwUkFwM1MrVnZO?=
 =?utf-8?B?eXdXTTUySi8zbFFlalU3OVRQVXNHZlZTUzJVeXJoeHVWTFE0OENwTDF3WmJw?=
 =?utf-8?B?ekNtWVdkczBzejlYUVFnb2dZN3lmVDIzSHcxU01iY3d4SzIzZ1JPd2EycFhS?=
 =?utf-8?B?TkFlRXFjYWNGWWFSdXUza25aNDRLSGpGSmg0ajE1NUVCZVBBZXl1eVEwb08r?=
 =?utf-8?B?Q2dlOUN6cU80VTZ2YXcrMmxvc3RMNGFrc0RhVzhJdTJuMXRBYXhlczFOUFJx?=
 =?utf-8?B?TGdMQTZ2MDBtNE9lZEIzZlo1Mng1ZWpsQnJUWHA4Q0VqYjlpaEdiSjM2bGUw?=
 =?utf-8?B?d2VDYXRrY3R3WXNyK0l4MWc0UGpvSUlqUDlIVTF6QVgxNThXckVqa0EyMWo3?=
 =?utf-8?B?RnV2TXZRNFpQQXY3anRaQTN5ODFSc0tFekYzQ2MwUGs0U2tSQ09UNWtHNkVq?=
 =?utf-8?B?K0g3UmlXQ0VIbG5scHlMb3YrODVGRVNySlNrb3pPWXlIL0JYOWtRSVdVbHpC?=
 =?utf-8?B?K1FhR05XaWRNeTY2YlZ6RytYb1VXWlhjUHN5SzdSVnJpZVh2Um9BVXNSeVhX?=
 =?utf-8?B?OTJ6aGtGMFpGOG04QndaQ0R1aTdpOE5aT05FQjRMZnJYR0dVMTVFRXc2V2Nz?=
 =?utf-8?B?RFdpVTVzS3F5QW9UZXZhQ1MzNytMeHBDN0p0dE4yUmd2QTlQRUd4RzZjMHJQ?=
 =?utf-8?B?R0xiVUNwOTY3NjJTckZ2cVNXdVg1NmpUaUdJeE9XTXF6WUViME1VT1VLeHhU?=
 =?utf-8?B?bHk1a1NMaElxaFhvUVZUNzJzSzRJMkVoNlRjdXkyYmIxbHk5bWYwOTBFLzhj?=
 =?utf-8?B?SEowaXYrbmV5OGRmeG45dUVhOG9xTE5xNkUyTnl2eFR4VVlvLy9xbGVJSjJM?=
 =?utf-8?B?OWozRENaOVR1bTREejlVd1htYitrNEFmLzMzNTdKa3pjaWl2MERlQzJvMHkv?=
 =?utf-8?B?L0hFbkZoUkFGNlBDcGNwQjZvaGlTVys2RktxOTVzMnk0V2RzWXRhRTRXVVJE?=
 =?utf-8?B?d3NlWmsvS3cxRWZEblJuNkRWcHRvQUd5SlNaTW50WXRGZUo2Z0hBSjR5LzZW?=
 =?utf-8?B?Q3ZJV3I3eVpmUUhDU1ZCQXZ5K0UweEVWZjZMM25qSWlhcmQvOVNrbEFQVEhO?=
 =?utf-8?B?S2pFS3g2K0owMWJ1MTlCVm05WDF2Ui9RMU1OdGUvT3g1VU9BTGRtejlHdnRl?=
 =?utf-8?B?ajVuVDJ6anZTM29IdzJxSTYvWmJIMnREZEpkZUJLUmJLOHo1NmZHaDEvZmhr?=
 =?utf-8?B?M3gzdkVBWnlGUTd4MVpYYlBoQ1p6aVAxM0JrU20za3g3djlxU3RzbTdkSnlQ?=
 =?utf-8?B?YWNnZUp2d1h0L2V6MGNON00vVlc5cmFVMXZlQXBVQmdtN0ZtQ0ZvemF5SVky?=
 =?utf-8?B?cXhpRkpzd25CMHRxUlNkc2YrNCtsRG5WSERyeTJCOEo3MDFCdnNUby9hMnJL?=
 =?utf-8?B?ZGt2dEFCeHc4SlpuRTR5R3prcW1SVzFWcmZkR2FRUTRPUkFTYVB0VnUwNkdh?=
 =?utf-8?B?WW5sN0JCTERrY2Z4MDhyQlQvZHVPYmZlWkc3RmVqNDdyU1VhTXpTUDlHS083?=
 =?utf-8?B?SWhrcDc1WG1xYVA1YjZndGN3eHBsVUxSRU4rd2xQUTdPZVpKUmlJUFJWY2FH?=
 =?utf-8?B?R3c9PQ==?=
X-OriginatorOrg: meta.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f03b62d4-d6d7-4d51-c49b-08db719e1e03
X-MS-Exchange-CrossTenant-AuthSource: SN6PR1501MB2064.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2023 14:53:32.6677
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DNkIF54Rinj9Heznz6y6A2aUNYKYgbiRdGxlJSzffLbuPW4MBXv4Mp8qK6YAEsXp
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR15MB5165
X-Proofpoint-ORIG-GUID: Lgzu7zW_0iCuI-VX6jBb81qooeztpBHw
X-Proofpoint-GUID: Lgzu7zW_0iCuI-VX6jBb81qooeztpBHw
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-06-20_10,2023-06-16_01,2023-05-22_02
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/20/23 7:38 AM, Nick Desaulniers wrote:
> On Mon, Jun 19, 2023 at 2:17 PM Yonghong Song <yhs@meta.com> wrote:
>>
>> How many people really build the kernel with
>>      LLVM=1 LLVM_IAS=0
>> which uses clang compiler ans gcc 'as'.
>> I think distro most likely won't do this if they intend to
>> build the kernel with clang.
>>
>> Note that
>>      LLVM=1
>> implies to use both clang compiler and clang assembler.
> 
> Yes, we prefer folks to build with LLVM=1.  The problem exists for
> users of stable kernels that predate LLVM_IAS=1 support working well
> (4.19 is when we had most of the assembler related issues sorted out,
> actually later but we backported most fixes to 4.19).
> 
>>
>> Using clang17 and 'LLVM=1 LLVM_IAS=0', with latest bpf-next,
>> I actually hit some build errors like:
>>
>> /tmp/video-bios-59fa52.s: Assembler messages:
>> /tmp/video-bios-59fa52.s:4: Error: junk at end of line, first
>> unrecognized character is `"'
> 
> Probably because:
> 1. CONFIG_DEBUG_INFO_DWARF5=y was set or
> CONFIG_DEBUG_INFO_DWARF_TOOLCHAIN_DEFAULT=y and you're using a version
> of clang which implicitly defaults to DWARFv5.
> 2. you're using a version of GAS that does not understand DWARFv5.
> 3. you did not run defconfig/menuconfig to have kconfig check for
> DWARFv5 support.

Yes, I am using llvm17 which I think the default dwarf is v5, and
indeed I have
   CONFIG_DEBUG_INFO_DWARF_TOOLCHAIN_DEFAULT=y

My gas is 2.30, probably too old to support dwarf 5.

Yes, I didn't run defconfig/menuconfig.

> 
> The kconfigs should prevent you from selecting DWARFv5 if your
> toolchain combination doesn't support it; if you run kconfig.
> 
>> /tmp/video-bios-59fa52.s:4: Error: file number less than one
>> /tmp/video-bios-59fa52.s:5: Error: junk at end of line, first
>> unrecognized character is `"'
>> /tmp/video-bios-59fa52.s:6: Error: junk at end of line, first
>> unrecognized character is `"'
>> /tmp/video-bios-59fa52.s:7: Error: junk at end of line, first
>> unrecognized character is `"'
>> /tmp/video-bios-59fa52.s:8: Error: junk at end of line, first
>> unrecognized character is `"'
>> /tmp/video-bios-59fa52.s:9: Error: junk at end of line, first
>> unrecognized character is `"'
>> /tmp/video-bios-59fa52.s:10: Error: junk at end of line, first
>> unrecognized character is `"'
>> /tmp/video-bios-59fa52.s:68: Error: junk at end of line, first
>> unrecognized character is `"'
>> clang: error: assembler command failed with exit code 1 (use -v to see
>> invocation)
>> make[4]: *** [/home/yhs/work/bpf-next/scripts/Makefile.build:252:
>> arch/x86/realmode/rm/video-bios.o] Error 1
>> make[4]: *** Waiting for unfinished jobs....
>> /tmp/wakemain-88777c.s: Assembler messages:
>> /tmp/wakemain-88777c.s:4: Error: junk at end of line, first unrecognized
>> character is `"'
>> /tmp/wakemain-88777c.s:4: Error: file number less than one
>> /tmp/wakemain-88777c.s:5: Error: junk at end of line, first unrecognized
>> character is `"'
>> /tmp/wakemain-88777c.s:6: Error: junk at end of line, first unrecognized
>> character is `"'
>> /tmp/wakemain-88777c.s:7: Error: junk at end of line, first unrecognized
>> character is `"'
>> /tmp/wakemain-88777c.s:8: Error: junk at end of line, first unrecognized
>> character is `"'
>> /tmp/wakemain-88777c.s:81: Error: junk at end of line, first
>> unrecognized character is `"'
>> /tmp/wakemain-88777c.s:312: Error: junk at end of line, first
>> unrecognized character is `"'
>> clang: error: assembler command failed with exit code 1 (use -v to see
>> invocation)
>>
>> Potentially because of my local gnu assembler 2.30-120.el8 won't work
> 
> It's recorded in lib/Kconfig.debug that 2.35.2 is required for DWARFv5
> support if you're using GAS.  My machine has 2.40.
> 
>> with some syntax generated by clang. Mixing clang compiler and arbitrary
>> gnu assembler are not a good idea (see the above example). It might
> 
> I agree, but for older branches of stable which are still supported,
> we didn't quite have clang assembler support usable.  We still need to
> support those branches of stable.

Thanks Florent pointing out 5.10 stable kernels which have this issue.
I am okay with backporting to old stable kernels if that is needed.
But the patch going to bpf-next should not have a bug-fix tag and
the patch commit message can be tweaked for backport to 5.10 though.

> 
>> work with close-to-latest gnu assembler.
>>
>> To support function name like '<fname>.isra', some llvm work will be
>> needed, and it may take some time.
>>
>> So in my opinion, this patch is NOT a bug fix. It won't affect distro.
>> Whether we should backport to the old kernel, I am not sure whether it
>> is absolutely necessary as casual build can always remove LLVM_IAS=0 or
>> hack the kernel source itself.
> 
> 
>