Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 20 Jun 2023 23:06:18 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     "Limonciello, Mario" <Mario.Limonciello@amd.com>
Cc:     "Yuan, Perry" <Perry.Yuan@amd.com>,
        "rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>,
        "viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
        "Sharma, Deepak" <Deepak.Sharma@amd.com>,
        "Karny, Wyes" <Wyes.Karny@amd.com>,
        "Shenoy, Gautham Ranjal" <gautham.shenoy@amd.com>,
        "Li, Sun peng (Leo)" <Sunpeng.Li@amd.com>,
        "Huang, Shimmer" <Shimmer.Huang@amd.com>,
        "Du, Xiaojian" <Xiaojian.Du@amd.com>,
        "Meng, Li (Jassmine)" <Li.Meng@amd.com>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/4] cpufreq: amd-pstate: Set a fallback policy based
 on preferred_profile
Message-ID: <ZJHAatXe+iVzM/JS@amd.com>
References: <20230615063225.4029929-1-perry.yuan@amd.com>
 <ZJG+Xhun1Ltw9ox/@amd.com>
 <bffb7ba1-c8cd-2653-94a6-e0b5cb52bc49@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <bffb7ba1-c8cd-2653-94a6-e0b5cb52bc49@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+xqtEyKoZMTNhWZTk/Ujz/tEVb0/vJX6sQkYvQkVG/22s1NuHpRoubFPmhfP?=
 =?us-ascii?Q?qVkHcQPCegJwtQ4yCmX5C++VnowwGo4bJtdiO7CjaG9B8YRBP/h4N6G+BdLF?=
 =?us-ascii?Q?jBpiNbcjajVQb+nb7HIgbDV8pBwBmQ9l67A9sOJHM6fC1ks6jRGLzo/VZGBJ?=
 =?us-ascii?Q?ObRhKW09FoOcRUx3+Is4m23e4TqILbb2hHAW39d3U6nVww+RPVTJhDSEgDvz?=
 =?us-ascii?Q?yQC+CcROb2HCl1Wr5aclpWDwoYU8NDHnaTtQm8F8IXdHLzyt71pzHc5SPKmi?=
 =?us-ascii?Q?UtbL76+xuSWcJlMcSyAKq5t/qx38VUz7nwObhjZDejUr4mk2DjhiVMakPYxX?=
 =?us-ascii?Q?58ryVN56DC2FqLj6YJTJ9knICt8ySEY920EcXRfx169CxX9p+5wO/UIDrpZ/?=
 =?us-ascii?Q?evL/9/5w/IbrlNjHEl+v8OD62hDLq3OTAh/BJPx6Zoo1wzvWYLo9X/lSx0a5?=
 =?us-ascii?Q?TBmDga82vobhXUkFs6P6T5qNEa0tLkQ5dec8e0G415jbq31kTPlhmaTFzf5r?=
 =?us-ascii?Q?lQySVc6yt3hMlMRjNX/g5c/R3K3StY6jYIAmoe9YTrTr1UAG1CxmMj9Kb4xJ?=
 =?us-ascii?Q?HutiCmYzNtS3C1ppW/mIuF7Tgy/rDcLwKdJepWEji13CUMbjFhPUaGVSXCj/?=
 =?us-ascii?Q?731pjpzStYX4bbpy6ghaf9nnHz7YafDNuOuNk5n5OFsOgxaipsUhI7DIhXGo?=
 =?us-ascii?Q?0AuBSYpGzkUtmNxt2KYaPylGcoNEKIEcIORusoTVNkc2BNAC5yxc8+Ze13MG?=
 =?us-ascii?Q?DmkEjZHBtTBEso5JZ5RHySuP4TXQtUdFDETPtm5oE/nq5kFKB3CpkM5UGpIX?=
 =?us-ascii?Q?E+53alHGZliLBIZL8o9+0t2UVyZHsYYOwE3VqHw6elSfraR2i7NTmdH6ZjPV?=
 =?us-ascii?Q?x+17Dv/71ChHAgeqwAuKbUOhLikjz9iU92xbMNtoSqQlIt9ovAwazB5q4Lcp?=
 =?us-ascii?Q?ll7Rjg3ndUJE298MI4zP+sLz+9EPNiQd6SUWHbFxVnHl91UG1YDCM1U4gM9/?=
 =?us-ascii?Q?9gN/8izAw9rA3XsZPHSBszU63avbEPivguyt0WMH79TyEX0OkowbLwLiZx8F?=
 =?us-ascii?Q?0jT+ZbY/RmRTiIdzoO4/JKtKNaYbfqb/6esvUeiICUqs2TntoQHumCLPkVHE?=
 =?us-ascii?Q?WF3OG6JnTOUaiM9Oexh4I8WkO6FxImhiEVtklgYvzQoNvNQZLMJueGCHA96d?=
 =?us-ascii?Q?j0A1R8Jv1/S0T2Z5Qf+II6tOw3++6bETXHVweM6nhp9bcLeME1Umn9h94Lwg?=
 =?us-ascii?Q?e1y6muubSZ3iCXnYWpEKRVRzpuAaVjnKSSWeZ7GbUft4kfPBq4WD64ZUoz1D?=
 =?us-ascii?Q?3GcZ3Cv4tMSgHZe8V5dA0GU6alqRJ3qrv4RGDNzmtDmE6cIY+vSh+nXiYUWk?=
 =?us-ascii?Q?1T4pyD2y7BAIA93477WhWUmsb1iZXGReB2a6iM0D/ST6bvzPMjuQTPsp9eG6?=
 =?us-ascii?Q?EARDDte8Jy3CA3lAg3lAz8gDb9hvXqrcPLJkxxq2DUlgW6wrv2ivvxoHosPi?=
 =?us-ascii?Q?1qLIgks+DMDtnkEfKjgNAyXOhWwGIg93L2GIUGAgAloIrQwvm5NfjFq3K7Dj?=
 =?us-ascii?Q?p7v/NJ83ORmR0JbPlQd97f9/61AHGn30x3ZWjnjt?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 27214518-51f5-4d52-6c24-08db719ff517
X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2504.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2023 15:06:43.0092
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +TFUdre8/USsGwUq2CMShDCtMm7EQ7zBu4PxKrki+DYX4AmgYhjLVcHQUXZEBd1Q97O5yirEmark2RB0toxiVw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6733
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 20, 2023 at 11:02:00PM +0800, Limonciello, Mario wrote:
> 
> On 6/20/2023 9:58 AM, Huang Rui wrote:
> > On Thu, Jun 15, 2023 at 02:32:25PM +0800, Yuan, Perry wrote:
> >> From: Mario Limonciello <mario.limonciello@amd.com>
> >>
> >> If a user's configuration doesn't explicitly specify the cpufreq
> >> scaling governor then the code currently explicitly falls back to
> >> 'powersave'. This default is fine for notebooks and desktops, but
> > May I know if the processor is powerful desktop such as threadripper,
> > whether it will be default to 'performance' or 'powersave'?
> It's currently defaulting to 'powersave' for desktops and
> workstations.
> 
> Do you think we should adopt performance for these?

Yes, I didn't see any different use cases here between server and
threadripper here. Or I missed anything?

Do we have a way to separate them?

Thanks,
Ray

> 
> >
> > Thanks,
> > Ray
> >
> >> servers and undefined machines should default to 'performance'.
> >>
> >> Look at the 'preferred_profile' field from the FADT to set this
> >> policy accordingly.
> >>
> >> Link: https://uefi.org/htmlspecs/ACPI_Spec_6_4_html/05_ACPI_Software_Programming_Model/ACPI_Software_Programming_Model.html#fixed-acpi-description-table-fadt
> >> Suggested-by: Wyes Karny <Wyes.Karny@amd.com>
> >> Reviewed-by: Gautham R. Shenoy <gautham.shenoy@amd.com>
> >> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> >> ---
> >>   drivers/cpufreq/amd-pstate.c | 7 +++++--
> >>   1 file changed, 5 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> >> index ddd346a239e0..c9d296ebf81e 100644
> >> --- a/drivers/cpufreq/amd-pstate.c
> >> +++ b/drivers/cpufreq/amd-pstate.c
> >> @@ -1102,10 +1102,13 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy)
> >>   	policy->max = policy->cpuinfo.max_freq;
> >>   
> >>   	/*
> >> -	 * Set the policy to powersave to provide a valid fallback value in case
> >> +	 * Set the policy to provide a valid fallback value in case
> >>   	 * the default cpufreq governor is neither powersave nor performance.
> >>   	 */
> >> -	policy->policy = CPUFREQ_POLICY_POWERSAVE;
> >> +	if (acpi_pm_profile_server() || acpi_pm_profile_undefined())
> >> +		policy->policy = CPUFREQ_POLICY_PERFORMANCE;
> >> +	else
> >> +		policy->policy = CPUFREQ_POLICY_POWERSAVE;
> >>   
> >>   	if (boot_cpu_has(X86_FEATURE_CPPC)) {
> >>   		ret = rdmsrl_on_cpu(cpudata->cpu, MSR_AMD_CPPC_REQ, &value);
> >> -- 
> >> 2.34.1
> >>