Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <45a43152-fdf1-5f1e-1a46-0d9798c4090b@amd.com>
Date:   Tue, 20 Jun 2023 09:56:18 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [PATCH v2 1/4] ACPI: CPPC: Add a symbol to check if the preferred
 profile is a server
To:     Huang Rui <ray.huang@amd.com>, "Yuan, Perry" <Perry.Yuan@amd.com>
Cc:     "rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>,
        "viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
        "Sharma, Deepak" <Deepak.Sharma@amd.com>,
        "Karny, Wyes" <Wyes.Karny@amd.com>,
        "Shenoy, Gautham Ranjal" <gautham.shenoy@amd.com>,
        "Li, Sun peng (Leo)" <Sunpeng.Li@amd.com>,
        "Huang, Shimmer" <Shimmer.Huang@amd.com>,
        "Du, Xiaojian" <Xiaojian.Du@amd.com>,
        "Meng, Li (Jassmine)" <Li.Meng@amd.com>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20230615063200.4029760-1-perry.yuan@amd.com>
 <ZJG8w8le9AyRWKzO@amd.com>
Content-Language: en-US
From:   "Limonciello, Mario" <mario.limonciello@amd.com>
In-Reply-To: <ZJG8w8le9AyRWKzO@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?STBENnViM1Y0b2hIMWVlejMvTTVOZkNnUHhGTGNTVDNHUVVwZDExRUR6V1FC?=
 =?utf-8?B?dnprRE1vR1BtL3VaZEpiVHd2bjNRYkloWmJQaVZUME03YVlRZVVTZlYzMmk1?=
 =?utf-8?B?elhTOWprR0RhMnNxbURYMDlZTUZYZG9aamd2M2ZJdjJrRFBaSFFXUElYTE1U?=
 =?utf-8?B?SmtsM1hORHh6UGhuS0JkckRCZDNxWkZEYWFnQjArVC9JZndwV3p0NHAzVnBH?=
 =?utf-8?B?WmpIdXlGblAxY2d3Yit3ejk4SnVQVmd6anBzblp2NjNGckFNZ2RSbXM2TXpi?=
 =?utf-8?B?SUdvZ0t1dkEwYjVPdnVYTjNjODJrSTJHN1M4WHVmcTZ5VFp6eU5Makg4TXFS?=
 =?utf-8?B?TkZDQXJPQjB2YjQ0Nm81NWFQM0JsMGJ1dzBJL2lNUXRENEI5eHB0UmlVako4?=
 =?utf-8?B?QU5Zcm5YV0szT2JKWUxHTzlSVm53ajR2SUFvL1NYa1VqbnA4U0hrT1FmSTl3?=
 =?utf-8?B?WUM2cEQzemlMYnpxcXpiVDd0REk2QXpNSzJ4TlUrc1AzMlJ1cXNBQjdYd081?=
 =?utf-8?B?ZmZPZ3RJekQzazRKcDZZUFozanc4SCtrQmF0WVFLZlZJSzhSYmwrU1RPWjg5?=
 =?utf-8?B?MW00V2VDWTcvS3Y0WG9UVjU3b0hZM2dlVkQ2M0NQZCtoaVBmRTdVL21tY01H?=
 =?utf-8?B?d2poSXNtOHIyc2drR3BYU1dseHpwRjVzQWN1Q25BaFR1NUFURm9oZmd2dDhF?=
 =?utf-8?B?Q0laNTNrQUFna0tvVEhBajRwRVpMNEFGMHZmU0tGd3dRTzBjNjB5U2Q5TmpX?=
 =?utf-8?B?dUZWck0zcHpRM0owUkliVXFsS0g1MGN6OVRFODlIanZEcE4rWklFblBtVmhU?=
 =?utf-8?B?V2dmaWJPUmo2dFYxcHpBTFVFVUZEZHZVT1JiT0YzN3NxK2FBdFdMbnQ0YWpO?=
 =?utf-8?B?cGVlVm1IdkgwcE4wUHRRNmlNWHhoMDlPMlpPWEJTQ2tFOEVrOG5mdWJxcFRk?=
 =?utf-8?B?ZW9mZXM3NG45c3plQS9YZDdJazBZWlppMTA4NzFjTVY5emRHVTVuenJHTFpQ?=
 =?utf-8?B?R1BJTmFtaVh0M3cyc2hFWHdYVXF5Y3Zsd0JzRkhPalB5QkIxZG1GenQxSTNY?=
 =?utf-8?B?Ly9BMWZ1YXlMUjdHS0lyODcvVUJyWWI3YXRibnlJRDdlVzNKTjNzc3JrRy9F?=
 =?utf-8?B?cE9rcXlWTlpoNWpsLy9HVCtUUmdudTJvR1BRazdlKzQvY3RkelVIcXdLWkQ2?=
 =?utf-8?B?Zm41NUZhazVKMDFydUZ2aTNBQnJhOW1KOS94Sm5zek95TGJEYzgyTHBia0I2?=
 =?utf-8?B?MEtOd2hxY2RyVk15V0NhU1NMdXI3NDg0K3B2M1N3N21Uam0wVmovWXNHQklX?=
 =?utf-8?B?WE5aNFVrY2VWWXNTQUhodWNXVVU3SzlNUy95VjVVc204QllPZ0djS0ZGYjBV?=
 =?utf-8?B?ay9ud2ZkYmFWTDdJa3NnM3ZhZ2I0MWZsKzRNNWdNdkluOTNvTXd0TU1jT0d3?=
 =?utf-8?B?Njc5eWJHbWEzT08rRTBTT2dwd3RDMUdBb3ZDNm1SQ0xxYUdHdlN5alZhL05M?=
 =?utf-8?B?QjQ1eDcwNlAxUGIxeHBiMGo4REdwNmFNRU13NnVWMThaUG9GdVFMYXltU1lE?=
 =?utf-8?B?ZUI1Yy9lbVBSZzlkQTdLakdzOXNRSlNEcUw2dGQycHlPRVl5WGJQcmV6RWNk?=
 =?utf-8?B?QWg0bFdWK0NUdnRxRS8zZHkrR28xd1dOeVovM216VUlPdWFQQzQ1TWJSbDQ5?=
 =?utf-8?B?eHZyaHkvYTJZM0h1d3BOSWE3Qjl4WGJRNlU2NmZHa3Z4LzJCemhSeE5SZENV?=
 =?utf-8?B?bENNbDBvMHo5YVVsRDNEVzlTbXVUaVI5WnVJa2lQOFBNcEUzR1krZk5SbkVI?=
 =?utf-8?B?RGdCOUNOeUhNTmFoNnZCS3BLbFc5ZTZubStpOFZRVkErK3o0TW5ZMk95ZVRJ?=
 =?utf-8?B?dkMrU1lTeHBLcDBSY1JBY1Nad1JSQjh6aWFSc3BqVndNVFFTVkhVZ0RuUEJW?=
 =?utf-8?B?ZVZJY0hXRXVrS3cyYmtCWUlOL3FmUjBoa3U0Ni9wTm9BOHFWNUozQjNtdXZG?=
 =?utf-8?B?TUM0Rnc4c3BiYlVIbjlXRzlZUG9aNWd3S2JTVGZhV0NGSi9UL0pkdlNqSGRT?=
 =?utf-8?B?N3ZNdnZDU0loRXNOaHJsaS9LdFp2WFN3alhkNE40bmFwUkFodGk3UU5BV2hU?=
 =?utf-8?Q?4jHYEKgrIVHaNLPCw8G4zyb5o?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9991e76a-aff6-4f7d-b92e-08db719e8351
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2023 14:56:22.6766
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IbnEmckhQCCFc7ukhbseGiZ9PoLPkLcK4ZjuwNs/rhY2IedY6JIwIr60d/FgPifSZENAq8xOiZQm/LZxG5AE1w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7708
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/20/2023 9:50 AM, Huang Rui wrote:
> On Thu, Jun 15, 2023 at 02:32:00PM +0800, Yuan, Perry wrote:
>> From: Mario Limonciello <mario.limonciello@amd.com>
>>
>> This symbol will be used by intel-pstate and amd-pstate for making
>> decisions based on what the FADT indicates the system pm profile is.
>>
>> Suggested-by: Gautham Ranjal Shenoy <gautham.shenoy@amd.com>
>> Link: https://uefi.org/htmlspecs/ACPI_Spec_6_4_html/05_ACPI_Software_Programming_Model/ACPI_Software_Programming_Model.html#fixed-acpi-description-table-fadt
>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
>> ---
>>   drivers/acpi/cppc_acpi.c | 34 ++++++++++++++++++++++++++++++++++
>>   include/acpi/actbl.h     |  3 ++-
>>   include/acpi/processor.h | 10 ++++++++++
>>   3 files changed, 46 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c
>> index 7ff269a78c20..d8827eae3ba4 100644
>> --- a/drivers/acpi/cppc_acpi.c
>> +++ b/drivers/acpi/cppc_acpi.c
>> @@ -941,6 +941,40 @@ void acpi_cppc_processor_exit(struct acpi_processor *pr)
>>   }
>>   EXPORT_SYMBOL_GPL(acpi_cppc_processor_exit);
>>   
>> +
>> +/**
>> + * acpi_pm_profile_server() - Check if the system is a server.
>> + *
>> + * Return: true for server profiles, false for anything else
>> + */
>> +bool acpi_pm_profile_server(void)
>> +{
>> +	switch (acpi_gbl_FADT.preferred_profile) {
>> +	case PM_ENTERPRISE_SERVER:
>> +	case PM_SOHO_SERVER:
>> +	case PM_PERFORMANCE_SERVER:
>> +		return true;
>> +	}
>> +	return false;
>> +}
>> +EXPORT_SYMBOL_GPL(acpi_pm_profile_server);
>> +
>> +/**
>> + * acpi_pm_profile_undefined() - Check if the system is an undefined pm profile.
>> + *
>> + * Return: true for undefined profiles, false for anything else
>> + */
>> +bool acpi_pm_profile_undefined(void)
>> +{
>> +	if (acpi_gbl_FADT.preferred_profile == PM_UNSPECIFIED)
>> +		return true;
>> +	if (acpi_gbl_FADT.preferred_profile >= NR_PM_PROFILES)
>> +		return true;
> May I know the acpi_gbl_FADT.preferred_profile value of powerful desktop
> such as threadripper or AM4/AM5 socket types of processors?

I have a Threadripper for my workstation, and it's:

[02Dh 0045   1]                   PM Profile : 01 [Desktop]

> I am thinking whether we can use this way to differentiate powerful desktop
> and mobile platforms.

On a Rembrandt laptop it's:

[02Dh 0045   1]                   PM Profile : 02 [Mobile]

Given Raphael's comments about intel-pstate preferring not to
match "SOHO server" as a server, I am planning to move these functions
into amd-pstate directly and drop patch 4.
> Thanks,
> Ray
>
>> +	return false;
>> +}
>> +EXPORT_SYMBOL_GPL(acpi_pm_profile_undefined);
>> +
>> +
>>   /**
>>    * cpc_read_ffh() - Read FFH register
>>    * @cpunum:	CPU number to read
>> diff --git a/include/acpi/actbl.h b/include/acpi/actbl.h
>> index e5dfb6f4de52..451f6276da49 100644
>> --- a/include/acpi/actbl.h
>> +++ b/include/acpi/actbl.h
>> @@ -307,7 +307,8 @@ enum acpi_preferred_pm_profiles {
>>   	PM_SOHO_SERVER = 5,
>>   	PM_APPLIANCE_PC = 6,
>>   	PM_PERFORMANCE_SERVER = 7,
>> -	PM_TABLET = 8
>> +	PM_TABLET = 8,
>> +	NR_PM_PROFILES = 9
>>   };
>>   
>>   /* Values for sleep_status and sleep_control registers (V5+ FADT) */
>> diff --git a/include/acpi/processor.h b/include/acpi/processor.h
>> index 94181fe9780a..05a45ebddaea 100644
>> --- a/include/acpi/processor.h
>> +++ b/include/acpi/processor.h
>> @@ -360,6 +360,8 @@ int acpi_get_cpuid(acpi_handle, int type, u32 acpi_id);
>>   #ifdef CONFIG_ACPI_CPPC_LIB
>>   extern int acpi_cppc_processor_probe(struct acpi_processor *pr);
>>   extern void acpi_cppc_processor_exit(struct acpi_processor *pr);
>> +extern bool acpi_pm_profile_server(void);
>> +extern bool acpi_pm_profile_undefined(void);
>>   #else
>>   static inline int acpi_cppc_processor_probe(struct acpi_processor *pr)
>>   {
>> @@ -369,6 +371,14 @@ static inline void acpi_cppc_processor_exit(struct acpi_processor *pr)
>>   {
>>   	return;
>>   }
>> +static inline bool acpi_pm_profile_server(void)
>> +{
>> +	return false;
>> +}
>> +static inline bool acpi_pm_profile_undefined(void)
>> +{
>> +	return true;
>> +}
>>   #endif	/* CONFIG_ACPI_CPPC_LIB */
>>   
>>   /* in processor_pdc.c */
>> -- 
>> 2.34.1
>>