Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9e3577fa-2bd2-da2a-bc35-5e70f49e011d@amd.com>
Date:   Tue, 20 Jun 2023 10:18:30 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [PATCH v2 2/4] cpufreq: amd-pstate: Set a fallback policy based
 on preferred_profile
Content-Language: en-US
To:     Huang Rui <ray.huang@amd.com>
Cc:     "Yuan, Perry" <Perry.Yuan@amd.com>,
        "rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>,
        "viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
        "Sharma, Deepak" <Deepak.Sharma@amd.com>,
        "Karny, Wyes" <Wyes.Karny@amd.com>,
        "Shenoy, Gautham Ranjal" <gautham.shenoy@amd.com>,
        "Li, Sun peng (Leo)" <Sunpeng.Li@amd.com>,
        "Huang, Shimmer" <Shimmer.Huang@amd.com>,
        "Du, Xiaojian" <Xiaojian.Du@amd.com>,
        "Meng, Li (Jassmine)" <Li.Meng@amd.com>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20230615063225.4029929-1-perry.yuan@amd.com>
 <ZJG+Xhun1Ltw9ox/@amd.com> <bffb7ba1-c8cd-2653-94a6-e0b5cb52bc49@amd.com>
 <ZJHAatXe+iVzM/JS@amd.com>
From:   "Limonciello, Mario" <mario.limonciello@amd.com>
In-Reply-To: <ZJHAatXe+iVzM/JS@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZmtLRFh4QzdtcjI0RGFSNms3anhab1NURko4UDJNZUlhd05tZHZwaktjUUZF?=
 =?utf-8?B?OTJhb1JrS0xKcFJuMDltREtnemNBazdWN2UyMWNsYlpDc3ZLNW5yeFZwR01t?=
 =?utf-8?B?VFpNUmVUai9ISzVpK0ZrQTRPNGFKM1JoNWE2LzFYOSs5V0tUZjFqU0o2Vm96?=
 =?utf-8?B?L3FnU2ZYOHQ2dWQzRUtsU0xscEJNbkdodk9vdktvb0M1Rk9pd0RQOGE0VGZl?=
 =?utf-8?B?ZGRRK2hMWW5BTkVFbEo1WFo0K2J2ODZjQ2ZsWk5UNy80bW1xN0Jka2U1ckR6?=
 =?utf-8?B?a1VLdG9uTGh3K0lKaFNBTUkwOUpwMHc0T1U4K3cvYjU4OG43UXJnWFhlSlVx?=
 =?utf-8?B?NGM3cndoMTJuRTV6SGNCa1NRUnhSV290T0wyU1VwR1Y0aG5XTE1QNG9nTFdw?=
 =?utf-8?B?WWJyN1lPUW00WjRJZ2x4aHdDWW5GRFNuVzdqVm9ZYklWY21ZanZ3ZTZ2cGpj?=
 =?utf-8?B?emdFN3QzSnZmVU10WTZJa3JiV015am1rYnJSZTFpVVp4a3lpZUFCUzdZQWEy?=
 =?utf-8?B?RTZjNHFPT1NtcFRpajRvdG00cGdCeWVSZ2V0YlBwZjBjWWs1YS9nS1dwb3ZX?=
 =?utf-8?B?NXptUGt4UDRDeUV0U0lRRXNmR09Za1ZMOVRocnJubE1KVm1BaWphSE1zZGFJ?=
 =?utf-8?B?K24zRXJwYkhGV3ZGKzJxWVVnMjE2U1Y2VHEzNnRyQlBtQzRuYkRqRHZzamRt?=
 =?utf-8?B?M1I4STBOSkZoemNKTHJHRk1vVFRZcHFmeHpEdWRrZUE2ekptaXpWeEFlTFVz?=
 =?utf-8?B?V1FCUkg4MEQ4UmF4dk45L3JXZ0t6cmtBcHpJQmdMVlBaVlp1bHZ2RnhGRmxT?=
 =?utf-8?B?Z1hKKzBDbUY5YXZ0YTFlUFo5RGhXeUxaV2ViVEpHN3QwZWovYTF6MWtTdlpQ?=
 =?utf-8?B?MWJEc0ZaaUl0SkpyTFgxL2I0RWhSNUZXOXhDeklvTjZERUxwRXdneFR6QVFY?=
 =?utf-8?B?RjA2eThETFNuTTdFK25TcUlxa2Z4TWdQRk5TTVRDR2NjN2V0N3R1eXJpVjJS?=
 =?utf-8?B?Ni9DNVo3QXRaUXpJV1hZdk1zdXhzK3FOY3JnNGJlUTgvNWp5QW5qdERMWnht?=
 =?utf-8?B?bkNnQURWSUgzRnV3OVMxVTFhV2phbHREcWxLZXErOTZzTnpOZXZVMms4NFZJ?=
 =?utf-8?B?WGwzTU1iNUptQXg3ZWFEeFZ2VS95VHNFanVJREpuUHAxSHlLUTdYSFZTYnpa?=
 =?utf-8?B?dWtYMmFFbHhmMXNTc1NTOHBueTFpc0kwWDNiTDl0QzNTYUZuOGtQWWlRUFdi?=
 =?utf-8?B?ZTR4NTNGSzJjVXdYS0IrWnllRGFqa2p2aDdOSXdwazVFUjIxQmtvQ3oxMjMy?=
 =?utf-8?B?ZmZoYlIwclcycm9jRFllTFMzODVJOFpZS2tidnY0VFY4ZEtqT3VlUnVoWUhN?=
 =?utf-8?B?cVNURXJlYkZZZ3ZoRjNpQ1N1T1dwMmZXNmxDUlNsZVRvRTJKeXJDUVNrTVcr?=
 =?utf-8?B?MGtRU1l0R293NEZxT2t1NXR6NERQZjQ4WUllSnNzRE1BNVZKalRCbnFGdzZI?=
 =?utf-8?B?WjVjaWZOZGlaNmV3cU5WdUFHQkh3Y05aTEl5QnNCSzRjWDIrK09uQ2VtZFFC?=
 =?utf-8?B?M0kxZnVsVWpYdUE0Y3oxd2JaYUExaS9vNGhmUW5FV3JsNEgrVENCQ1J2VFo0?=
 =?utf-8?B?d2h2dTBhN1NVVEtHUjVlNi9TdU5NMUxUa29YNDBTakdlS2lDbGN6RHphN0lH?=
 =?utf-8?B?WWlqdWJNaXMyRVhNSzBvY0IyRFlCRVJldzhmZkRYekhJaU5EOGNqbnNBVzB4?=
 =?utf-8?B?elJsOXJzK1luaVZXclpnZGVGQ2NPbFNITFlLK0VpRWxaT2Y1TXorelFOdXBP?=
 =?utf-8?B?aCtndUJsTHVuYmFKTFpPWDNsK0lPallZOU02d1RYNVowNnhoeGVsRXl3dWFi?=
 =?utf-8?B?SnE5bkcrUTVqWUFsMWJFdlJjcGdnL2o3MUhuc1Q4ZGFURno0VGNvaTEyQW10?=
 =?utf-8?B?UlVrakYzKzBDR09ZTlNIM2ZGRFRQNkFEWUVTUkNuTzhVc2xoNGxvY2tQK09t?=
 =?utf-8?B?TytYZFZhd0p6NTJoTUNZNVlPUDhEbWVackdmaGVFTis3amRIbXRid2luVWZK?=
 =?utf-8?B?UVRkNnp3L0NNZ3ZsazdhRXFycVVPVVVSWmdmZ2lUS3FvRU12R2phY2FsYWZo?=
 =?utf-8?Q?MM/oDSWfDA0lqr2Y5vHsXju7t?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1a1548df-d783-4aef-53e2-08db71a19c8d
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2023 15:18:33.4566
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3+DA6zuyXy1u7Q26Vw814FF13jLtCxWT0IjJiiDpk4QLrglBELxyq0/NS9WUm8Yc+4dKcMBkw8PdOZcAh1j7tQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6267
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/20/2023 10:06 AM, Huang Rui wrote:
> On Tue, Jun 20, 2023 at 11:02:00PM +0800, Limonciello, Mario wrote:
>> On 6/20/2023 9:58 AM, Huang Rui wrote:
>>> On Thu, Jun 15, 2023 at 02:32:25PM +0800, Yuan, Perry wrote:
>>>> From: Mario Limonciello <mario.limonciello@amd.com>
>>>>
>>>> If a user's configuration doesn't explicitly specify the cpufreq
>>>> scaling governor then the code currently explicitly falls back to
>>>> 'powersave'. This default is fine for notebooks and desktops, but
>>> May I know if the processor is powerful desktop such as threadripper,
>>> whether it will be default to 'performance' or 'powersave'?
>> It's currently defaulting to 'powersave' for desktops and
>> workstations.
>>
>> Do you think we should adopt performance for these?
> Yes, I didn't see any different use cases here between server and
> threadripper here. Or I missed anything?
Workstations and Desktops usually have to go through energy
consumption certifications.  Couldn't setting it to performance be
inappropriate for those?
> Do we have a way to separate them?

If Threadripper identified as

3 Workstation

I'd agree; but I'd think we're going to lump AM4/AM5 desktops
along with Threadripper.  So should we still set all those to performance?

>
> Thanks,
> Ray
>
>>> Thanks,
>>> Ray
>>>
>>>> servers and undefined machines should default to 'performance'.
>>>>
>>>> Look at the 'preferred_profile' field from the FADT to set this
>>>> policy accordingly.
>>>>
>>>> Link: https://uefi.org/htmlspecs/ACPI_Spec_6_4_html/05_ACPI_Software_Programming_Model/ACPI_Software_Programming_Model.html#fixed-acpi-description-table-fadt
>>>> Suggested-by: Wyes Karny <Wyes.Karny@amd.com>
>>>> Reviewed-by: Gautham R. Shenoy <gautham.shenoy@amd.com>
>>>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
>>>> ---
>>>>    drivers/cpufreq/amd-pstate.c | 7 +++++--
>>>>    1 file changed, 5 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
>>>> index ddd346a239e0..c9d296ebf81e 100644
>>>> --- a/drivers/cpufreq/amd-pstate.c
>>>> +++ b/drivers/cpufreq/amd-pstate.c
>>>> @@ -1102,10 +1102,13 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy)
>>>>    	policy->max = policy->cpuinfo.max_freq;
>>>>    
>>>>    	/*
>>>> -	 * Set the policy to powersave to provide a valid fallback value in case
>>>> +	 * Set the policy to provide a valid fallback value in case
>>>>    	 * the default cpufreq governor is neither powersave nor performance.
>>>>    	 */
>>>> -	policy->policy = CPUFREQ_POLICY_POWERSAVE;
>>>> +	if (acpi_pm_profile_server() || acpi_pm_profile_undefined())
>>>> +		policy->policy = CPUFREQ_POLICY_PERFORMANCE;
>>>> +	else
>>>> +		policy->policy = CPUFREQ_POLICY_POWERSAVE;
>>>>    
>>>>    	if (boot_cpu_has(X86_FEATURE_CPPC)) {
>>>>    		ret = rdmsrl_on_cpu(cpudata->cpu, MSR_AMD_CPPC_REQ, &value);
>>>> -- 
>>>> 2.34.1
>>>>