Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp8094302rwd; Tue, 20 Jun 2023 10:04:10 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6QUeTp8svuCeHn4fSiaeq6UprAZ0GGjricwJ+x0LHq+okbpunDosYqDZFmuGvC3uTkV7kR X-Received: by 2002:a17:903:41d0:b0:1b5:5a5f:369e with SMTP id u16-20020a17090341d000b001b55a5f369emr4028133ple.8.1687280650301; Tue, 20 Jun 2023 10:04:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687280650; cv=none; d=google.com; s=arc-20160816; b=vJbTtAR9qNUE7nyZu/A3CaoYQPY6hykFuaDujKDMH66kk5r9rd0PrKdijfpvYa+gbf Mm2ETBjECj58d8pRRT8TDtyo35kvAbYv6+8bYiWV39WkJ9pmR6rMm97giV8Peorc9QWS mivVsAMoc2nvzIVUTZfEoWi1dzdphDxJtkIJzgpscI6KJAPJSbf526pbSjLjMNvzbRe4 /30bBUVXeleQNLCybvAfr/lN6kj9TDyrN3OzAooPK9RBgNQWGZuYg6dCav4897N01Cc0 AXwr5gUj+gUeHcRdm6r0yI4/zkYeGRUi9YU07mwjztWzRxzBR8IibmnluxBB+WzY7358 0JWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=gBubEJMPe6G0USGcorQTi4ZIGnN3IKmG8U2Ee3eGzro=; b=mhjQ03mZ8ue82tuCuqGmtnXWX89nOtRTbKzsgIRvK51q+UPg1PyD2DiT19d1wmXjQ6 h72oxEoGEnFosv1oG1FTr/uJ1GbANZyTscumxpxbOD/Ce4u10Xxc6qJT4/XKDO0FmWck KRtfcQ9bZ2DnVj4NzpgRg+b+rxX0eUWXreYEsKDsa08mAfKAqDvk1KLFs5gUKOdgP3eE TjfAjhhpRzNjHpIp2VgpbHJD4rV+HHvW6MVt7ebFMeDwUMZYBwbPPNg+58XuV0uy481D rh1u5IfhD6l3Dyai5RmOAW8PK2PD8zNYtDCDdKVL7T1t++GsgvXHNGhkzRo5k9ttY1Pn elOQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p18-20020a170902ebd200b001aaf5dcd774si2267197plg.173.2023.06.20.10.03.50; Tue, 20 Jun 2023 10:04:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229874AbjFTQiY (ORCPT + 99 others); Tue, 20 Jun 2023 12:38:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229693AbjFTQiX (ORCPT ); Tue, 20 Jun 2023 12:38:23 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:237:300::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A676C0; Tue, 20 Jun 2023 09:38:21 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1qBeMo-0002WT-Fi; Tue, 20 Jun 2023 18:38:06 +0200 Date: Tue, 20 Jun 2023 18:38:06 +0200 From: Florian Westphal To: Igor Artemiev Cc: Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S . Miller" , Paolo Abeni , Jakub Kicinski , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: Re: [lvc-project] [PATCH] netfilter: ebtables: remove unnecessary NULL check Message-ID: <20230620163806.GB3799@breakpoint.cc> References: <20230620152549.2109063-1-Igor.A.Artemiev@mcst.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230620152549.2109063-1-Igor.A.Artemiev@mcst.ru> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Igor Artemiev wrote: > In ebt_do_table() 'private->chainstack' cannot be NULL > and the 'cs' pointer is dereferenced below, so it does not make > sense to compare 'private->chainstack' with NULL. ? Why do you think that? > + cs = private->chainstack[smp_processor_id()]; Looks like NULL deref to me. Did you test this?