Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Li, Xin3" <xin3.li@intel.com>
To:     Thomas Gleixner <tglx@linutronix.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "platform-driver-x86@vger.kernel.org" 
        <platform-driver-x86@vger.kernel.org>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
        "linux-perf-users@vger.kernel.org" <linux-perf-users@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>
CC:     "mingo@redhat.com" <mingo@redhat.com>,
        "bp@alien8.de" <bp@alien8.de>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "hpa@zytor.com" <hpa@zytor.com>,
        "steve.wahl@hpe.com" <steve.wahl@hpe.com>,
        "mike.travis@hpe.com" <mike.travis@hpe.com>,
        "Sivanich, Dimitri" <dimitri.sivanich@hpe.com>,
        "Anderson, Russ" <russ.anderson@hpe.com>,
        "dvhart@infradead.org" <dvhart@infradead.org>,
        "andy@infradead.org" <andy@infradead.org>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
        "will@kernel.org" <will@kernel.org>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "kys@microsoft.com" <kys@microsoft.com>,
        "haiyangz@microsoft.com" <haiyangz@microsoft.com>,
        "wei.liu@kernel.org" <wei.liu@kernel.org>,
        "Cui, Dexuan" <decui@microsoft.com>,
        "dwmw2@infradead.org" <dwmw2@infradead.org>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "acme@kernel.org" <acme@kernel.org>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>,
        "alexander.shishkin@linux.intel.com" 
        <alexander.shishkin@linux.intel.com>,
        "jolsa@kernel.org" <jolsa@kernel.org>,
        "namhyung@kernel.org" <namhyung@kernel.org>,
        "irogers@google.com" <irogers@google.com>,
        "Hunter, Adrian" <adrian.hunter@intel.com>,
        "Christopherson,, Sean" <seanjc@google.com>,
        "jiangshanlai@gmail.com" <jiangshanlai@gmail.com>,
        "jgg@ziepe.ca" <jgg@ziepe.ca>,
        "yangtiezhu@loongson.cn" <yangtiezhu@loongson.cn>
Subject: RE: [PATCH 2/3] x86/vector: Replace IRQ_MOVE_CLEANUP_VECTOR with a
 timer callback
Thread-Topic: [PATCH 2/3] x86/vector: Replace IRQ_MOVE_CLEANUP_VECTOR with a
 timer callback
Thread-Index: AQHZowfgzs/ltzhQV02KS6H0RArmlq+TXriAgACUhrA=
Date:   Tue, 20 Jun 2023 17:30:41 +0000
Message-ID: <SA1PR11MB6734113E845FC51ED01CE4CBA85CA@SA1PR11MB6734.namprd11.prod.outlook.com>
References: <20230619231611.2230-1-xin3.li@intel.com>
 <20230619231611.2230-3-xin3.li@intel.com> <87h6r2pm1a.ffs@tglx>
In-Reply-To: <87h6r2pm1a.ffs@tglx>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?N11wu+DVgoFHIBNf7A4Twi4A6I8JO8j2T1uQhJrc02CGiP67ZdvM0vkgrwfB?=
 =?us-ascii?Q?deyLqHEJVMvZseWM654OR6QI2b9wJU+F5RnvtgoCGRF1SsxaKp5CoY6eKlqf?=
 =?us-ascii?Q?lvD2iueidNAGwTQekVAGTUe37hE94toXVTppaQg6/h4NTrxUUtzJHpGE2hte?=
 =?us-ascii?Q?q3QASOslW6VaAZFvd1/4mMtj3khBWS/xiHGYzWVayaSdqORZDdJYFFjqKCMP?=
 =?us-ascii?Q?Qsy9eRr1rtIIJ92KvzCZ8iqka7C02OvhvcQtA15TTsSNTnn2WlGwhzaNbVqj?=
 =?us-ascii?Q?O1gvL5IH33+TccBfvkJE4LzI67tqLPNRZIwdz9wetcWRNcDRXZ5PKm85wgXH?=
 =?us-ascii?Q?rKV9dx0WG0F/kx0GH9m9ulzcdkDA4zKabJVa4Sp+JIABK5lqcPPqa1dm6rTK?=
 =?us-ascii?Q?9jkUvU2hX6y/jGS+HngM2vWhQmxOS5gC5acZPFZ9gJsLw2GHQGumE7EO1Xga?=
 =?us-ascii?Q?CfPVDMCi336+dpvq+LELVHjnYl82pbVF5uUFSYBLB9XwSWMMJUciis+ZLhLP?=
 =?us-ascii?Q?Rvp8wsD/sHmNvDPlbByJAPiUJyv5fMCAoEJzQFUyQH4omzhEv94NPHIzo0br?=
 =?us-ascii?Q?bagd/6ssrriCbEiQtziQGnXkLPKlZudUUCkgxa71nJhRR/dF0ekvcfDtVQAm?=
 =?us-ascii?Q?/icaBzhcbo7vI8+JG5BPTVMPioN2ExivuiKfZJt2sQdT04tOKo+Fk5uKr8FV?=
 =?us-ascii?Q?iubPwA50PcgpnRvtoNFCUPIirgbjkazOTtpG/bInKhlEkodPdRX7WXAg9XqN?=
 =?us-ascii?Q?ccNRsSP1AK76RnjH5wxkvig6e90/oJKjYduZCZWYtq/07ZWLGJQJYQPlSBfe?=
 =?us-ascii?Q?tc9nNhW1WSTEISWHIlcqzgjkS1fM/0r8MqWbycftv9bzLXpBiYWxhUqljxfX?=
 =?us-ascii?Q?WJsHMYPOz2Z3rBSmplY4Ty+gNZE5suPtJHg+lpb2aUmIA8N05NJwwohTTob1?=
 =?us-ascii?Q?BGYA7XwKbIz2HcMA4JYlXg9rXoLzqzsOZtjCtiFoRbNhMAeCmy1d8kM9Iabp?=
 =?us-ascii?Q?kE48gILJeTou7wUnrPcfmMAnhY/tOjqt02nfTO8Co+n+osrTDAoZSJwddizv?=
 =?us-ascii?Q?OMReWKCHqGpAfnEMkbF38Puw0uG9HQnWzhsMHtNf/3mq3x+42yIIh4cHmcdU?=
 =?us-ascii?Q?ZCYOd+jOuDi7/hkYKzvjL+YODtDXGP3ohT4JAg23snu0y+ABs+lVfsVS9GeE?=
 =?us-ascii?Q?D4vvouV83W1jAuVwjZVpxv+9NDoowYCrOUYgpOvlPP8r3Rofun1xF9+ikgyA?=
 =?us-ascii?Q?3rAJmqFaX8CdDlG/OOwVWCBqPhOKeqzdiz84jAgE/GphcSgFYZ8KhQPoDnEC?=
 =?us-ascii?Q?MEDYjw+xzQooHdPoG4sZDijSvH7sdeQTuvdYEkAJARwf5YlUHz0z7lkD/2v5?=
 =?us-ascii?Q?xrDkZfo2SWzxYKIgSVkBvQCOikTPY59bowp8F5FAEJdJsgXPnethIaC6gyoa?=
 =?us-ascii?Q?X+/SAsZc8kewVGWNYMummgT8kFYCKsiQK3vMmH0/embWSXw0D/dqHLQ/p8b4?=
 =?us-ascii?Q?ST/HcvWwvmx0m7O5pv/r/xgjJSfeDCFPjAyet73YQqv1U0FxiO9oNg3r4ELD?=
 =?us-ascii?Q?X0zfWsEASXkZ3koUtOE=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6734.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d6a34217-4f0b-467c-aad7-08db71b4125f
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jun 2023 17:30:41.8937
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: HJcn+6q2INcm1EO8cRvu3spOAlL07ysrY8JsYiwjA+nJJRjlbC+JR5jzluKcAit4Jn7LGnGDCx587z5POJkKZg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB8596
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > +/*
> > + * Called with vector_lock held
> > + */
>=20
> Such a comment is patently bad.
>=20
> > +static void __vector_cleanup(struct vector_cleanup *cl, bool
> > +check_irr)
> >  {
>         ....
>=20
>         lockdep_assert_held(&vector_lock);
>=20
> Documents the requirement clearly _and_ catches any caller which does not=
 hold
> the lock when lockdep is enabled.

Peter Z gave the same comment, I will address in the next iteration.

Thanks!
  Xin