Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp8188069rwd; Tue, 20 Jun 2023 11:21:46 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5DS1iKp2t9p0jE4X+O8AuuFeEx46TBPkO8XjTm3hGcXBJ2vt8TEiii8A/iKz4kbwiEXk2z X-Received: by 2002:a9d:6c14:0:b0:6b4:54f6:59d2 with SMTP id f20-20020a9d6c14000000b006b454f659d2mr9771940otq.3.1687285305889; Tue, 20 Jun 2023 11:21:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687285305; cv=none; d=google.com; s=arc-20160816; b=swN7pyzlDPn0Nafz76Dj6ERYCuaDl4HpHhzi4r9enjQJO131UpgyKQRJnQafTxW/2k 0GWXLehlnSezeih8DOu2oKTJfPqs5+Ae+0sI6ncnJMzfe0YAibyPjngP74HkIyfN05V3 f7Z/ZThNoHW1Xabrrk7Pcber1qNfcdyIcJRf4C8YX90C0sfUTXoHpOdduprjyFbdkmaY EE6nZea7cd52m3WJKtR9P/RpB6xawpLZikmN4k984LH4X0SkBDc8bFHyO98hK5HQ8xh2 yNjGmmx9yRaW9BCGwoANG8Vf6tnDVd4OoN1b1zfqL0sF/Ch/jfVr9DeWnYTP7Nx4Da4v 1vig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=YEQQedTfk3CvXMUEMnX/qgx0uD7Zg1KalwFUtarcHWE=; b=XOi7lKdXxuB9AyFr+lyYLKI6Z1257VArWo4UVR8Q8JP1h2bbVhwTOb0XdyZieKLQYZ vSIxS31s7CiFROtXpe6kUdhIgiWHf6iadHQbuWlW/Xy1zhqAWPicZnuRBVEsGEF+5qYX LvO8mFFw3CfVoYX31UGuC9dtn6uPBF6I+CXq3EEDYiMIKgCNDT3fbXUdXo6Q0aeY0zYF P4QTL5my3k6O2dHK+wyGR3TkI4QGp2RgTxMMK17UbRRsKukl/EZqp0vQ644xhaeP03Rt c4RhzMH0Nlzoa5iv8+ZFj/ZTv7KePt//t0Z2D9mL1Ru3N11IVnhxqXXR2F2lScInTUew JFBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b="X/h+sRHN"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bs123-20020a632881000000b00542ad648fbasi2144924pgb.188.2023.06.20.11.21.31; Tue, 20 Jun 2023 11:21:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b="X/h+sRHN"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230235AbjFTRrv (ORCPT + 99 others); Tue, 20 Jun 2023 13:47:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229932AbjFTRrs (ORCPT ); Tue, 20 Jun 2023 13:47:48 -0400 Received: from mail-yw1-x1130.google.com (mail-yw1-x1130.google.com [IPv6:2607:f8b0:4864:20::1130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E885D1712; Tue, 20 Jun 2023 10:47:47 -0700 (PDT) Received: by mail-yw1-x1130.google.com with SMTP id 00721157ae682-570002c9b38so54473697b3.1; Tue, 20 Jun 2023 10:47:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687283267; x=1689875267; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=YEQQedTfk3CvXMUEMnX/qgx0uD7Zg1KalwFUtarcHWE=; b=X/h+sRHNzsC5FcGaSJrO3tW4Rxpa34N3Cmd54bilvTz2qbld2ShNygzXL/zF3Wgqle CDVm9DgJt8tLMxVoBvVepefDiFSu1w1y7L5sZ7UfLCLDo1XvLZ6a7dsZdqO7QjzJB5NA 5ZdUE/wxeA5cSFZML9vW0f1d3UWGXpjBv1RqsbdfK1kXFusynnjw5nYDl+k2UAdQCLUK VjRGCApYXDho5KvtigNiBCfsv4Nal8NCc4EkKTJfVlFJ2VnxAN4ZiV9RQpPqa6EgFOFT ZNQJtgo5NT/eG67C4qRuPwrIYglj8cobVjHPzMBKhdw/wkm5H83kdSSEq2Ih8Zk3eB1/ q58g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687283267; x=1689875267; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YEQQedTfk3CvXMUEMnX/qgx0uD7Zg1KalwFUtarcHWE=; b=NsZjSMCU0jx7Ii+veVnUU1W+3ipV+XLqwCOFL17a6tU3ZwD2+x7RkfK9Qxkgv3d9XV VPi5Yw/vKPrkMCJUjs/13yimmrsGzCaBbx6sRbPQVu9doakciZCCosZqi8KQhObhQckp UwNOiDXV99imdsa8R4lMzZ4BWWuMLHSdW/7Q3JHsCPNYusDG6b9QNDbWLWTNITd1Dpsa LLjA4f4s6TDEZNHgofz5+RfbGVVGINjTerLAtG2Z0KI5NOTFcWoSN9fYAzDXiB+nNtW3 OyUyp1a0QggxFAZzU1CYjiTMYRgEeeVMIEz+m0n/HqCrf8nUUs2dwfMhUN8gR9vrAIzK /91Q== X-Gm-Message-State: AC+VfDx3OI483d1+Wx2fZRxDgXcQY7MzKouO9L74Unor8CkNWc6YRhMF +Ht7s32kDOFO5wY/9MHlFbE+RdzqII/qloQCL5I= X-Received: by 2002:a81:468b:0:b0:573:98a3:f01a with SMTP id t133-20020a81468b000000b0057398a3f01amr951191ywa.40.1687283267004; Tue, 20 Jun 2023 10:47:47 -0700 (PDT) MIME-Version: 1.0 References: <520e2be4-726f-c680-c010-a308cdddbae0@arm.com> <90823b33-1f44-8789-9a38-282407fd9f15@arm.com> In-Reply-To: From: Alexander Duyck Date: Tue, 20 Jun 2023 10:47:09 -0700 Message-ID: Subject: Re: Question about reserved_regions w/ Intel IOMMU To: Jason Gunthorpe Cc: Robin Murphy , "Tian, Kevin" , Alex Williamson , Baolu Lu , LKML , linux-pci , "iommu@lists.linux.dev" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 20, 2023 at 9:55=E2=80=AFAM Jason Gunthorpe wr= ote: > > On Tue, Jun 20, 2023 at 07:57:57AM -0700, Alexander Duyck wrote: > > > I think this may have gone off down a rathole as my original question > > wasn't anything about adding extra reserved regions. It was about > > exposing what the IOVA is already reserving so it could be user > > visible. > > Your question points out that dma-iommu.c uses a different set of > reserved regions than everything else, and its set is closer to > functionally correct. > > IMHO the resolution to what you are talking about is not to add more > debugging to dma-iommu but to make the set of reserved regions > consistently correct for everyone, which will make them viewable in > sysfs. Okay, that makes sense to me, and I agree. If we had a consistent set of reserved regions then it would make it easier to understand. If nothing else my request would be to expose the iova reserved regions and then most likely the other ones could be deprecated since they seem to all be consolidated in the IOVA anyway. Thanks, - Alex