Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 20 Jun 2023 10:25:21 -0700
From:   Lucas De Marchi <lucas.demarchi@intel.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
CC:     Jani Nikula <jani.nikula@linux.intel.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        <intel-gfx@lists.freedesktop.org>,
        Kevin Brodsky <kevin.brodsky@arm.com>,
        <linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
        Christian =?utf-8?B?S8O2bmln?= <christian.koenig@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        "Thomas Gleixner" <tglx@linutronix.de>,
        Masahiro Yamada <masahiroy@kernel.org>,
        <intel-xe@lists.freedesktop.org>
Subject: Re: [Intel-xe] [PATCH 2/3] linux/bits.h: Add fixed-width GENMASK and
 BIT macros
Message-ID: <amgwl5mthhqgvgkqnor6tjfcr3x3pgwvpqin5efwwjfpdhvvpa@vhzhiq5mzsdg>
References: <20230509051403.2748545-1-lucas.demarchi@intel.com>
 <20230509051403.2748545-3-lucas.demarchi@intel.com>
 <ZF4fi5B7PPlgZBOI@smile.fi.intel.com>
 <87pm75kd0h.fsf@intel.com>
 <ZF4j0NPoBGMBT8CO@smile.fi.intel.com>
 <87mt29kc34.fsf@intel.com>
 <ZIs0CC2J7nu0LHEK@smile.fi.intel.com>
 <875y7igph5.fsf@intel.com>
 <ZJG91zMQW3Rnvdbe@smile.fi.intel.com>
Content-Type: text/plain; charset="us-ascii"; format=flowed
Content-Disposition: inline
In-Reply-To: <ZJG91zMQW3Rnvdbe@smile.fi.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KCPkbAol7CUjdAYXkTrSTO11ByEfovwuBjd1gKzr1l+Vztf/pVkwHcI7/1dU?=
 =?us-ascii?Q?WVEzOzgfuCfDizplfG9Ofl3mfxpTuireE9sq2DvIwR+bg+Wj3oT1MYel4siT?=
 =?us-ascii?Q?uSJo8f9oFipfRntWJtnfae0MIm2VCenAR5EPpnMy1VwVT0UgiHhKvfv5exB6?=
 =?us-ascii?Q?wy6cv+Bvt9MAueLDFevh/oevvXUwjT+kNxZd6J4T4keyKty083P4ARk3T8Qo?=
 =?us-ascii?Q?Lv937EGzRB12w4zRJffuOnDWrt09Y9/UZrmg0zXahh9jyw7MDzOYQdMq2jVD?=
 =?us-ascii?Q?AOkaXa436MK5TZFKEO4tc2A4JMDrquZ6F+sN+ZgmUdYJkLj3dAMREICajJf8?=
 =?us-ascii?Q?DMVAj2linoqCk1w7iGdQm3wTc+gKRY3pKLa94VbvItVJtz55saULGt3e4EMV?=
 =?us-ascii?Q?0JdxP5CwgS6B66eg5+QI+wIWuTSEdmazRyoC1a0SRwe3d+/ovdKUYx06m8mO?=
 =?us-ascii?Q?FjLfv1YlCDSZMIPf3cTCjdE81wv9YxPNBgZDZ6VxyVroosm6X+p1j1vHcwgw?=
 =?us-ascii?Q?2t7e+5VUTgnIy6EI2AE1MOONnIlDMXpYO8oyJ3b6MnHlKh8cavQlVkeG9aMU?=
 =?us-ascii?Q?JCV0cySHN2YorSvcHaciy4eq/WnSMpcYENmanCaHQtbblj7hPWZQkhB24t9b?=
 =?us-ascii?Q?q80OeMemxoHieazNFWnGcBiyvi3lB4jU2mY5fZrDPr9B1RgEJCD5DePVPGc+?=
 =?us-ascii?Q?cR64I/K/N4LlTGQty0z0dO1mZocpu7cBuoZkhkP6CpjheKoT/TkILXpXS18z?=
 =?us-ascii?Q?TFvGXGWoMNJHUapSA/viAJZ4rOuUMJ0VrLYe5LxxrWbJ1Dpv9s+CAQvlUmLE?=
 =?us-ascii?Q?yfHX7UYmXPYWpSNtEfMoLUNJc/n5/wh6cZ0MCubWdE6K5kEaJfX3K8W//mdk?=
 =?us-ascii?Q?5FTnHAP+ufqLOhAdCdlwrY1Gc8P0sIYBP2mUzEw3AoPlLmjCQpOnfnYRuOn9?=
 =?us-ascii?Q?YvkFRibjhknMahyIGF6ftEWr3U8+6al347n8gNPxUj9cIQ7r3Nr6pat7uWED?=
 =?us-ascii?Q?h8WhdWsR9WDAsL7nM91SvQxwC9IPW7qUEQ9AefFFb4F3RKPBYcNyvxh2kYk3?=
 =?us-ascii?Q?Ty15atWbE9mS7csOl12t/ZtgoUwe+iW18xtM7mCyr4sP0MWWkRhwcePLY3o6?=
 =?us-ascii?Q?EInedAZUcK/T68enCVg89Djf/Tr5bZyS/DdUrXSH7LOPApuM6jmekCzkf4fj?=
 =?us-ascii?Q?XVt9467wb/6z4a9z8ZlNjt3ckQAJBovWu7XA3aoVbMS3qGAnqtrYyPYDFLRz?=
 =?us-ascii?Q?KI/x2/JVZrkJ+MNhjrLtdqnpES3Z87Zyhx8Q7Gzxmfl5VSjGrK6DX0iVtDDB?=
 =?us-ascii?Q?0OxKWgKHMEupQO0DX1JpE1JKasxGxpaIOoG0Lm9qv3RiRm5ukADQNCHEFBxU?=
 =?us-ascii?Q?ok21ZvX4Uty7aOW83Snzx2hQVZtdhUUQX3SfbdrC3B5MANyhf+szy+t609y1?=
 =?us-ascii?Q?9EKyxEUA/FS9P71ZvsXqmSzPxGrFE5yOBIRX2BCH+KhFGeOGvEE+frmxTH21?=
 =?us-ascii?Q?SUi/wdXFKvJYO5E/UWRUT9iXtHr9NSOGs0JgcAY1eI2yz+DwsYqhhm1ex8Ex?=
 =?us-ascii?Q?PmWBKE7cevDoSH8ebTxG2cNERynPV88nibgA7YHatzb28WCXgkutecpwldPW?=
 =?us-ascii?Q?jQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cb0dbedd-6b92-43c0-1fb9-08db71b35498
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6139.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2023 17:25:23.7020
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Vbv+ceeZZczK9WLPiGezcX1tYriqP3V65FPBUh8UhmlPleOvwkcUQrBz8lk+M4h6pKhNbd4gCDoGpc/12sk86/H/JPvWutEuHZtjOWzB+t8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6229
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 20, 2023 at 05:55:19PM +0300, Andy Shevchenko wrote:
>On Tue, Jun 20, 2023 at 05:47:34PM +0300, Jani Nikula wrote:
>> On Thu, 15 Jun 2023, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>> > On Fri, May 12, 2023 at 02:45:19PM +0300, Jani Nikula wrote:
>> >> On Fri, 12 May 2023, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>> >> > On Fri, May 12, 2023 at 02:25:18PM +0300, Jani Nikula wrote:
>> >> >> On Fri, 12 May 2023, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>> >> >> > On Mon, May 08, 2023 at 10:14:02PM -0700, Lucas De Marchi wrote:
>> >> >> >> Add GENMASK_U32(), GENMASK_U16() and GENMASK_U8()  macros to create
>> >> >> >> masks for fixed-width types and also the corresponding BIT_U32(),
>> >> >> >> BIT_U16() and BIT_U8().
>> >> >> >
>> >> >> > Why?
>> >> >>
>> >> >> The main reason is that GENMASK() and BIT() size varies for 32/64 bit
>> >> >> builds.
>> >> >
>> >> > When needed GENMASK_ULL() can be used (with respective castings perhaps)
>> >> > and BIT_ULL(), no?
>> >>
>> >> How does that help with making them the same 32-bit size on both 32 and
>> >> 64 bit builds?
>> >
>> > 	u32 x = GENMASK();
>> > 	u64 y = GENMASK_ULL();
>> >
>> > No? Then use in your code either x or y. Note that I assume that the parameters
>> > to GENMASK*() are built-time constants. Is it the case for you?
>>
>> What's wrong with wanting to define macros with specific size, depending
>> on e.g. hardware registers instead of build size?
>
>Nothing, but I think the problem is smaller than it's presented.

not sure about big/small problem you are talking about. It's a problem
for when the *device* register is a 32b fixed width, which is
independent from the CPU you are running on. We also have registers that
are u16 and u64. Having fixed-width GENMASK and BIT helps avoiding
mistakes like below. Just to use one example, the diff below builds
fine on my 64b machine, yet it's obviously wrong:

	$ git diff 
	diff --git a/drivers/gpu/drm/i915/gt/intel_gt_mcr.c b/drivers/gpu/drm/i915/gt/intel_gt_mcr.c
	index 0b414eae1683..692a0ad9a768 100644
	--- a/drivers/gpu/drm/i915/gt/intel_gt_mcr.c
	+++ b/drivers/gpu/drm/i915/gt/intel_gt_mcr.c
	@@ -261,8 +261,8 @@ static u32 rw_with_mcr_steering_fw(struct intel_gt *gt,
			 * No need to save old steering reg value.
			 */
			intel_uncore_write_fw(uncore, MTL_MCR_SELECTOR,
	-                                     REG_FIELD_PREP(MTL_MCR_GROUPID, group) |
	-                                     REG_FIELD_PREP(MTL_MCR_INSTANCEID, instance) |
	+                                     FIELD_PREP(MTL_MCR_GROUPID, group) |
	+                                     FIELD_PREP(MTL_MCR_INSTANCEID, instance) |
					      (rw_flag == FW_REG_READ ? GEN11_MCR_MULTICAST : 0));
		} else if (GRAPHICS_VER(uncore->i915) >= 11) {
			mcr_mask = GEN11_MCR_SLICE_MASK | GEN11_MCR_SUBSLICE_MASK;
	diff --git a/drivers/gpu/drm/i915/gt/intel_gt_regs.h b/drivers/gpu/drm/i915/gt/intel_gt_regs.h
	index 718cb2c80f79..c42bc2900c6a 100644
	--- a/drivers/gpu/drm/i915/gt/intel_gt_regs.h
	+++ b/drivers/gpu/drm/i915/gt/intel_gt_regs.h
	@@ -80,8 +80,8 @@
	 #define   GEN11_MCR_SLICE_MASK                 GEN11_MCR_SLICE(0xf)
	 #define   GEN11_MCR_SUBSLICE(subslice)         (((subslice) & 0x7) << 24)
	 #define   GEN11_MCR_SUBSLICE_MASK              GEN11_MCR_SUBSLICE(0x7)
	-#define   MTL_MCR_GROUPID                      REG_GENMASK(11, 8)
	-#define   MTL_MCR_INSTANCEID                   REG_GENMASK(3, 0)
	+#define   MTL_MCR_GROUPID                      GENMASK(32, 8)
	+#define   MTL_MCR_INSTANCEID                   GENMASK(3, 0)
	 
	 #define IPEIR_I965                             _MMIO(0x2064)
	 #define IPEHR_I965                             _MMIO(0x2068)

If the driver didn't support 32b CPUs, this would even go unnoticed.

Lucas De Marchi

>And there are already header for bitfields with a lot of helpers
>for (similar) cases if not yours.
>
>> What would you use for printk format if you wanted to to print
>> GENMASK()?
>
>%lu, no?
>
>-- 
>With Best Regards,
>Andy Shevchenko
>
>