Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <dd8edd9405049b09cd30ea13e5ae5562a437a2d3.camel@redhat.com>
Subject: Re: [PATCH v2] drm: use mgr->dev in drm_dbg_kms in
 drm_dp_add_payload_part2
From:   Lyude Paul <lyude@redhat.com>
To:     Jeff Layton <jlayton@kernel.org>, David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>
Cc:     Wayne.Lin@amd.com, alexdeucher@gmail.com,
        Jani Nikula <jani.nikula@linux.intel.com>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Date:   Tue, 20 Jun 2023 15:50:24 -0400
In-Reply-To: <4400e47d6555ed773d1e9cab5566c03429d43ae9.camel@kernel.org>
References: <20230419112447.18471-1-jlayton@kernel.org>
         <d0b9654c756069a6f0edcca6f4d410f7af592784.camel@redhat.com>
         <4400e47d6555ed773d1e9cab5566c03429d43ae9.camel@kernel.org>
Organization: Red Hat Inc.
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.3 (3.48.3-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

Eek - this might have been a situation where everyone involved assumed some=
one
else would push it, whoops. I'll make sure this is pushed upstream :).

FWIW: You could definitely send an MR to the fedora kernel's gitlab to get
this included earlier. If you don't get to it before me I'll try to do that
today

On Tue, 2023-06-20 at 07:18 -0400, Jeff Layton wrote:
> I've noticed that this patch is not included in linux-next currently.
>=20
> Can I get some confirmation that this is going to be included in v6.5?
> Currently, I've been having to rebuild Fedora kernels to avoid this
> panic, and I'd like to know there is a light at the end of that tunnel.
>=20
> Thanks,
> Jeff
>=20
> On Wed, 2023-04-19 at 16:54 -0400, Lyude Paul wrote:
> > Reviewed-by: Lyude Paul <lyude@redhat.com>
> >=20
> > Thanks!
> >=20
> > On Wed, 2023-04-19 at 07:24 -0400, Jeff Layton wrote:
> > > I've been experiencing some intermittent crashes down in the display
> > > driver code. The symptoms are ususally a line like this in dmesg:
> > >=20
> > >     amdgpu 0000:30:00.0: [drm] Failed to create MST payload for port =
000000006d3a3885: -5
> > >=20
> > > ...followed by an Oops due to a NULL pointer dereference.
> > >=20
> > > Switch to using mgr->dev instead of state->dev since "state" can be
> > > NULL in some cases.
> > >=20
> > > Link: https://bugzilla.redhat.com/show_bug.cgi?id=3D2184855
> > > Suggested-by: Jani Nikula <jani.nikula@linux.intel.com>
> > > Signed-off-by: Jeff Layton <jlayton@kernel.org>
> > > ---
> > >  drivers/gpu/drm/display/drm_dp_mst_topology.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >=20
> > > I've been running this patch for a couple of days, but the problem
> > > hasn't occurred again as of yet. It seems sane though as long as we c=
an
> > > assume that mgr->dev will be valid even when "state" is a NULL pointe=
r.
> > >=20
> > > diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c b/drivers/=
gpu/drm/display/drm_dp_mst_topology.c
> > > index 38dab76ae69e..e2e21ce79510 100644
> > > --- a/drivers/gpu/drm/display/drm_dp_mst_topology.c
> > > +++ b/drivers/gpu/drm/display/drm_dp_mst_topology.c
> > > @@ -3404,7 +3404,7 @@ int drm_dp_add_payload_part2(struct drm_dp_mst_=
topology_mgr *mgr,
> > > =20
> > >  	/* Skip failed payloads */
> > >  	if (payload->vc_start_slot =3D=3D -1) {
> > > -		drm_dbg_kms(state->dev, "Part 1 of payload creation for %s failed,=
 skipping part 2\n",
> > > +		drm_dbg_kms(mgr->dev, "Part 1 of payload creation for %s failed, s=
kipping part 2\n",
> > >  			    payload->port->connector->name);
> > >  		return -EIO;
> > >  	}
> >=20
>=20

--=20
Cheers,
 Lyude Paul (she/her)
 Software Engineer at Red Hat