Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <41affdf0-edba-6202-4e76-fd969da6497b@ni.com>
Date:   Tue, 20 Jun 2023 15:42:07 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [RFC PATCH] pps: Increase PPS_MAX_SOURCES value.
To:     Rodolfo Giometti <giometti@enneenne.com>
Cc:     linux-kernel@vger.kernel.org, brenda.streiff@ni.com
References: <20230605203147.694716-1-charlie.johnston@ni.com>
 <fe435e68-8e05-9078-0fe6-63ef7cce2fc9@enneenne.com>
 <b794bccc-0233-4d78-df6f-bf7c688a7d7d@ni.com>
 <70ce864c-ca13-4fc4-fcb5-9b7f91579a90@enneenne.com>
 <38f38f66-0fd5-4e6c-4839-8272cef77046@ni.com>
 <5aff32cf-74ea-b632-9d4d-a01ca0d31821@enneenne.com>
Content-Language: en-US
From:   Charlie Johnston <charlie.johnston@ni.com>
In-Reply-To: <5aff32cf-74ea-b632-9d4d-a01ca0d31821@enneenne.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TVZxRnE0M2l5NkhlY0F4MlVXR2ZZSW9paXBydGsrNzdtdElCYXorMFBCQTlZ?=
 =?utf-8?B?TThKNVZCcVd6RTBEQytkNUNXeEdTeVFzRVVzTkdVcHJ4ZG1wZ1UvZmFtaDcw?=
 =?utf-8?B?U3NTVXJPcU80THYwbWJ4MmdmTHY5Ukk4WG1DS2ttSkVpUFo4MjZUMlh6aXFh?=
 =?utf-8?B?YzVVZE1oSVFmZU4vakxST2RpKy84TlM0SmtHWDFxeUFrb3h5akZGbSsxRit4?=
 =?utf-8?B?ZWUycmdISlpaby9BQWZ5VllEOUJOYnJ2OENGR0tMelRSWnVrWE5OdEgwa1pq?=
 =?utf-8?B?RVBsdTVnUU44aEk5aUh1K2NucFdScm5oeXV3YW92NjJpbEVHSjVtcVRyeGtv?=
 =?utf-8?B?QVE4UVR6ak9QWkJDUXdHcllYbjVxTGgrM1lzbXNvY1Jxd0ZOZUx5WU1UZmZl?=
 =?utf-8?B?R0FBa2dPaEpaYUdwZDVEM3RKMVhjblNhMFBTMnI4UEVvSjBicmxuWjJpNFdw?=
 =?utf-8?B?bkJJNFNsdndtYktwNHpUdU9sNFlTZnZsUlhYZ1NlVHB1YVBKZEw4bURuNis3?=
 =?utf-8?B?OWYzWWpwZUVsWkZxM3AxZ2V0YUcyQmNHb3hRV0k4anVmankzb0hGSU1aZ1hL?=
 =?utf-8?B?cGZVbDRQa0lyeGpKQXMwbUl6VlMyclpWVjFnSzVlY1crMjF0dkNTR0pvcUs1?=
 =?utf-8?B?NlJmUHY0UUE2bE5zVGtWc2U2WDFjbFZRRW5GR2ZVUExreE9PckwzZGhCdEpU?=
 =?utf-8?B?WENORCtHVDVSSEVOQ3dTb3JLdWpkekRhcmJ2U3gzMlQyT3c3czFzcXREbTE1?=
 =?utf-8?B?MW4wT3l2UERpOEhmZWxDUFZoNUZYTGh0RHpCUTk2a3BaZE1yYjlneFhPamYw?=
 =?utf-8?B?Z0xMQ25td0VGek1vWDdKcEhBeGo2K3Via3JXVG9oZjBIR2Z1QmZrZTFXeUs1?=
 =?utf-8?B?aDh3Q0xGZ3lrMXFwZGhMdHl0R1pySnBzYStzc012NVVITVdXNjdtbkt6V0Ev?=
 =?utf-8?B?NkRTZy9WSGd3YjJZc285VE1Rck0yNFlXR1lkNElRT2lvRjh1cjZ4ek5pMW0z?=
 =?utf-8?B?MGx5YjhHRnhyNXRRbEFDM2ZBMFBtdysyZVBZQmlGRzVSbVdvdGd1dGV2TDZ5?=
 =?utf-8?B?Rk53US9od3EvQUtNZ3dtZ3E3KzBoenVSeDMvd0lraDRZNWFlOGZzY3JOeG9x?=
 =?utf-8?B?QkhPMDJlR1kxb3JNZjNxaE5HWVUzZTJVTWwwbWlFa2lWMEw4MUIzNlNoQXNR?=
 =?utf-8?B?bzFrMkhjUStMUWJhU2FjUHhRcDU3ZzZMZHhlejBVT2NrQVVrY2lRMkNKejZy?=
 =?utf-8?B?OW4zaFFSbGZiVUJSZTlONDhVakNBSjV1Y1pmVWdLSVk0WXVtL21mWk5qQkM1?=
 =?utf-8?B?dU5ycm5YeEhNZTdTcTRiTmhIbDFhcEM0OG5DQitSYm1POEFHSHVVTzUwTll3?=
 =?utf-8?B?S2FMQlk3aGlPMFoyTWNWZ0JJd1lYNjVlL29HL1Z0L3dXYy9JT0lJb3BhM0o2?=
 =?utf-8?B?Y1hBdDk1OXpzcWJTWXorS1AwdXJKc1g2dmprV2EyaWV0RWFVTmVjcFdYSUtl?=
 =?utf-8?B?QUhWZG1iVUdzR0ozUTdNbGFqbTlsbHB3RWU4SDN3dThrenVKS2gwdExqTW5W?=
 =?utf-8?B?dmdlOVZiaFhMakZCR1VEeG1YMkVhT0I4SWI4enl4U3VremlJem55MU15WEVX?=
 =?utf-8?B?dnp5eUZmcUdYb1NXbnFwOFViNGI3ZnhLYkNiQlZjcjY1ektIOGtCQWVUcFlt?=
 =?utf-8?B?NjJxbmpkSE9nbEs2SnZEdmY0MFJOeDY4WFNqNUR1ZjJuSmpCN0FodHB2R1NF?=
 =?utf-8?B?TGZIVWlZcUkxbVFnbEFOM1VOL2FNbTZFTUZwZTJUR3RVbkxOaUpDMUZ4OThh?=
 =?utf-8?B?MFFEQytYREtWdEhIM3pDQUI2WmJrMXVFSDNhRnVmS0krS25NOWVTVDUrZXVr?=
 =?utf-8?B?d3J5cmpGZXV3NjRCUHdRb0hCOUNXbHAwanczTHFGN05sQmpyazVyNjNrYXVn?=
 =?utf-8?B?ZlVJWTdHN2poQksyeWgyc1RLZzBLdkMxTEd0R2FaTzR6ZEtRNDdJcGxaU0Jq?=
 =?utf-8?B?S0MrZm5iNkM1MStsYXI2ckUrbTlhZXFMVkE5OFdHeHNnOFdCZ1dBS0xvZVB2?=
 =?utf-8?B?a1RGblh0dGxoYmtjcm9zUExnU2FxT2ZBcCttdHR1NW4wQ09DM2dnYVRCa2ZI?=
 =?utf-8?B?QnYvYnBkblZNSzFjSGIxRGpGQndKREZHc2IrSG1uY0dYeFgxQjFtRDBZWkd1?=
 =?utf-8?B?TVE9PQ==?=
X-OriginatorOrg: ni.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7a0736e6-6541-4e80-2369-08db71ced17a
X-MS-Exchange-CrossTenant-AuthSource: SN6PR04MB4879.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2023 20:42:09.6362
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 87ba1f9a-44cd-43a6-b008-6fdb45a5204e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vMgbXyoiuPyF8dXzF9Bk9Udltbes8bF/ghmrEXqjs9e8u55aUIz3On7lSYUP+Dxr+Gey5EwpWobvaVhzF09LlA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR04MB6437
X-Proofpoint-ORIG-GUID: o2x_lICf6E3VfaHxvBvwUXzYNx4aqfxv
X-Proofpoint-GUID: o2x_lICf6E3VfaHxvBvwUXzYNx4aqfxv
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-06-20_15,2023-06-16_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_policy_notspam policy=outbound_policy score=30 clxscore=1015
 impostorscore=0 mlxlogscore=891 bulkscore=0 phishscore=0
 priorityscore=1501 suspectscore=0 lowpriorityscore=0 mlxscore=0
 spamscore=0 malwarescore=0 adultscore=0 classifier=spam adjust=30
 reason=mlx scancount=1 engine=8.12.0-2305260000
 definitions=main-2306200187
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 6/12/23 11:07, Rodolfo Giometti wrote:
> On 09/06/23 23:00, Charlie Johnston wrote:
>> On 6/9/23 02:30, Rodolfo Giometti wrote:
>>> On 08/06/23 00:07, Charlie Johnston wrote:
>>>> On 6/7/23 02:33, Rodolfo Giometti wrote:
>>>>> On 05/06/23 22:31, Charlie Johnston wrote:
>>>>>> For consistency with what ptp uses for minors, this
>>>>>> change sets PPS_MAX_SOURCES to MINORMASK + 1.
>>>>>>
>>>>>> The PPS_MAX_SOURCES value is currently set to 16. In
>>>>>> some cases this was not sufficient for a system. For
>>>>>> example, a system with multiple (4+) PCIe cards each
>>>>>> with 4 PTP-capable ethernet interfaces could run out
>>>>>> of the available PPS major:minors if each interface
>>>>>> registers a PPS source.
>>>>>>
>>>>>> Signed-off-by: Charlie Johnston <charlie.johnston@ni.com>
>>>>>> ---
>>>>>>     include/uapi/linux/pps.h | 2 +-
>>>>>>     1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>>
>>>>>> diff --git a/include/uapi/linux/pps.h b/include/uapi/linux/pps.h
>>>>>> index 009ebcd8ced5..85f472330da8 100644
>>>>>> --- a/include/uapi/linux/pps.h
>>>>>> +++ b/include/uapi/linux/pps.h
>>>>>> @@ -26,7 +26,7 @@
>>>>>>     #include <linux/types.h>
>>>>>>       #define PPS_VERSION        "5.3.6"
>>>>>> -#define PPS_MAX_SOURCES        16        /* should be enough... */
>>>>>> +#define PPS_MAX_SOURCES        (MINORMASK + 1)
>>>>>>       /* Implementation note: the logical states ``assert'' and ``clear''
>>>>>>      * are implemented in terms of the chip register, i.e. ``assert''
>>>>>
>>>>> I have just one question: are you sure that it's safe to call idr_alloc(..., 0, (MINORMASK + 1), ...)?
>>>>>
>>>>> Ciao,
>>>>>
>>>>> Rodolfo
>>>>>
>>>>
>>>> Thanks for taking a look!
>>>>
>>>> My understanding is that idr_alloc(..., start, end, ...) can take any end value up to INT_MAX. It also handles any values <= 0 by treating them as equal to INT_MAX + 1 since the end value is non-inclusive. I can't think of any reason using MINORMASK + 1 here would be an issue since it's much less than the maximum value idr_alloc() allows.
>>>>
>>>> A number of drivers (e.g. ptp) just explicitly use a start and end value of 0, but I don't think that change would fit here.
>>>
>>> I see and maybe I should replace the usage of idr_*() with ida_*() as PTP does...
>>>
>>> However the right-thing(TM) to do here should be dropping PPS_MAX_SOURCES at all!
>>>
>>> Let me go deeper in this issue. I'm going to produce a patch set in next days. Have you any chances to test it?
>>>
>>> Ciao,
>>>
>>> Rodolfo
>>>
>> MINORMASK
>> I'll have to check when the system we used for testing is available again (not easy to find a system with 20+ Ethernet ports) but I'd be happy to test a patch!
> 
> Great! Please, let me know.
> 
>> I know an increase to PPS_MAX_SOURCES was tested on that system.
> 
> I see and it seems that it's safer to set PPS_MAX_SOURCES to MINORMASK... so please reproduce your patch with this simple modification, then I'm going to produce a patch to drop the PPS_MAX_SOURCES define since it's not needed anymore.
> 
> After that you should test all these modifications in order to safely add them to Linux.
> 
> Ciao,
> 
> Rodolfo
> 

I've resubmitted the patch with just PPS_MAX_SOURCES = MINORMASK. The system which hits the limit and causes the problem is currently available for testing. 

Is there anything you'd like me to try running? Or just confirm the limit change works?

Thanks,
Charlie