Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230613033946.103515-1-yangjihong1@huawei.com> <20230613033946.103515-2-yangjihong1@huawei.com>
In-Reply-To: <20230613033946.103515-2-yangjihong1@huawei.com>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Tue, 20 Jun 2023 15:35:25 -0700
Message-ID: <CAM9d7cjyVgJiVT4Lf+qGd+d2es6NcoN3H42onpN_t4Ed0JHgig@mail.gmail.com>
Subject: Re: [PATCH RESEND v4 1/4] perf trace-event-info: Add
 tracepoint_id_to_name() helper
To:     Yang Jihong <yangjihong1@huawei.com>
Cc:     peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
        mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
        jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com,
        anshuman.khandual@arm.com, jesussanp@google.com,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

Hello,

On Mon, Jun 12, 2023 at 8:41 PM Yang Jihong <yangjihong1@huawei.com> wrote:
>
> Add tracepoint_id_to_name() helper to search for the trace events directory
> by given event id and return the corresponding tracepoint.
>
> Signed-off-by: Yang Jihong <yangjihong1@huawei.com>
> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
>  tools/perf/util/trace-event-info.c | 11 +++++++++++
>  tools/perf/util/trace-event.h      |  6 ++++++
>  2 files changed, 17 insertions(+)
>
> diff --git a/tools/perf/util/trace-event-info.c b/tools/perf/util/trace-event-info.c
> index c24b3a15e319..a7901f4a6654 100644
> --- a/tools/perf/util/trace-event-info.c
> +++ b/tools/perf/util/trace-event-info.c
> @@ -466,6 +466,17 @@ static struct tracepoint_path *tracepoint_id_to_path(u64 config)
>         return NULL;
>  }
>
> +char *tracepoint_id_to_name(u64 config)
> +{
> +       struct tracepoint_path *path = tracepoint_id_to_path(config);
> +       char *buf = NULL;
> +
> +       if (path && asprintf(&buf, "%s:%s", path->system, path->name) > 0)
> +               return buf;

I think we need to call put_tracepoints_path() before return.

Thanks,
Namhyung


> +
> +       return NULL;
> +}
> +
>  static struct tracepoint_path *tracepoint_name_to_path(const char *name)
>  {
>         struct tracepoint_path *path = zalloc(sizeof(*path));
> diff --git a/tools/perf/util/trace-event.h b/tools/perf/util/trace-event.h
> index a0cff184b1cd..a69ee29419f3 100644
> --- a/tools/perf/util/trace-event.h
> +++ b/tools/perf/util/trace-event.h
> @@ -62,6 +62,12 @@ unsigned long long eval_flag(const char *flag);
>
>  int read_tracing_data(int fd, struct list_head *pattrs);
>
> +/*
> + * Return the tracepoint name in the format "subsystem:event_name",
> + * callers should free the returned string.
> + */
> +char *tracepoint_id_to_name(u64 config);
> +
>  struct tracing_data {
>         /* size is only valid if temp is 'true' */
>         ssize_t size;
> --
> 2.30.GIT
>