Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp8467270rwd; Tue, 20 Jun 2023 15:55:19 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6bIotBc5mShU8OOX31MCaita+JYN8ahWBfGQogcr3rQPNsOkW3WV1z/7zmXbu+b6oGNmi7 X-Received: by 2002:a05:6a20:72a7:b0:10c:3557:399a with SMTP id o39-20020a056a2072a700b0010c3557399amr11435263pzk.49.1687301718928; Tue, 20 Jun 2023 15:55:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687301718; cv=none; d=google.com; s=arc-20160816; b=GjwUf8XrFtIVNK2UVEoWwkD4V6ol2w1gdJi2CXvqpXKgC3YvcCmeaNfm/o+qEGkN2f /Qd4OiA9OU2CRGuMLHA3T2hrNL299JB6Z8GYDJKUSuBkipq/FAFCOy4opbCe4TiBpCjv Sky7SbktbthFi5dVIRpMX2Txwi+lntiWzegwZrhVVZv4R2zd1S5Gnd2Nfv2hHX7sMfhs 1ekGb95oZzdtt8KYZLqKoN+vI8z+GP65oVZoy7RNepnTdPu9zlnRYAptusWVgn7y+ZzU EnVZzqWHIUox14GglVztxwJIUif3sG3KINM0guYDkQz1recN8flAlu6ikNMLCK6MccB4 ix9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version; bh=fInHKTb5XqjKzJU51F/p38J5A9NhNWvsnwN6JUnNaIw=; b=uTvlVuRFa2hmfNjTZ+KERxzumOpZ7WBPWHV3LJUDN2qrbVL/qUuPNdIGorCP0oNxJl 7as4+xWYfbyq+HpEGZ9J2nliQXWCavSp2bphGaf5VfyS1yESHM88C0hcppafpNme01BK e3aj/2H/IjXMAS/mLc0LyKFDgWGWtIzIUemg4AZmU7gUKa7bL1qsvbT+DptyN/hxJZM/ /HdiwNkLb1gg7I13H4zk56/+aLMaJYPRum8dyS03gEhjjlTLN+j08Ne9A6krauzUdOxF aK16aHulPYbrqJvscbBHsc6boccSTtPSoXw+sfEkWUKazYVYHsy9HQ1XueLys+9TRWX/ vVXQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 195-20020a6219cc000000b00666747b3ad4si153877pfz.355.2023.06.20.15.55.07; Tue, 20 Jun 2023 15:55:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229908AbjFTWml convert rfc822-to-8bit (ORCPT + 99 others); Tue, 20 Jun 2023 18:42:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229796AbjFTWmj (ORCPT ); Tue, 20 Jun 2023 18:42:39 -0400 Received: from mail-io1-f51.google.com (mail-io1-f51.google.com [209.85.166.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C918E10F1; Tue, 20 Jun 2023 15:42:38 -0700 (PDT) Received: by mail-io1-f51.google.com with SMTP id ca18e2360f4ac-77e2f2ad553so186846539f.2; Tue, 20 Jun 2023 15:42:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687300958; x=1689892958; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4H5CggCHHSoUjV0wAgcwF61+kh3EMGwOfr9WqhDgAN8=; b=jXJB3fMXET2zf6FgYvvZXi8Fa3/AHMg1TY17V3PFihX3EkuwSiLnnzl8ZW2uSVDCc9 4wmpitQs9jFBP3bAfGIzDshWLl4CX1rMFTdlzXuwO6CG6/XsdCU2DVPjdmCq0gcszg7r 3QYY01IRfz/3Bf+CKoDBFb38DWWfZTK2aLYKXaGN8Q6QmnOZhLimUdEV2VB9EyXfJr81 YI4yqaljMpUUv6pyybGdkd9NmwzO83mjV30XJTjnW3SF3Nk116s0/7Rh8WfBul7L0RKL 3sWAcmXB6Cd3JE3Wjk666IVPEDkEPo0QDlBquYimh1c09y3C7VsQKkvLmNxmejscB7Of 5jSQ== X-Gm-Message-State: AC+VfDwf+qO+L1jKwJG8U6EhjiU6wZ3eNEG84kW9uXUKozvJMUyPqQsB kmsVOneLGGBacrqOx+JAlNZya4jQf5cEXxTaRjE= X-Received: by 2002:a5e:c012:0:b0:77a:c741:b73d with SMTP id u18-20020a5ec012000000b0077ac741b73dmr14703953iol.3.1687300958019; Tue, 20 Jun 2023 15:42:38 -0700 (PDT) MIME-Version: 1.0 References: <20230619082036.410-1-lidong@vivo.com> In-Reply-To: From: Namhyung Kim Date: Tue, 20 Jun 2023 15:42:26 -0700 Message-ID: Subject: Re: [PATCH] tools: Fix incorrect calculation of object size by sizeof To: Arnaldo Carvalho de Melo Cc: Li Dong , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Sean Christopherson , "open list:PERFORMANCE EVENTS SUBSYSTEM" , "open list:PERFORMANCE EVENTS SUBSYSTEM" , opensource.kernel@vivo.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnaldo, On Tue, Jun 20, 2023 at 3:06 PM Arnaldo Carvalho de Melo wrote: > > > > On Tue, Jun 20, 2023, 3:19 PM Namhyung Kim wrote: >> >> Hello, >> >> On Mon, Jun 19, 2023 at 1:21 AM Li Dong wrote: >> > >> > What we need to calculate is the size of the object, not the size of the >> > pointer. >> > >> > Signed-off-by: Li Dong >> >> Since this problem was introduced in the current dev cycle and not in the >> mainline yet, I think we can skip the Fixes tag. >> >> Acked-by: Namhyung Kim > > > I think we should have it anyway, if not for the stable guys to pick it up, for documentation sake :-) Ok, I'll add that. Thanks for the reply while on your vacation. :) Thanks, Namhyung