Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp8535600rwd; Tue, 20 Jun 2023 17:07:29 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4NOkBzUq0gUqf2iN/MtU9Hp2OV7iBowh0l3reo5yqxN8d8eigh6O1JnNihJpHBWAURtW0K X-Received: by 2002:a05:6a00:896:b0:664:aff0:240 with SMTP id q22-20020a056a00089600b00664aff00240mr12081644pfj.33.1687306049347; Tue, 20 Jun 2023 17:07:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687306049; cv=none; d=google.com; s=arc-20160816; b=f+9NdV7e51HlLKSSRzSc6sh8W99vNzDS3tBkS2sAPMIbumOHta+UDIvgnvCf5kjCkn MKrS6srwhQr+SjWwM5KKCH6dOJ0CplRo2JDZBOtMzRgyFl8MVahmjnzFZZIP/GrZDuh8 RShchtWGBTWMwrtU1tQH9djCoYkaDcst4YnXDy4TuyXPXhUMh6NJQaaFwzhGB6PTyGrj 7eJxtJEOrBId5CMvvryVSBuSnaebEMrSbowqMOr+8VzaF1oGGKilrC9ZvEvdh/VzW/aG nf3+XU1Ccwh6PjCrHgvXJOGCdfJlEXAlQ1wAnr/uI2nIvs7p7uggk4Xcb7TElSb7k/Cs zneg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=vKs3Nn3T/tb9VC69M13qftg8yAfs62GKs6eI5yArd/g=; b=jDOrd/61UUonWl3uKse/Ejjinp4IUGl59ESjNl0ynuQ9XMpDXyTOlambYtZ8okJODR KKrcfKLEoDGWExaOXrneAAp1JWSbCDjdFuHgi4YPlN+u73QzdEBljcnpkff0wFinFNfT Q9PkxzU7WKxSm7yUwLeu0iIfYaGxyU6bU2onvwe9l4/Pe1Qvwif1OoLKY3PhlVs13Hzl gWuyen4PJftAGqmPDZ1fRYjxjaSGZSAlmSk1kWKGQe9fWxKgEfmQwQBHI/4D32Nuyrx9 B+vVnccSOITgjU+wjliCE+lNvKe3Bf3ebHTOa0fVWGd2gr+yTl5FCnB6hSEAih62/XIf P1yg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=h5gLCg7Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g7-20020a63be47000000b0052c27a0125bsi2742653pgo.738.2023.06.20.17.07.15; Tue, 20 Jun 2023 17:07:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=h5gLCg7Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229912AbjFTXZR (ORCPT + 99 others); Tue, 20 Jun 2023 19:25:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229448AbjFTXZP (ORCPT ); Tue, 20 Jun 2023 19:25:15 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F13CE1703 for ; Tue, 20 Jun 2023 16:25:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8A09361382 for ; Tue, 20 Jun 2023 23:25:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC362C433C9; Tue, 20 Jun 2023 23:25:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687303513; bh=vKs3Nn3T/tb9VC69M13qftg8yAfs62GKs6eI5yArd/g=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=h5gLCg7QDfJ81tP2+/Va4XfHxM18mMN55498n2NiTw+wlLeE47Renbz+YpICVh7Pu 7HwHvpMMzlKqGH5VHfEDJd0TxWWVvLFpD0PxnXkKHHhksurtr4o3tIeC0tN0ctUjd2 TWYf5jgsXMdjMY7mfU8NMcWF1mK6u1UwbUd2DYDe93s5lKkVWG+1+pd21v5wS6hzEd nRek0IVVuGsep5lInTahMLflKtF2nnFulQGIgbsM/tkPYXWNRaSgqsjjrCumRPtxqj mWrHQVsfjs52o4Em9fcr0qV0pyzi3/MGBXmTczaXSotOXXzww7ExGPtt7WYt1TtzWJ 91mikawwFt2VQ== Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-4f86e6e4038so3635579e87.0; Tue, 20 Jun 2023 16:25:13 -0700 (PDT) X-Gm-Message-State: AC+VfDz86lk3HuLQ2UsHx4Wafl5ht1m1hvMMru3+OT54EHu1T5EaLgbw 87C70i1WjDTYDSyo8XdxNc/EMrIej8lw1k5C0h4= X-Received: by 2002:a05:6512:2346:b0:4f6:1307:80b0 with SMTP id p6-20020a056512234600b004f6130780b0mr7329104lfu.12.1687303511923; Tue, 20 Jun 2023 16:25:11 -0700 (PDT) MIME-Version: 1.0 References: <20230619100121.27534-1-puranjay12@gmail.com> <20230619100121.27534-4-puranjay12@gmail.com> In-Reply-To: <20230619100121.27534-4-puranjay12@gmail.com> From: Song Liu Date: Tue, 20 Jun 2023 16:24:59 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH bpf-next v3 3/3] bpf, arm64: use bpf_jit_binary_pack_alloc To: Puranjay Mohan Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, catalin.marinas@arm.com, mark.rutland@arm.com, bpf@vger.kernel.org, kpsingh@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 19, 2023 at 3:01=E2=80=AFAM Puranjay Mohan wrote: > > Use bpf_jit_binary_pack_alloc for memory management of JIT binaries in > ARM64 BPF JIT. The bpf_jit_binary_pack_alloc creates a pair of RW and RX > buffers. The JIT writes the program into the RW buffer. When the JIT is > done, the program is copied to the final RX buffer > with bpf_jit_binary_pack_finalize. > > Implement bpf_arch_text_copy() and bpf_arch_text_invalidate() for ARM64 > JIT as these functions are required by bpf_jit_binary_pack allocator. > > Signed-off-by: Puranjay Mohan LGTM! Thanks! Acked-by: Song Liu