Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Zulkifli, Muhammad Husaini" <muhammad.husaini.zulkifli@intel.com>
To:     Florian Kauer <florian.kauer@linutronix.de>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        "Gomes, Vinicius" <vinicius.gomes@intel.com>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "Tan Tee Min" <tee.min.tan@linux.intel.com>,
        "Gunasekaran, Aravindhan" <aravindhan.gunasekaran@intel.com>,
        "Chilakala, Mallikarjuna" <mallikarjuna.chilakala@intel.com>
CC:     "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kurt@linutronix.de" <kurt@linutronix.de>
Subject: RE: [PATCH net v2 0/6] igc: Fix corner cases for TSN offload
Thread-Topic: [PATCH net v2 0/6] igc: Fix corner cases for TSN offload
Thread-Index: AQHZopYumKxF3D6ER0CT+ezDVm3HE6+UZkjQ
Date:   Wed, 21 Jun 2023 00:17:40 +0000
Message-ID: <SJ1PR11MB6180E6EA9A7A3541F341FA9AB85DA@SJ1PR11MB6180.namprd11.prod.outlook.com>
References: <20230619100858.116286-1-florian.kauer@linutronix.de>
In-Reply-To: <20230619100858.116286-1-florian.kauer@linutronix.de>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?o2kXuOgxhQ+jlecKJE/AfKfN9xNQuC7yujOsocstjMI7htZohVtI+ETUdbAH?=
 =?us-ascii?Q?5wzHap/jE0XYx/2gSBIVTPp+An164wRuDSVWtR7RFw5+Kr1tKwjzoOYCw3uo?=
 =?us-ascii?Q?wjvBAaI5I01t+lm/g/QsmuX5OL1lhrbjArJeZtHXih45Qz1gqk2ONMww84im?=
 =?us-ascii?Q?mYBQQxGsHkrHZmMo53qf4ufuEqLEuJsN2I3T/fPI4b0JiXnDMmAJ/57IXyRJ?=
 =?us-ascii?Q?7eMgF+d/J6UqQF/QK/N87G/Yxjh1MtV33ueBj5fyV2KU5VuNTQY2GFZBEblN?=
 =?us-ascii?Q?CfFSOHQdGKsK9ssG/zbFfdcwYXZE6hp0dAGbhGfEtnMkUVzwAjrmGMsNyC9w?=
 =?us-ascii?Q?yl7hAtTMz7iSuEttgbyMA6RwWF2ncAB02w3k+iR9RhAwJZZpvCGDYpoTPNFS?=
 =?us-ascii?Q?sumhB6cSxA+YUiQf6utC9sn1VVc7C/qtQmYGHphe7SsoiRvXXMtw5fiwvtOz?=
 =?us-ascii?Q?BK2ATfcm2N4fLAZI1IF6YoB8ulXZKbTix3R9eg1Gy9DZ4GlfLJ9ydZK/Ls4u?=
 =?us-ascii?Q?IiV39wH6KaL/KMXbVh+Dyexb4pi7b+0G7+IwgawlW5mRt2Qg6MmG6hg52MLb?=
 =?us-ascii?Q?XYLicuwDmCRvr62oAtJDrNX1H3Wgp14F+1xLpsnmN0i9otfdpUcXor6sOx+4?=
 =?us-ascii?Q?/Qlc8FmKcunhXBCFUsUog3PSvX/pmhvZpCcwUgq0745FK2rzs/UelBIIUlHM?=
 =?us-ascii?Q?JjTU0j4p0enj71JVbWMLe3VBT3SSpR1YucFLTvZSUuOXm505581gXrMRlQZx?=
 =?us-ascii?Q?vII3ZOmB7h7TRJ+Vz1Q/AC/ygBioNSNKAYleb0ipWmTseNqM9+CYLbFXSwTw?=
 =?us-ascii?Q?4oR2NRuF5iOIyrEzvKIFJaQeBPD9uUSwaqn1D9Y29kAybPraLDiAvR/KVs1T?=
 =?us-ascii?Q?5n82kNMM3jlZZs+EQBjbSzT49+WwPK45VUifBpxKQKkMqDoXGR9wqf0f4AN5?=
 =?us-ascii?Q?ZZnlBatGUHU2CTkBgLJIyCHFRse5itt1Smc9mu/aJGKuUwD7+gL6pmfjMcJ/?=
 =?us-ascii?Q?QxSA36ZL8IMwp7+wTAEeKMzR8Z8XwvDAOMbE/TdswozKabMQVVinCu3G8LcZ?=
 =?us-ascii?Q?2W1B+MgNChKFeu2P6bngWb8mcHRNUwB6iFxCWn81FnXDxfV4o8bWrQZmMoKZ?=
 =?us-ascii?Q?zuV2qKyRNWCqXVDggB6c50T1T55TVp6pSElLNbBpc7iZdPJi6yLz/bJp8/pJ?=
 =?us-ascii?Q?xTwqEh47quNWP+alAU8adHjMIg6CFtH47iprkUeVrCBeyYYNZj1bmbQxNHlf?=
 =?us-ascii?Q?x57eXDVLgaTvU/gzeO/kW4seELpZJxlDg168PXGwpRHK+9Xa0FyxbcjcPVI/?=
 =?us-ascii?Q?LlM9OnAZGcKsik8e3OOTHW4ZpXwxTnVG634vQRD2liWuobTp0JKdjJ/xO0nn?=
 =?us-ascii?Q?/7BaG+12WeEIoFhTj++O4qGpc4kdWjfpk6Xqj5z2PStKcGAaUZAjda70vN5T?=
 =?us-ascii?Q?1qeOXUJ8T6m5PdN0Nvzv1gClgEuGRiw5uf6Wb8pUQGUGCvRVDFr/fFXlS/u8?=
 =?us-ascii?Q?T81nHpin3qMylhq4WH0GuHjrmIuRal/iOFeDwf4hgy0axmfU3g2v9LXEYlYL?=
 =?us-ascii?Q?F4bMtg8b9CNgsrA0G6GSrX6Vz7Ho0vI/Dz1s3SiMJXPTMur/UY7oVaOMY+LG?=
 =?us-ascii?Q?ATKyc0rTEPJsE8Pe4ZmXdts=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6180.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8cc58ea1-fd71-4150-494f-08db71ececc1
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jun 2023 00:17:40.0761
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Zw72D/q/0nHbb+jdeO+vvu4WBlNr3E0mAKqTmXtGTb4pGqgRISDXoX7AwGLxiATyEy6vzaBHZMCMqvngeJS83MsCImMoqlchpBpXjFxpyXofebbi5ewYVeiG4SB7nG5b
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4781
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Florian Kauer <florian.kauer@linutronix.de>
> Sent: Monday, 19 June, 2023 6:09 PM
> To: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>; Gomes, Vinicius
> <vinicius.gomes@intel.com>; David S . Miller <davem@davemloft.net>; Eric
> Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>;
> Paolo Abeni <pabeni@redhat.com>; Tan Tee Min
> <tee.min.tan@linux.intel.com>; Zulkifli, Muhammad Husaini
> <muhammad.husaini.zulkifli@intel.com>; Gunasekaran, Aravindhan
> <aravindhan.gunasekaran@intel.com>; Chilakala, Mallikarjuna
> <mallikarjuna.chilakala@intel.com>
> Cc: intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; kurt@linutronix.de; florian.kauer@linutronix.de
> Subject: [PATCH net v2 0/6] igc: Fix corner cases for TSN offload
>=20
> The igc driver supports several different offloading capabilities relevan=
t in the
> TSN context. Recent patches in this area introduced regressions for certa=
in
> corner cases that are fixed in this series.
>=20
> Each of the patches (except the first one) addresses a different regressi=
on
> that can be separately reproduced. Still, they have overlapping code chan=
ges
> so they should not be separately applied.
>=20
> Especially #4 and #6 address the same observation, but both need to be
> applied to avoid TX hang occurrences in the scenario described in the
> patches.
>=20
> Signed-off-by: Florian Kauer <florian.kauer@linutronix.de>
> Reviewed-by: Kurt Kanzenbach <kurt@linutronix.de>
>=20
> ---
>=20
> v2: - Rebased onto net. #1-#2 needed adaptations, others unmodified.
>     - Extend #3 commit message that it only regards i225.
>=20
> ---
>=20
> Florian Kauer (6):
>   igc: Rename qbv_enable to taprio_offload_enable
>   igc: Do not enable taprio offload for invalid arguments
>   igc: Handle already enabled taprio offload for basetime 0
>   igc: No strict mode in pure launchtime/CBS offload
>   igc: Fix launchtime before start of cycle
>   igc: Fix inserting of empty frame for launchtime

Thanks!

Reviewed-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com=
>

>=20
>  drivers/net/ethernet/intel/igc/igc.h      |  2 +-
>  drivers/net/ethernet/intel/igc/igc_main.c | 10 ++++-----
> drivers/net/ethernet/intel/igc/igc_tsn.c  | 26 ++++++++++++++++++++---
>  3 files changed, 29 insertions(+), 9 deletions(-)
>=20
> --
> 2.39.2