Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Shiji Yang <yangshiji66@outlook.com>
To:     sergio.paracuellos@gmail.com
Cc:     angelogioacchino.delregno@collabora.com, john@phrozen.org,
        linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
        linux-mips@vger.kernel.org, matthias.bgg@gmail.com,
        tsbogend@alpha.franken.de
Subject: Re: [PATCH] mips: ralink: introduce commonly used remap node function
Date:   Wed, 21 Jun 2023 09:09:25 +0800
Message-ID: <TYAP286MB031554B338E2379CB87273ADBC5DA@TYAP286MB0315.JPNP286.PROD.OUTLOOK.COM>
In-Reply-To: <CAMhs-H_OtDgJmBrcrN33goXDM19WJr1+Za+G9tibMZrO+9KL1A@mail.gmail.com>
References: <CAMhs-H_OtDgJmBrcrN33goXDM19WJr1+Za+G9tibMZrO+9KL1A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: TYAP286MB0315:EE_|TYCP286MB3852:EE_
X-MS-Office365-Filtering-Correlation-Id: 0aa2c339-8586-4876-f615-08db71f42dde
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: n3HfGXC83I7pQBgvIeLzacxzsFoz2xdhWVwicsTw5T/Wpe8CnyiGm2tuRl4W6WMaJkv3FIgcN09r96Hn/fvEl5Bf1LiDMAjtl+CGPdIfiOU7BIIsDE0Ej5k7hEI+ncpnAsrtexRLX2cB5FNJZPwtdPIHw7ITmt49rJfH2/jARhGSjmMVwluRyJ5kkBDgiAaaYKiCguWUb6oTrawT8hVn545rA9Y47C69TJv8RnZuqDvZoiPCfblnE4sqgmH65H821qywxXooHFplpz9rjC7xvjWKvUT8zhp5uIYAAI5tqjVM2k/fhLXAP3SKTceI5Lc02I4d9WYdMgYvJR43buiw3RV9U3/+wAlbQAe6JFIZM3HEL8ge/72OilKwUgRRVIdPz9Ga4KkDR3EbXVEZcMIdYADaoJYht7CVTFetpdgNnscwfBDPatFxRLiQJGtqe6omzJQf/EeCXQ9DngygWXe42DSYNVMGshy5lF09hv7gyfNprNr85xnvNgDTOzOxhPZ08rVYFzQrhJmiHpuWgngmYpo/WCD+Ra50lhiD4Eaprf2c4y6uGRuwTT0JpL/krFI/4jf/PGlXJ785o0eLL+VTvXo/1hAOF4OW5x4W+a9egfo=
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?elhkTG1RUHBUNEhDK2xSNTFONnpxRzY1TEE0ZE1ZS0EwTUlwOHdlN01SRGxD?=
 =?utf-8?B?dGlhQ2pmQzdyd0dtVHVNR1hIM251UDlWVTdoNm56ZWk0UWk0dWh5b1dXYzQv?=
 =?utf-8?B?amFPb3NpYlBSR0hkZDZJOStENjVURENNQUJaMkZmWGFWK1ZxWWFCVHFYSFBW?=
 =?utf-8?B?OHB1VjczS0VHcEw1RHVOYkR2UDloaGdSUjV1VGd1UTJ0OEk5N0RqTngyaEVZ?=
 =?utf-8?B?SWRPZFVJdDJ0K0Y0dXpNQi9kdTZ6SDdMZkI4R0pLUFlqcEgwT0N4NkF3QWFO?=
 =?utf-8?B?NUVHczRBcHZwdW9nU253a1g3bW4vcEdFZ3FrN2VtTEd2TVF6S0tTVUN6OE1s?=
 =?utf-8?B?bHFxUnMyVk5FTzAwMVVhOGJFdkxtNkc0OWdNZDkzOTJLaENRejMxOHZCbWJq?=
 =?utf-8?B?aHc3Znl4NlNZM1FlMHRHVHFPZW0wL1NJb2pqY1ordTROWjZjZHFYMjBCWFhw?=
 =?utf-8?B?V0ZOc3N2d2x3NTJTNEIvaWFCZS9VbHIwcFFYVzYzZDNiY1BVWTRQNGhrb3RJ?=
 =?utf-8?B?M0VUMDUyTXJoWFdCNTFhZHY1QktyMmZnTDZlWG81dGRLU2JjcG10d20rbEpr?=
 =?utf-8?B?UkxTcXArc2xFb2ZwRHJhQkdHb3ZWUHd2ZjhiYjREMnhEeklxQm40V3dZcTMr?=
 =?utf-8?B?NWlkNW40SzB2T1l5V1ZPbldlaEZuRlVvZjUyRWpqaVRrd1g3by9CS3FtSWc5?=
 =?utf-8?B?TE1mWUY1YkpyMUt0RjUxUGVtR05rSnpJTXVQRHNrZGlYaFFuWC9GLzhkdkZX?=
 =?utf-8?B?b0tFaENvdWlzZ29uaGsydGRuRWFYUDV5bktDVnd5ZXZsM0llaUtPMFBLSGhn?=
 =?utf-8?B?TUtsbHg0d2FTcEhWaldRL2J1YkJ2MkJXblJXeThmNld0Y1gvclhmVmVJK25M?=
 =?utf-8?B?YlZRd054ZjkwZlc1OGxvTXpEdkRqMmY4UFM3bHZnL2F1TzhIbVhLa3RlZ09W?=
 =?utf-8?B?T3R6dHYyVExtYXE0d3hobStLWkE5ODk4Vy92Rjl0TVpKQUV3UVVhWThRVHJM?=
 =?utf-8?B?M3h1QmlEbnIybyszeGg0VDVybnFkV1BMMyt2MlNCQmZ4OHl4aWFOWDM4YktH?=
 =?utf-8?B?UjZKSU5WTXVyMU5saHBJYzR5bzdaZjUwaUNjWUs5ZHNOc21PQjFzSFVZNWR2?=
 =?utf-8?B?T0c5Kzg1UTRMMXVhUklkdUtSS2RIdFhpYkdTNkdmaFBxNGJoMStFTVZyUnJP?=
 =?utf-8?B?UTVIT2xVamxSNjRQcTRsZ3lkWlYvdFU2a2tVcFhFVDJ1aHg2WVdtU1pSQXZT?=
 =?utf-8?B?VGlrV1hka3FNNUgveVJSVW96a2JuR3Jwb1Jza0J0UmlzWVlVTUt6R2RoNGN5?=
 =?utf-8?B?aSs1cThZMjRsbEdBaFhGOGUvSjFDTGJBL09tMlV5OG1aQnVUQlAvaGhNV0dy?=
 =?utf-8?B?RjhJWWFXbzd1bWNIc29mODY3WmVQbWdOaTV5ZTNJSUdaZlRVWWRFc2hXQTJh?=
 =?utf-8?B?ckhuT2xMMktkaFZzazFOa25lR0JnY1NxcmV3UXBxNXZJamFqSnZyck9DWUM5?=
 =?utf-8?B?SFdXRGlGcjJBVEZsV0l2Zm94UnNXOFk5VWtESWN2bGdUUUhqRnRnQ1lWNjNG?=
 =?utf-8?B?MGJjZXdPY041TmxHUTk5UmRGbHdLQlhVVHV0VUxyTXk5a2pzdFNSL1QyS2RS?=
 =?utf-8?Q?wLiCfsSJ5ST/2DUhkFYRF3gyJraWER1xU9BFErm7ZahI=3D?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0aa2c339-8586-4876-f615-08db71f42dde
X-MS-Exchange-CrossTenant-AuthSource: TYAP286MB0315.JPNP286.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2023 01:09:36.1903
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCP286MB3852
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,
        FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>On Tue, Jun 20, 2023 at 1:46 PM Shiji Yang <yangshiji66@outlook.com> wrote:
>>
>> The ralink_of_remap() function is repeated several times on SoC specific
>> source files. They have the same structure, but just differ in compatible
>> strings. In order to make commonly use of these codes, this patch
>> introduces a newly designed mtmips_of_remap_node() function to match and
>> remap all supported system controller and memory controller nodes.
>>
>> Build and run tested on MT7620 and MT7628.
>>
>> Signed-off-by: Shiji Yang <yangshiji66@outlook.com>
>> ---
>>  arch/mips/ralink/common.h |  2 --
>>  arch/mips/ralink/mt7620.c |  9 ---------
>>  arch/mips/ralink/mt7621.c |  9 ---------
>>  arch/mips/ralink/of.c     | 42 ++++++++++++++++++++++++++++++++-------
>>  arch/mips/ralink/rt288x.c |  9 ---------
>>  arch/mips/ralink/rt305x.c |  9 ---------
>>  arch/mips/ralink/rt3883.c |  9 ---------
>>  7 files changed, 35 insertions(+), 54 deletions(-)
>
>Awesome! More deletions than additions in arch folders is always a
>good thing :-).
>
>Changes look good to me. Thanks for doing this!
>
>Reviewed-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
>
>Best regards,
>    Sergio Paracuellos

Thank you for your review. After your new system control driver[1] is
merged, with this patch, we can add more compatible IDs to the list.

[1] https://lore.kernel.org/all/20230619040941.1340372-1-sergio.paracuellos@gmail.com/

Best regards,
    Shiji Yang