Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp8717737rwd; Tue, 20 Jun 2023 20:18:11 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6BWdVe6cRoFpDlK7ZHrYWTY0biFPD0f9hCaw9q34hkkoqEB0L6iA68wZhyC6/vwpX+jbi8 X-Received: by 2002:a05:6214:20c5:b0:623:690c:3ce6 with SMTP id 5-20020a05621420c500b00623690c3ce6mr20398885qve.32.1687317491242; Tue, 20 Jun 2023 20:18:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687317491; cv=none; d=google.com; s=arc-20160816; b=AuxNBFQxOLKEy/s0ky1kjEyzfqjdSHKAztZJb27F1OT/YQlPCje/VrjOiNjkCtIq5O AY138aI1ieotTvP5CAogFQafalAtTN5bOz1HS8wjqkV3m/p8XRw3DbDbvu8/SgjjthVL 5Nh4/PBT9Hn9WBfw3ZZqMi/CTJdvmz3VWLpcKOL2jypTg2bvJHmsCHx1PhaKw5IyXXnz VwJHln+vycw+hT1Uc7l8BrYwZcUBVdrM7gAFsYpKROCyYu1pLRz4XXIOXvsl52tJB6vs shJhioqko1p1fV+PJukvltvS7VCrZ0smUbt5Aa728JJbkuX/+sacJPEZjLtHnh8NAZOo iZog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=OgSsI5+k9or1l2drelkWidOoCSCHzFPrSWQHWzKVW7Y=; b=FrBqGnxqxIHmtuEOHNNdMmyHyJNd6juZ87GAthghOP/X6Pm3gP2+zmGyCZ4/XhHDei OWy3lav58gFusG0n8+68yj+DuVYyp3lb3gzsHYFXgeV55qtpRJqeXtchQM+cgt9/FDAd L3foXM9yirjdXy8IE/beRemqKiC8H5zbBWKjXGxxQPLrhXolDBzTL3bSAcmcU+xdzpn8 8KQ+YJW98tx1+wWadq4r62DIyYdTYkO35atJDPyAQ0e/PJEGOaV3u1Z9iaRr03DQPtdb mV75mwKQBaSX+gWCcfFbOcNBwj+LaHf0UKEK5ocHiA/8tMnv/QfKVarp4487gafqf9Ed ZG+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=vUD90p6h; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bt28-20020a63291c000000b0054ff6d0d183si1721925pgb.178.2023.06.20.20.17.57; Tue, 20 Jun 2023 20:18:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=vUD90p6h; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229854AbjFUCab (ORCPT + 99 others); Tue, 20 Jun 2023 22:30:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229690AbjFUCaa (ORCPT ); Tue, 20 Jun 2023 22:30:30 -0400 Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9DD2B4 for ; Tue, 20 Jun 2023 19:30:28 -0700 (PDT) Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 35L2UM9i071557; Tue, 20 Jun 2023 21:30:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1687314622; bh=OgSsI5+k9or1l2drelkWidOoCSCHzFPrSWQHWzKVW7Y=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=vUD90p6h2yFGYjMNAE/Bf/kYWy94F8FnNMEU0+r6gGsCgKFSAYBzGvsjQ+OfTkwza dekuyMji19HCMtLOSRH9QDb4lra6tZCbAEs7GY30v+evc0Loi14uoGhAlx2+h+X0xq o6wnwvN0inVAu0aGjX2Am/MWEq8SQFPys1RKOPxw= Received: from DLEE104.ent.ti.com (dlee104.ent.ti.com [157.170.170.34]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 35L2UMDR091909 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 20 Jun 2023 21:30:22 -0500 Received: from DLEE100.ent.ti.com (157.170.170.30) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 20 Jun 2023 21:30:21 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 20 Jun 2023 21:30:21 -0500 Received: from localhost (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 35L2ULcV006455; Tue, 20 Jun 2023 21:30:21 -0500 Date: Tue, 20 Jun 2023 21:30:21 -0500 From: Nishanth Menon To: Randy Dunlap CC: Santosh Shilimkar , Tero Kristo , , , , , , Peter Ujfalusi Subject: Re: [PATCH] soc: ti: k3-ringacc: Fixup documentation errors Message-ID: <20230621023021.ubvgok5id5uwydvw@catnap> References: <20230621022407.270842-1-nm@ti.com> <88587e16-8517-bd02-1ce5-7437ce288cb6@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <88587e16-8517-bd02-1ce5-7437ce288cb6@infradead.org> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19:27-20230620, Randy Dunlap wrote: > > > On 6/20/23 19:24, Nishanth Menon wrote: > > Fixup couple of misses in documentation. This squashes the following > > warnings: > > drivers/soc/ti/k3-ringacc.c:135: warning: Function parameter or member 'tdown_complete' not described in 'k3_ring_state' > > drivers/soc/ti/k3-ringacc.c:238: warning: expecting prototype for struct k3_ringacc. Prototype was for struct k3_ringacc_soc_data instead > > > > Cc: Peter Ujfalusi > > Signed-off-by: Nishanth Menon > > Reviewed-by: Randy Dunlap > > (more below) > > > --- > > drivers/soc/ti/k3-ringacc.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/soc/ti/k3-ringacc.c b/drivers/soc/ti/k3-ringacc.c > > index 8f131368a758..548b9f605d86 100644 > > --- a/drivers/soc/ti/k3-ringacc.c > > +++ b/drivers/soc/ti/k3-ringacc.c > > @@ -125,6 +125,7 @@ struct k3_ring_ops { > > * @occ: Occupancy > > * @windex: Write index > > * @rindex: Read index > > + * @tdown_complete: Tear down complete state > > */ > > struct k3_ring_state { > > u32 free; > > @@ -229,7 +230,7 @@ struct k3_ringacc { > > }; > > > > /** > > - * struct k3_ringacc - Rings accelerator SoC data > > + * struct k3_ringacc_soc_data - Rings accelerator SoC data > > * > > * @dma_ring_reset_quirk: DMA reset w/a enable > > What does "w/a" mean? I think it means work around.. (going by the "quirk" terminology).. Let me respin this with w/a replaced with workaround as well. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D