Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp8739950rwd; Tue, 20 Jun 2023 20:45:24 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7IHsKHV4PaBjIwZrX8sVoC4twfvhLNeqzpzvppA/Cick3skYwdT4f4fn89Bd6+v0pd0zEl X-Received: by 2002:a05:620a:22b4:b0:75d:4fb8:e219 with SMTP id p20-20020a05620a22b400b0075d4fb8e219mr12614023qkh.36.1687319124489; Tue, 20 Jun 2023 20:45:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687319124; cv=none; d=google.com; s=arc-20160816; b=Fi4WaMYbMpSQIHJBJ3fkcFVo84CN9rY3AQp7khXxGr1MHNFPZpOdbgMtHTW/yMIRV6 qxvpzS3p9LpIXFnP5CPLxmH00O3XGy/rt12jxPzyd3mXyknuBSRdTe+klOSmVkshd20Q 01Hs/Eh24HvZZWlvzmXBDDnhPWlkXkBJQtJKIIb6VvevIWHgYEdTMQpp66bIRpoxbUiE H6oTxwy3RGkcM2pMU7YBTFyreTTiVyDC1MqStnr1hSrsZTP1FTa5tzgomITJ9Sho9VNe mQtvmOIURwile39gN1lQXelMeiK0M3HN8A3A4pxQDihp8SHCsWqARjbJH9EvXecMP54W fowg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=cJkkiCvZp7b4YReHHufSOZywLFhDSDbqMwRcvIBKOBg=; b=Md0seQihlWsCuX7FL1wtgxrEnodE6UkEMjAkBlOgfXRxb2dsywWbMgfttas5y1Tamb 9jlsA9Z3bwgycbcJ29/FlIJl5CbAJEecz5lsA2pYqQUjrsaOXexgZqGfLat2cqmSeOly itLv4tMvd5XgTAmJWhy8DkjUXbxgNKgI56Qb8+FlisevOEAC1RMLYOZn4cbPlw3HYgrS r71QMcRiwMxMCBDAa6liN9qkqi2v347FofQ+irX56iC2qf+7qeRgBWI9xP4Y8TqQZ6Tx fQIdidZos2D3NsfW8A0e2+kDs96dGxwqt7Mex0c9fxgpun7OZFC+NazP9oLNWqt53uEP rkHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bR88lo4o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h191-20020a6383c8000000b00543c1b205a5si3064502pge.149.2023.06.20.20.45.10; Tue, 20 Jun 2023 20:45:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bR88lo4o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229896AbjFUDbv (ORCPT + 99 others); Tue, 20 Jun 2023 23:31:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229490AbjFUDbu (ORCPT ); Tue, 20 Jun 2023 23:31:50 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF62694; Tue, 20 Jun 2023 20:31:47 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 35FE36145C; Wed, 21 Jun 2023 03:31:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D4C7C433C0; Wed, 21 Jun 2023 03:31:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687318306; bh=w/WJ4ih3bWFbg0Sp+HP6bcoaz3TM0sRb50HscssW6MU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bR88lo4oD30GmFt15WApTVHfKB8r8xfkjaRVADkJ2JAd3VOlMCk29G3bmmZI1xmv2 lPQSSuXGnvOTADDXMuDxnR53GTYL03AK9Qi1IeGUvq6aDe5YsuJi0Gy0c3CzvEVfuf z3RHv6PHWulfVdTu6MMytJbovQ9IEoSZOLckkYLml073/3hpTgLNlLlfxbp6AMR6ET n1bAgai8idE+OCjr+6Vuh6aTiQvxLLSYgYSEyU8SfxQWqQ6GMOVU9Tx1D6LfBbyw2l as7BknO4rpEgboGtdj2wcKG82J2/JTFTRuoL2FiNLZm34m649hgx3ftz/oJMEvcKT9 v9bDUARK4hfCA== Date: Tue, 20 Jun 2023 20:31:45 -0700 From: Jakub Kicinski To: "Radu Pirea (NXP OSS)" Cc: andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, richardcochran@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, sebastian.tobuschat@nxp.com, stable@vger.kernel.org Subject: Re: [PATCH net v3 1/1] net: phy: nxp-c45-tja11xx: fix the PTP interrupt enablig/disabling Message-ID: <20230620203145.2da7c958@kernel.org> In-Reply-To: <20230619132851.233976-1-radu-nicolae.pirea@oss.nxp.com> References: <20230619132851.233976-1-radu-nicolae.pirea@oss.nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 19 Jun 2023 16:28:51 +0300 Radu Pirea (NXP OSS) wrote: > Subject: [PATCH net v3 1/1] net: phy: nxp-c45-tja11xx: fix the PTP interrupt enablig/disabling typo: enablig -> enabling > .config_intr() handles only the link event interrupt and should > disable/enable the PTP interrupt also. I don't understand this sentence, TBH, could you rephrase? > Fixes: 514def5dd339 ("phy: nxp-c45-tja11xx: add timestamping support") For a fix we really need to commit message to say what the problem is, in terms which will be understood by the user. User visible behavior. > CC: stable@vger.kernel.org # 5.15+ > Signed-off-by: Radu Pirea (NXP OSS) > --- > > Where is V1? > https://patchwork.kernel.org/project/netdevbpf/patch/20230410124856.287753-1-radu-nicolae.pirea@oss.nxp.com/ > > Where is V2? > https://patchwork.kernel.org/project/netdevbpf/patch/20230616135323 This link looks cut off. > + /* 0x807A register is not present on SJA1110 PHYs. */ Meaning? It's safe because the operation will be ignored? -- pw-bot: cr