Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Manne, Nava kishore" <nava.kishore.manne@amd.com>
To:     "mdf@kernel.org" <mdf@kernel.org>,
        "hao.wu@intel.com" <hao.wu@intel.com>,
        "yilun.xu@intel.com" <yilun.xu@intel.com>,
        "trix@redhat.com" <trix@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>
Subject: RE: [RFC PATCH] fpga: fpga-bridge: Add manual set option via sysfs
Thread-Topic: [RFC PATCH] fpga: fpga-bridge: Add manual set option via sysfs
Thread-Index: AQHZju7uJlYW+7WqzUmG3ee11N9kt6+Uy55g
Date:   Wed, 21 Jun 2023 04:00:53 +0000
Message-ID: <DM6PR12MB3993C315D875CE44CA1A0B29CD5DA@DM6PR12MB3993.namprd12.prod.outlook.com>
References: <20230525095438.2766625-1-nava.kishore.manne@amd.com>
In-Reply-To: <20230525095438.2766625-1-nava.kishore.manne@amd.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?T2KZxKaldg7Wg1oLEcLLKnr+iwr/stUYxzl4IhKlRkKQjs4vHCcw98K+x82I?=
 =?us-ascii?Q?d8sx61XiB/Rkp12JciGvZW4j0DmdWYs1hizn21sq16WqvFkQ4ThXH1hTurmD?=
 =?us-ascii?Q?MtDaxQyk4txOQpqqdag3+NSPM00XuyYe/hJP3sPYwOwz6EyL7l7HPqtzp72+?=
 =?us-ascii?Q?jdeoorzQ9JuXKRVMwkGU1NlHqYJhWqxJtcjooVVGJbiu2jGdtZH4v+gXKtEW?=
 =?us-ascii?Q?00INW1XN1pnjobDucLsJ3vGtf+E/mKRt31GWT9VGpl9H2b9u9emXBn8bLS3X?=
 =?us-ascii?Q?0/7eDX2hnItNRXyBZlF7I3c42KqIXiCZ+dz2GAifPeQZ7r9mJMEf4r1fqAjk?=
 =?us-ascii?Q?f/55l26maRGtydEPNEMwGHaN6yGwpp/8Mp8gzLeUJldZRsdN0VXmQVNikh+Q?=
 =?us-ascii?Q?W7IaVyTNSkI9Q+K56nThC4qNflYfgNlB5/ztUVmA5YGq3YJQFg9CYVIahefA?=
 =?us-ascii?Q?JqhXRJQvyMlfKL/cn2a/brsb+NqRvKAzm9mQPBRCy7t7xhqhRD6roVGp4V1R?=
 =?us-ascii?Q?rMoJgZSH1w85RGvOQZOMaNFH+xpWUvw/uhodRubpOPeyM5YjEMAycg8Xp7mN?=
 =?us-ascii?Q?1DIhvdnXemd5Rf6gMhGktu4Y8KhYCGSzYD6WsT//1b/EJTExjqjoww+UCQAt?=
 =?us-ascii?Q?vC+dtu6dkPtVsjsDgUQ1xHFMeWrPjNpOuAbmxhnIcO2kjSQUT/mU1LFfdE8B?=
 =?us-ascii?Q?TIyUTw1Fof968tm0fv0XbD2Reu6snFMy7wCf9cfIT3KOM2wD5FhbG28pXZsE?=
 =?us-ascii?Q?lrRD9c/YWSJECSUPHDpxfA8UkTLu85Sqv0yrWmS+7T2GoAfNKf/FCTpjZqjc?=
 =?us-ascii?Q?Ft1PahTC2Nd+rz5OVCmhqQeq070IAlFBw/Cp9qXJP39Ab8uFfWrns7dVo4q2?=
 =?us-ascii?Q?MKGCYcCJT86Ds66LJ2mjYTVOsnFoQiLrODjLc4EPlPBXAWZqCjYY6qPRDz2z?=
 =?us-ascii?Q?n0XVwO3hEg/aXgLoFCkSf99XKJuZ8i18y+4l3/+tlu3OzECWzBqZcSNGkg9U?=
 =?us-ascii?Q?07Vr18pTyTtS+hLFfBp8k8iPYPcFCu6YcecTn3eqMbHkpz1ovMgf5f1SLzbH?=
 =?us-ascii?Q?bEB5UzltaZMrEJGc6Fjd8nNWizva5LK4fARSwx65e19fZk5zOJuuYim1LlvW?=
 =?us-ascii?Q?dIhQxKczkefkq8qKYyPAr3BP0AJILRJpFnr5NekMV0PrHy5DU3sgSYIcoy+a?=
 =?us-ascii?Q?k44IB59kMF1nObu/MQ/G82C/UJwE5N5rzfNonl5AKntL5dp3eMdd9qR5wiMZ?=
 =?us-ascii?Q?JsgCMrd1f/9NOeth442+ZkmbnAE6zLNyN1A54jPZ8Q2JpNRjEUR5ZXsYfyPW?=
 =?us-ascii?Q?5xXpeEZ719uwi74NQO/00FaN+3vEa+BbMa72B3dwzPnFnWTEQ47BrZ8M6kOA?=
 =?us-ascii?Q?LDkxyLlI2BQwSv5sgsSGzoA9yJu784AoPPN5JfVkpAWj9DmEl+6Dujq/Um+l?=
 =?us-ascii?Q?w09KMXLqbc5Ii4FB0UQaKt1HsNCqecZ5tN2vqbF+7zCgyPSNea8XGc7gCdja?=
 =?us-ascii?Q?2T4PL9Xk1oPi2/obUbT9DPBEvzxaqOJb/CWGRT2j2XHcQrdN0XR4vf2dQMNB?=
 =?us-ascii?Q?VQT94m6cf4KcXAFXGOA=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3993.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9fd296eb-71fd-4d4e-24be-08db720c1bf9
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jun 2023 04:00:53.7030
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: iaFTA0xpA3BMSO3oxCX0ao/YwZIuv+o8WmhHeYhJWib3JGnFsr6VstpqVN83sQgw
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB8297
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Ping!

> -----Original Message-----
> From: Manne, Nava kishore <nava.kishore.manne@amd.com>
> Sent: Thursday, May 25, 2023 3:25 PM
> To: mdf@kernel.org; hao.wu@intel.com; yilun.xu@intel.com;
> trix@redhat.com; Manne, Nava kishore <nava.kishore.manne@amd.com>;
> linux-kernel@vger.kernel.org; linux-fpga@vger.kernel.org
> Subject: [RFC PATCH] fpga: fpga-bridge: Add manual set option via sysfs
>=20
> This patch is intended for manual testing only.
> It is provide an option to manually test bridges.
>=20
> Enabling bridge (!0 values are handled)
> br1# echo 1 > /sys/class/fpga_bridge/<bridge>/set
>=20
> Disable bridge
> br1# echo 0 > /sys/class/fpga_bridge/<bridge>/set
>=20
> Signed-off-by: Nava kishore Manne <nava.kishore.manne@amd.com>
> ---
>  .../ABI/testing/sysfs-class-fpga-bridge       |  9 ++++++
>  drivers/fpga/fpga-bridge.c                    | 30 +++++++++++++++++++
>  2 files changed, 39 insertions(+)
>=20
> diff --git a/Documentation/ABI/testing/sysfs-class-fpga-bridge
> b/Documentation/ABI/testing/sysfs-class-fpga-bridge
> index 312ae2c579d8..e157eb737bfb 100644
> --- a/Documentation/ABI/testing/sysfs-class-fpga-bridge
> +++ b/Documentation/ABI/testing/sysfs-class-fpga-bridge
> @@ -9,3 +9,12 @@ Date:		January 2016
>  KernelVersion:	4.5
>  Contact:	Alan Tull <atull@opensource.altera.com>
>  Description:	Show bridge state as "enabled" or "disabled"
> +
> +What:		/sys/class/fpga_bridge/<bridge>/set
> +Date:		May 2023
> +KernelVersion:	6.4
> +Contact:	Nava kishore Manne <nava.kishore.manne@amd.com>
> +Description:	Manual set bridge state (0-disable, !0 enable).
> +		Enabling this option requires that the module is
> +		compiled with #define DEBUG which is enabled by default
> +		when CONFIG_DEBUG_KERNEL is setup.
> diff --git a/drivers/fpga/fpga-bridge.c b/drivers/fpga/fpga-bridge.c inde=
x
> a6c25dee9cc1..54d15b709b10 100644
> --- a/drivers/fpga/fpga-bridge.c
> +++ b/drivers/fpga/fpga-bridge.c
> @@ -13,6 +13,12 @@
>  #include <linux/slab.h>
>  #include <linux/spinlock.h>
>=20
> +/* For enabling manual bridge set(enable/disable) function */ #ifdef
> +CONFIG_DEBUG_KERNEL #undef DEBUG #define DEBUG #endif
> +
>  static DEFINE_IDA(fpga_bridge_ida);
>  static struct class *fpga_bridge_class;
>=20
> @@ -307,9 +313,33 @@ static ssize_t state_show(struct device *dev,  stati=
c
> DEVICE_ATTR_RO(name);  static DEVICE_ATTR_RO(state);
>=20
> +#ifdef DEBUG
> +static ssize_t set_store(struct device *dev,
> +			 struct device_attribute *attr,
> +			 const char *buf, size_t count)
> +{
> +	struct fpga_bridge *bridge =3D to_fpga_bridge(dev);
> +	long enable;
> +	int ret;
> +
> +	ret =3D kstrtol(buf, 16, &enable);
> +	if (ret)
> +		return ret;
> +
> +	if (bridge->br_ops && bridge->br_ops->enable_set)
> +		enable =3D bridge->br_ops->enable_set(bridge, !!enable);
> +
> +	return count;
> +}
> +static DEVICE_ATTR_WO(set);
> +#endif
> +
>  static struct attribute *fpga_bridge_attrs[] =3D {
>  	&dev_attr_name.attr,
>  	&dev_attr_state.attr,
> +#ifdef DEBUG
> +	&dev_attr_set.attr,
> +#endif
>  	NULL,
>  };
>  ATTRIBUTE_GROUPS(fpga_bridge);
> --
> 2.25.1