Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp8939409rwd; Wed, 21 Jun 2023 00:27:24 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5IZF1qX61IPJflUFquZkq1KuYC3vQWZ8IPrwKpD1TC0Hw6QQwJloptzdEKR7Gb6V5BOWz3 X-Received: by 2002:a05:6808:16a7:b0:3a0:4dc3:25ff with SMTP id bb39-20020a05680816a700b003a04dc325ffmr302394oib.7.1687332444144; Wed, 21 Jun 2023 00:27:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687332444; cv=none; d=google.com; s=arc-20160816; b=n3TLalIW6R32jJjd5LUHCxK8PHWUn3uN8TH8//DxKndee3m3kT0iNhLsbJQeRHVaPu pgvrEEgAzIO8W+vZqfxNED54xpkctl9XjAM7gtTbR4Pv0saAXepIDjPHs7qm4JmaoLip NWIl+5RbIs8tN7Ir7Uotk784KWbHOgnMtIEicNHB4H8j2cHV0SpiLmHoh7+IAa2YdVQS G9axVGa1GX1TMi5qucTZzTr6SWng1BiOk2pCLpN/oybY4mo1j6FV8Xs+jsIaK7QjGTXj gzHcD5oIWoGO9sMgVwIwuxtT3TMx68+3zoedH5pYlr12TkLkTxIeT2btVqwLZpnGu0p3 BE0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=bfhyax3dew0LXA32Y8fMdk22KUECvT+h0OWhksWntxA=; b=naZ1UWrwAVt1lDNi2rjce0WOSBgFeyf8RCbVMDDAKvt0rBSKBNEtWmRjPG6P7ay5uK Nku6wryOOLt149hqZ4O/vDWybwAbMDpM3EbeAaqD6BdTLtPkziNtSpbKzw7do8Ppqpot rmHL0ai/kPzhcPOiCW2AWk7itH8i3J7d0GgKOSJnltu30KOxW7hWXJ1DW+LASs9l8uft WsTASL0R7QRvYi/qdSdM3VJFCspfoWyGzsEQYehbc/eUPDDrFQX7Ac7DjcZYtYf4bpXc zqZMcLqVj5ltG+M4EEI6IcXuUinUrdSmP1hHAGfb9eTJg2loIp0BBWZlyBLajaFiBCus HT0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uwpoNgST; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c19-20020a17090abf1300b0025c0a65a763si3504461pjs.121.2023.06.21.00.27.12; Wed, 21 Jun 2023 00:27:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uwpoNgST; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230522AbjFUHED (ORCPT + 99 others); Wed, 21 Jun 2023 03:04:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229618AbjFUHEA (ORCPT ); Wed, 21 Jun 2023 03:04:00 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 068BC10FB; Wed, 21 Jun 2023 00:04:00 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 96F8161484; Wed, 21 Jun 2023 07:03:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 027CCC433C8; Wed, 21 Jun 2023 07:03:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687331039; bh=aCXNvBbGN7pPK5koTOHF3M4Z68BI9UMBxyPP5ZFnl3M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uwpoNgSTATgL3Wvlqmz0vG/f0IeJ4DVM1UJ8iixChI9TCH1k9nThl5efamiClfI7U AOFtILAjo28KIECc+JimCpav+lSEKGDKOkp1Xnu1oXW2bHek/Mqj0F/mT1usP+OUq6 TVUgeV7ug5KB3Mv/swy3CU8BcIxhEqzQqoSdQgZFuIKlJHMQGEbcmoX6zN2RcVd9Gh gfvNnM+ufX3IOqZFs19z+xKZNZL3ZqApp0/boLOzkFfOjsvpy1IH9NAUXW6fpyKd8r 84q7XwFs3Hln/A26YQhR3TVtGf/bFWmdsbdIiPzgVzNB6Omg+qexDoWBU0b/Nnr5U+ FAdxdL+JbnfuQ== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1qBrsn-0005Yz-CX; Wed, 21 Jun 2023 09:04:01 +0200 Date: Wed, 21 Jun 2023 09:04:01 +0200 From: Johan Hovold To: Bjorn Andersson Cc: Bjorn Andersson , Konrad Dybcio , Johan Hovold , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] arm64: dts: qcom: sc8280xp-crd: Correct vreg_misc_3p3 GPIO Message-ID: References: <20230620203915.141337-1-quic_bjorande@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230620203915.141337-1-quic_bjorande@quicinc.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 20, 2023 at 01:39:14PM -0700, Bjorn Andersson wrote: > The vreg_misc_3p3 regulator is controlled by PMC8280_1 GPIO 2, not 1, on > the CRD. > > Fixes: ccd3517faf18 ("arm64: dts: qcom: sc8280xp: Add reference device") > Signed-off-by: Bjorn Andersson The old off-by-one again. Both of these are apparently configured as outputs and driven high by the boot firmware. Reviewed-by: Johan Hovold Tested-by: Johan Hovold Johan