Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 21 Jun 2023 09:23:20 +0200
Message-ID: <87ilbhqnx3.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Matthew Anderson <ruinairas1992@gmail.com>
Cc:     tiwai@suse.com, perex@perex.cz, luke@ljones.dev,
        sbinding@opensource.cirrus.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: Add quirks for ROG ALLY CS35l41 audio
In-Reply-To: <20230621070610.70399-1-ruinairas1992@gmail.com>
References: <20230621070610.70399-1-ruinairas1992@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Wed, 21 Jun 2023 09:06:10 +0200,
Matthew Anderson wrote:
> 
> This requires a patched ACPI table or a firmware from ASUS to work because
> the system does not come with the _DSD field for the CSC3551.

Thanks.  The patch looks almost OK, but some nitpicks.

> Bug report: https://bugzilla.kernel.org/show_bug.cgi?id=217550n

This should be with "Link:" tag.
  Link: report: https://bugzilla.kernel.org/show_bug.cgi?id=217550

> +	[ALC294_FIXUP_ASUS_ALLY_PINS] = {
> +		.type = HDA_FIXUP_PINS,
> +		.v.pins = (const struct hda_pintbl[]) {
> +			{ 0x19, 0x03a11050 },
> +			{ 0x1a, 0x03a11C30 },
> +			{ 0x21, 0x03211420 },

Please use the lower letters for hex numbers.

> +	[ALC294_FIXUP_ASUS_ALLY_VERBS] = {
> +		.type = HDA_FIXUP_VERBS,
> +		.v.verbs = (const struct hda_verb[]) {
> +			{ 0x20, AC_VERB_SET_COEF_INDEX, 0x45 },
> +			{ 0x20, AC_VERB_SET_PROC_COEF, 0x5089 },
> +			{ 0x20, AC_VERB_SET_COEF_INDEX, 0x46 },
> +			{ 0x20, AC_VERB_SET_PROC_COEF, 0x0004 },
> +			{ 0x20, AC_VERB_SET_COEF_INDEX, 0x47 },
> +			{ 0x20, AC_VERB_SET_PROC_COEF, 0xA47A },
> +			{ 0x20, AC_VERB_SET_COEF_INDEX, 0x49 },
> +			{ 0x20, AC_VERB_SET_PROC_COEF, 0x0049},
> +			{ 0x20, AC_VERB_SET_COEF_INDEX, 0x4A },
> +			{ 0x20, AC_VERB_SET_PROC_COEF, 0x201B },
> +			{ 0x20, AC_VERB_SET_COEF_INDEX, 0x6B },
> +			{ 0x20, AC_VERB_SET_PROC_COEF, 0x4278},

Ditto.

> @@ -9596,6 +9641,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x10ec, 0x1254, "Intel Reference board", ALC295_FIXUP_CHROME_BOOK),
>  	SND_PCI_QUIRK(0x10ec, 0x12cc, "Intel Reference board", ALC225_FIXUP_HEADSET_JACK),
>  	SND_PCI_QUIRK(0x10f7, 0x8338, "Panasonic CF-SZ6", ALC269_FIXUP_HEADSET_MODE),
> +	SND_PCI_QUIRK(0x1043, 0x17F3, "ROG Ally RC71L_RC71L", ALC294_FIXUP_ASUS_ALLY),
>  	SND_PCI_QUIRK(0x144d, 0xc109, "Samsung Ativ book 9 (NP900X3G)", ALC269_FIXUP_INV_DMIC),
>  	SND_PCI_QUIRK(0x144d, 0xc169, "Samsung Notebook 9 Pen (NP930SBE-K01US)", ALC298_FIXUP_SAMSUNG_AMP),
>  	SND_PCI_QUIRK(0x144d, 0xc176, "Samsung Notebook 9 Pro (NP930MBE-K04US)", ALC298_FIXUP_SAMSUNG_AMP),

The table is sorted in SSID number, so please put the entry at the
right place.

Last but not least, put "v3" prefix to the patch subject at the next
time, e.g.

  Subject: [PATCH v3] ALSA: hda/realtek: ....


thanks,

Takashi